All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
	Linux Networking <netdev@vger.kernel.org>,
	Remote Direct Memory Access Kernel Subsystem 
	<linux-rdma@vger.kernel.org>,
	Linux Documentation <linux-doc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
	Leon Romanovsky <leon@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Bagas Sanjaya <bagasdotme@gmail.com>,
	Gal Pressman <gal@nvidia.com>,
	Rahul Rameshbabu <rrameshbabu@nvidia.com>,
	Maher Sanalla <msanalla@nvidia.com>,
	Moshe Shemesh <moshe@nvidia.com>,
	Tariq Toukan <tariqt@nvidia.com>,
	Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH net v2 4/4] Documentation: net/mlx5: Wrap notes in admonition blocks
Date: Tue, 16 May 2023 12:27:21 -0600	[thread overview]
Message-ID: <874joccet2.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230510035415.16956-5-bagasdotme@gmail.com>

Bagas Sanjaya <bagasdotme@gmail.com> writes:

> Wrap note paragraphs in note:: directive as it better fit for the
> purpose of noting devlink commands.
>
> Fixes: f2d51e579359b7 ("net/mlx5: Separate mlx5 driver documentation into multiple pages")
> Fixes: cf14af140a5ad0 ("net/mlx5e: Add vnic devlink health reporter to representors")
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
>  .../ethernet/mellanox/mlx5/devlink.rst             | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

So these changes seem harmless, but the Fixes: tags seem completely
inappropriate here.  This is format tweaking, not a bug fix.

Thanks,

jon

  parent reply	other threads:[~2023-05-16 18:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10  3:54 [PATCH net v2 0/4] Documentation fixes for Mellanox mlx5 devlink info Bagas Sanjaya
2023-05-10  3:54 ` [PATCH net v2 1/4] Documentation: net/mlx5: Wrap vnic reporter devlink commands in code blocks Bagas Sanjaya
2023-05-10  9:52   ` Simon Horman
2023-05-10  3:54 ` [PATCH net v2 2/4] Documentation: net/mlx5: Use bullet and definition lists for vnic counters description Bagas Sanjaya
2023-05-10  9:52   ` Simon Horman
2023-05-16 19:18   ` Daniel.Machon
2023-05-10  3:54 ` [PATCH net v2 3/4] Documentation: net/mlx5: Add blank line separator before numbered lists Bagas Sanjaya
2023-05-10  9:52   ` Simon Horman
2023-05-10  3:54 ` [PATCH net v2 4/4] Documentation: net/mlx5: Wrap notes in admonition blocks Bagas Sanjaya
2023-05-10  9:51   ` Simon Horman
2023-05-16 18:27   ` Jonathan Corbet [this message]
2023-05-16 13:29 ` [PATCH net v2 0/4] Documentation fixes for Mellanox mlx5 devlink info Bagas Sanjaya
2023-05-16 18:29   ` Jonathan Corbet
2023-05-16 22:37     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874joccet2.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=bagasdotme@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=moshe@nvidia.com \
    --cc=msanalla@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rrameshbabu@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.