From: Vagrant Cascadian <vagrant@debian.org>
To: Jonas Karlman <jonas@kwiboo.se>, Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Kever Yang <kever.yang@rock-chips.com>
Cc: Jagan Teki <jagan@edgeble.ai>, YouMin Chen <cym@rock-chips.com>,
u-boot@lists.denx.de, Jonas Karlman <jonas@kwiboo.se>
Subject: Re: [PATCH] rockchip: dts: rk3328: fix sdram params
Date: Wed, 22 Feb 2023 13:42:44 -0800 [thread overview]
Message-ID: <874jrdxtpn.fsf@contorta> (raw)
In-Reply-To: <20230210183002.114902-1-jonas@kwiboo.se>
[-- Attachment #1: Type: text/plain, Size: 3465 bytes --]
On 2023-02-10, Jonas Karlman wrote:
> The rk3328 sdram driver read sdram parameters from the devicetree into a
> struct rk3328_sdram_params using dev_read_u32_array.
>
> After commit 5ab30c3176bf ("ram: rockchip: Update ddr pctl regs for px30")
> changed the size of struct ddr_pctl_regs, a member of struct
> rk3328_sdram_params, U-Boot TPL can no longer initialize DRAM on RK3328.
>
> Add ten u32 to the sdram parameter array in devicetree to align with
> this size change. This fixes DRAM initialization on RK3328.
>
> Fixes: 5ab30c3176bf ("ram: rockchip: Update ddr pctl regs for px30")
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
> Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
> Tested-by: Jagan Teki <jagan@amarulasolutions.com> # roc-rk3328-cc
Thanks! This allows booting the rock64-rk3328 with v2023.04-rc2, which
otherwise just hangs after loading TPL (or SPL?).
Tested-by: Vagrant Cascadian <vagrant@debian.org>
> ---
> arch/arm/dts/rk3328-sdram-ddr3-666.dtsi | 10 ++++++++++
> arch/arm/dts/rk3328-sdram-ddr4-666.dtsi | 10 ++++++++++
> arch/arm/dts/rk3328-sdram-lpddr3-1600.dtsi | 10 ++++++++++
> arch/arm/dts/rk3328-sdram-lpddr3-666.dtsi | 10 ++++++++++
> 4 files changed, 40 insertions(+)
>
> diff --git a/arch/arm/dts/rk3328-sdram-ddr3-666.dtsi b/arch/arm/dts/rk3328-sdram-ddr3-666.dtsi
> index 3e88ed443ba0..c5acfe4ac2a0 100644
> --- a/arch/arm/dts/rk3328-sdram-ddr3-666.dtsi
> +++ b/arch/arm/dts/rk3328-sdram-ddr3-666.dtsi
> @@ -92,6 +92,16 @@
> 0xffffffff
> 0xffffffff
> 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
>
> 0x00000004
> 0x0000000a
> diff --git a/arch/arm/dts/rk3328-sdram-ddr4-666.dtsi b/arch/arm/dts/rk3328-sdram-ddr4-666.dtsi
> index 0859649a6905..c5fa2903c5c1 100644
> --- a/arch/arm/dts/rk3328-sdram-ddr4-666.dtsi
> +++ b/arch/arm/dts/rk3328-sdram-ddr4-666.dtsi
> @@ -89,6 +89,16 @@
> 0xffffffff
> 0xffffffff
> 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
>
> 0x00000004
> 0x0000000c
> diff --git a/arch/arm/dts/rk3328-sdram-lpddr3-1600.dtsi b/arch/arm/dts/rk3328-sdram-lpddr3-1600.dtsi
> index d63c761a0283..07f27b2b7bab 100644
> --- a/arch/arm/dts/rk3328-sdram-lpddr3-1600.dtsi
> +++ b/arch/arm/dts/rk3328-sdram-lpddr3-1600.dtsi
> @@ -92,6 +92,16 @@
> 0xffffffff
> 0xffffffff
> 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
>
> 0x00000004
> 0x0000000b
> diff --git a/arch/arm/dts/rk3328-sdram-lpddr3-666.dtsi b/arch/arm/dts/rk3328-sdram-lpddr3-666.dtsi
> index df42bb29ce88..d53d3a0fdfb2 100644
> --- a/arch/arm/dts/rk3328-sdram-lpddr3-666.dtsi
> +++ b/arch/arm/dts/rk3328-sdram-lpddr3-666.dtsi
> @@ -92,6 +92,16 @@
> 0xffffffff
> 0xffffffff
> 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
> + 0xffffffff
>
> 0x00000004
> 0x0000000b
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
prev parent reply other threads:[~2023-02-22 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 18:30 [PATCH] rockchip: dts: rk3328: fix sdram params Jonas Karlman
2023-02-13 4:27 ` Simon Glass
2023-02-13 6:58 ` Kever Yang
2023-02-17 18:07 ` Jagan Teki
2023-02-17 18:09 ` Jagan Teki
2023-02-17 18:30 ` Tom Rini
2023-02-22 21:42 ` Vagrant Cascadian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jrdxtpn.fsf@contorta \
--to=vagrant@debian.org \
--cc=cym@rock-chips.com \
--cc=jagan@edgeble.ai \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.