All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Avihai Horon <avihaih@nvidia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"John Snow" <jsnow@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Fam Zheng" <fam@euphon.net>, "Thomas Huth" <thuth@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
	qemu-s390x@nongnu.org,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Coiby Xu" <Coiby.Xu@gmail.com>,
	"Ilya Leoshkevich" <iii@linux.ibm.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Eric Farman" <farman@linux.ibm.com>
Subject: Re: [PULL 03/30] migration: Split save_live_pending() into state_pending_*
Date: Thu, 09 Feb 2023 16:24:26 +0100	[thread overview]
Message-ID: <874jru50b9.fsf@secure.mitica> (raw)
In-Reply-To: <2c982100-990b-dcdd-bd4a-ff8dce33e59f@nvidia.com> (Avihai Horon's message of "Thu, 9 Feb 2023 09:48:37 +0200")

Avihai Horon <avihaih@nvidia.com> wrote:
> On 07/02/2023 2:56, Juan Quintela wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> We split the function into to:
>>
>> - state_pending_estimate: We estimate the remaining state size without
>>    stopping the machine.
>>
>> - state pending_exact: We calculate the exact amount of remaining
>>    state.
>>
>> The only "device" that implements different functions for _estimate()
>> and _exact() is ram.
>>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> I only noticed it now while rebasing my series on top of yours.
>
> I think the exact and estimate callbacks got mixed up here: we call
> .state_pending_estimate() in qemu_savevm_state_pending_exact() and
> .state_pending_exact() in qemu_savevm_state_pending_estimate().
> Also need to switch the !se->ops->state_pending_exact/estimate checks.

Good catch.
Sent a patch to fix it.

Thanks a lot.



  reply	other threads:[~2023-02-09 15:24 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07  0:56 [PULL 00/30] Migration 20230206 patches Juan Quintela
2023-02-07  0:56 ` [PULL 01/30] migration: Fix migration crash when target psize larger than host Juan Quintela
2023-02-10  9:32   ` Michael Tokarev
2023-02-10 12:11     ` Juan Quintela
2023-02-10 15:01       ` Peter Xu
2023-02-10 15:15         ` Juan Quintela
2023-02-10 15:28         ` Michael Tokarev
2023-02-10 15:48           ` Peter Xu
2023-02-07  0:56 ` [PULL 02/30] migration: No save_live_pending() method uses the QEMUFile parameter Juan Quintela
2023-02-07  0:56 ` [PULL 03/30] migration: Split save_live_pending() into state_pending_* Juan Quintela
2023-02-09  7:48   ` Avihai Horon
2023-02-09 15:24     ` Juan Quintela [this message]
2023-03-24 18:41   ` s390x TCG migration failure Nina Schoetterl-Glausch
2023-03-28 13:01     ` Thomas Huth
2023-03-28 22:21       ` Nina Schoetterl-Glausch
2023-03-29  6:36         ` Thomas Huth
2023-04-04 15:18           ` Thomas Huth
2023-04-12 20:31     ` Juan Quintela
2023-04-12 20:46     ` Juan Quintela
2023-04-12 21:01     ` Juan Quintela
2023-04-13 11:42       ` Nina Schoetterl-Glausch
2023-02-07  0:56 ` [PULL 04/30] migration: Remove unused threshold_size parameter Juan Quintela
2023-02-07  0:56 ` [PULL 05/30] migration: simplify migration_iteration_run() Juan Quintela
2023-02-07  0:56 ` [PULL 06/30] util/userfaultfd: Add uffd_open() Juan Quintela
2023-02-07  0:56 ` [PULL 07/30] migration/ram: Fix populate_read_range() Juan Quintela
2023-02-07  0:56 ` [PULL 08/30] migration/ram: Fix error handling in ram_write_tracking_start() Juan Quintela
2023-02-07  0:56 ` [PULL 09/30] migration/ram: Don't explicitly unprotect when unregistering uffd-wp Juan Quintela
2023-02-07  0:56 ` [PULL 10/30] migration/ram: Rely on used_length for uffd_change_protection() Juan Quintela
2023-02-07  0:56 ` [PULL 11/30] migration/ram: Optimize ram_write_tracking_start() for RamDiscardManager Juan Quintela
2023-02-07  0:56 ` [PULL 12/30] migration/savevm: Move more savevm handling into vmstate_save() Juan Quintela
2023-02-07  0:56 ` [PULL 13/30] migration/savevm: Prepare vmdesc json writer in qemu_savevm_state_setup() Juan Quintela
2023-02-07  0:56 ` [PULL 14/30] migration/savevm: Allow immutable device state to be migrated early (i.e., before RAM) Juan Quintela
2023-02-07  0:56 ` [PULL 15/30] migration/vmstate: Introduce VMSTATE_WITH_TMP_TEST() and VMSTATE_BITMAP_TEST() Juan Quintela
2023-02-07  0:56 ` [PULL 16/30] migration/ram: Factor out check for advised postcopy Juan Quintela
2023-02-07  0:56 ` [PULL 17/30] virtio-mem: Fail if a memory backend with "prealloc=on" is specified Juan Quintela
2023-02-07  0:56 ` [PULL 18/30] virtio-mem: Migrate immutable properties early Juan Quintela
2023-02-07  0:56 ` [PULL 19/30] virtio-mem: Proper support for preallocation with migration Juan Quintela
2023-02-07  0:56 ` [PULL 20/30] migration: Show downtime during postcopy phase Juan Quintela
2023-02-07  0:56 ` [PULL 21/30] migration/rdma: fix return value for qio_channel_rdma_{readv, writev} Juan Quintela
2023-02-07  0:56 ` [PULL 22/30] migration: Add canary to VMSTATE_END_OF_LIST Juan Quintela
2023-02-07  0:56 ` [PULL 23/30] migration: Perform vmsd structure check during tests Juan Quintela
2023-02-07  0:56 ` [PULL 24/30] migration/dirtyrate: Show sample pages only in page-sampling mode Juan Quintela
2023-02-07  0:56 ` [PULL 25/30] io: Add support for MSG_PEEK for socket channel Juan Quintela
2023-02-07  0:56 ` [PULL 26/30] migration: check magic value for deciding the mapping of channels Juan Quintela
2023-02-07  0:56 ` [PULL 27/30] multifd: Fix a race on reading MultiFDPages_t.block Juan Quintela
2023-02-07  0:56 ` [PULL 28/30] multifd: Fix flush of zero copy page send request Juan Quintela
2023-02-09  1:27   ` Duan, Zhenzhong
2023-02-09 12:29     ` Juan Quintela
2023-02-07  0:56 ` [PULL 29/30] migration: Introduce interface query-migrationthreads Juan Quintela
2023-02-07  0:56 ` [PULL 30/30] migration: save/delete migration thread info Juan Quintela
2023-02-07 16:52 ` [PULL 00/30] Migration 20230206 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jru50b9.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=Coiby.Xu@gmail.com \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=avihaih@nvidia.com \
    --cc=berrange@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=fam@euphon.net \
    --cc=farman@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=jsnow@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.