From: Juan Quintela <quintela@redhat.com>
To: Het Gala <het.gala@nutanix.com>
Cc: qemu-devel@nongnu.org, prerna.saxena@nutanix.com,
dgilbert@redhat.com, pbonzini@redhat.com, berrange@redhat.com,
armbru@redhat.com, eblake@redhat.com,
manish.mishra@nutanix.com, aravind.retnakaran@nutanix.com
Subject: Re: [PATCH v3 1/6] migration: moved hmp_split_at_commma() helper func to qapi-util.c file
Date: Thu, 09 Feb 2023 12:56:39 +0100 [thread overview]
Message-ID: <874jrv6oi0.fsf@secure.mitica> (raw)
In-Reply-To: <20230209102754.81578-2-het.gala@nutanix.com> (Het Gala's message of "Thu, 9 Feb 2023 10:27:49 +0000")
Het Gala <het.gala@nutanix.com> wrote:
> renamed hmp_split_at_comma() --> str_split_at_comma()
> Shifted helper function to qapi-util.c file. Give external linkage, as
> this function will be handy in coming commit for migration.
>
> Minor correction:
> g_strsplit(str ?: "", ",", -1) --> g_strsplit(str ? str : "", ",", -1)
>
Reviewed-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
But I can't find this reviewed by emails neither on list or in my INBOX.
You can add this lines when someone answer with a mail that explicitely
contains them.
Later, Juan.
next prev parent reply other threads:[~2023-02-09 11:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 10:27 [PATCH v3 0/6] migration: Modified 'migrate' QAPI command for migration Het Gala
2023-02-09 10:27 ` [PATCH v3 1/6] migration: moved hmp_split_at_commma() helper func to qapi-util.c file Het Gala
2023-02-09 11:56 ` Juan Quintela [this message]
2023-02-09 11:57 ` Daniel P. Berrangé
2023-02-09 12:04 ` Alex Bennée
2023-02-09 10:27 ` [PATCH v3 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command Het Gala
2023-02-10 9:07 ` Markus Armbruster
2023-02-09 10:27 ` [PATCH v3 3/6] migration: HMP side changes for modified 'migrate' QAPI design Het Gala
2023-02-09 10:27 ` [PATCH v3 4/6] migration: Avoid multiple parsing of uri in migration code flow Het Gala
2023-02-09 10:27 ` [PATCH v3 5/6] migration: Modified 'migrate-incoming' QAPI and HMP side changes on the destination interface Het Gala
2023-02-09 10:27 ` [PATCH v3 6/6] migration: Established connection for listener sockets on the dest interface Het Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jrv6oi0.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=aravind.retnakaran@nutanix.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=het.gala@nutanix.com \
--cc=manish.mishra@nutanix.com \
--cc=pbonzini@redhat.com \
--cc=prerna.saxena@nutanix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.