From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Stefano Garzarella <sgarzare@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
virtio-fs@redhat.com,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Fam Zheng <fam@euphon.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
German Maglione <gmaglione@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Raphael Norwitz <raphael.norwitz@nutanix.com>,
Hanna Reitz <hreitz@redhat.com>,
qemu-block@nongnu.org, "Gonglei (Arei)" <arei.gonglei@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Virtio-fs] [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices
Date: Thu, 01 Dec 2022 12:21:21 +0000 [thread overview]
Message-ID: <874jufcnzi.fsf@linaro.org> (raw)
In-Reply-To: <20221201052647-mutt-send-email-mst@kernel.org>
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Thu, Dec 01, 2022 at 10:14:39AM +0000, Alex Bennée wrote:
>> Do you think rust-vmm's vhost crates have enough of the state
>> management to manage vhost and vhost-user backends? Maybe it would be a
>> good experiment in replacing a (small well defined) piece of
>> functionality with rust?
>>
>> That said there is a lot of deep magic in the vhost-net stuff which I
>> think is down to the interaction with things like vdpk and other network
>> optimisations that might be missing. For the rest of the devices most of
>> the code is basically boiler plate which has grown variations due to
>> code motion and change. This is the sort of thing that generics solves
>> well.
>
> Not sure what you want to replace with what though, libvhost-user or
> vhost-user bits in qemu?
The vhost-user bits in the main QEMU binary. We already don't use
libvhost-user for most of our backends anyway ;-)
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Stefano Garzarella <sgarzare@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
virtio-fs@redhat.com,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Fam Zheng <fam@euphon.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
German Maglione <gmaglione@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Raphael Norwitz <raphael.norwitz@nutanix.com>,
Hanna Reitz <hreitz@redhat.com>,
qemu-block@nongnu.org, "Gonglei (Arei)" <arei.gonglei@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices
Date: Thu, 01 Dec 2022 12:21:21 +0000 [thread overview]
Message-ID: <874jufcnzi.fsf@linaro.org> (raw)
In-Reply-To: <20221201052647-mutt-send-email-mst@kernel.org>
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Thu, Dec 01, 2022 at 10:14:39AM +0000, Alex Bennée wrote:
>> Do you think rust-vmm's vhost crates have enough of the state
>> management to manage vhost and vhost-user backends? Maybe it would be a
>> good experiment in replacing a (small well defined) piece of
>> functionality with rust?
>>
>> That said there is a lot of deep magic in the vhost-net stuff which I
>> think is down to the interaction with things like vdpk and other network
>> optimisations that might be missing. For the rest of the devices most of
>> the code is basically boiler plate which has grown variations due to
>> code motion and change. This is the sort of thing that generics solves
>> well.
>
> Not sure what you want to replace with what though, libvhost-user or
> vhost-user bits in qemu?
The vhost-user bits in the main QEMU binary. We already don't use
libvhost-user for most of our backends anyway ;-)
--
Alex Bennée
next prev parent reply other threads:[~2022-12-01 12:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 13:16 [Virtio-fs] [PATCH for-7.2] vhost: enable vrings in vhost_dev_start() for vhost-user devices Stefano Garzarella
2022-11-23 13:16 ` Stefano Garzarella
2022-11-24 0:19 ` [Virtio-fs] " Raphael Norwitz
2022-11-24 0:19 ` Raphael Norwitz
2022-11-24 6:50 ` [Virtio-fs] " Michael S. Tsirkin
2022-11-24 6:50 ` Michael S. Tsirkin
2022-11-24 7:54 ` [Virtio-fs] " Stefano Garzarella
2022-11-24 7:54 ` Stefano Garzarella
2022-11-24 13:50 ` [Virtio-fs] " Raphael Norwitz
2022-11-24 13:50 ` Raphael Norwitz
2022-11-24 18:36 ` [Virtio-fs] " Stefan Hajnoczi
2022-11-24 18:36 ` Stefan Hajnoczi
2022-11-25 8:12 ` [Virtio-fs] " Stefano Garzarella
2022-11-25 8:12 ` Stefano Garzarella
2022-11-30 21:03 ` [Virtio-fs] " Stefan Hajnoczi
2022-11-30 21:03 ` Stefan Hajnoczi
2022-12-01 7:04 ` [Virtio-fs] " Michael S. Tsirkin
2022-12-01 7:04 ` Michael S. Tsirkin
2022-12-01 8:02 ` [Virtio-fs] " Stefano Garzarella
2022-12-01 8:02 ` Stefano Garzarella
2022-12-01 10:14 ` [Virtio-fs] " Alex Bennée
2022-12-01 10:14 ` Alex Bennée
2022-12-01 10:34 ` [Virtio-fs] " Michael S. Tsirkin
2022-12-01 10:34 ` Michael S. Tsirkin
2022-12-01 12:21 ` Alex Bennée [this message]
2022-12-01 12:21 ` Alex Bennée
2022-12-01 21:49 ` [Virtio-fs] " Michael S. Tsirkin
2022-12-01 21:49 ` Michael S. Tsirkin
2022-12-05 9:29 ` [Virtio-fs] " Stefano Garzarella
2022-12-05 9:29 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jufcnzi.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=arei.gonglei@huawei.com \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=gmaglione@redhat.com \
--cc=hreitz@redhat.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=viresh.kumar@linaro.org \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.