From: John Ogness <john.ogness@linutronix.de>
To: yang.yang29@zte.com.cn, pmladek@suse.com
Cc: senozhatsky@chromium.org, rostedt@goodmis.org,
linux-kernel@vger.kernel.org, xu.panda@zte.com.cn,
yang.yang29@zte.com.cn
Subject: Re: [PATCH linux-next] printk: use strscpy() to instead of strlcpy()
Date: Wed, 30 Nov 2022 10:17:07 +0106 [thread overview]
Message-ID: <874jugx0wk.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <202211301601416229001@zte.com.cn>
On 2022-11-30, <yang.yang29@zte.com.cn> wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
This looks fine, but I am wondering if we should also replace all
strncpy() usage as well. AFAICT they can all be replaced. It would also
avoid the manual termination in console_setup().
John Ogness
next prev parent reply other threads:[~2022-11-30 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 8:01 [PATCH linux-next] printk: use strscpy() to instead of strlcpy() yang.yang29
2022-11-30 9:11 ` John Ogness [this message]
2022-11-30 10:43 ` Petr Mladek
2022-11-30 10:39 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jugx0wk.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=xu.panda@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.