Re: [igt-dev] [PATCH i-g-t 01/14] tools/intel_vbt_decode: Simplify fast link training lane count

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 15 Jul 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Get rid of the pointless switch statement and decode the
> fast link training lane count as just <val>+1. We already
> do the same for the DSI lane count.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  tools/intel_vbt_decode.c | 18 ++----------------
>  1 file changed, 2 insertions(+), 16 deletions(-)
>
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index 5494a34bdca3..1ed03745bd05 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -1420,22 +1420,8 @@ static void dump_edp(struct context *context,
>  			       edp->fast_link_params[i].rate);
>  			break;
>  		}
> -		printf("\t\t\tlanes: ");
> -		switch (edp->fast_link_params[i].lanes) {
> -		case EDP_LANE_1:
> -			printf("x1 mode\n");
> -			break;
> -		case EDP_LANE_2:
> -			printf("x2 mode\n");
> -			break;
> -		case EDP_LANE_4:
> -			printf("x4 mode\n");
> -			break;
> -		default:
> -			printf("(unknown value %d)\n",
> -			       edp->fast_link_params[i].lanes);
> -			break;
> -		}
> +		printf("\t\t\tlanes: X%d",
> +		       edp->fast_link_params[i].lanes + 1);
>  		printf("\t\t\tpre-emphasis: ");
>  		switch (edp->fast_link_params[i].preemphasis) {
>  		case EDP_PREEMPHASIS_NONE:

-- 
Jani Nikula, Intel Open Source Graphics Center