From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F983CCA473 for ; Mon, 6 Jun 2022 08:42:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A0C154B11A; Mon, 6 Jun 2022 04:42:00 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ntfPtBMNZOkT; Mon, 6 Jun 2022 04:41:59 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7A4134B1FE; Mon, 6 Jun 2022 04:41:59 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 78E3E4B1E7 for ; Mon, 6 Jun 2022 04:41:58 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZvXmmv+XZkm1 for ; Mon, 6 Jun 2022 04:41:57 -0400 (EDT) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 6585E4B103 for ; Mon, 6 Jun 2022 04:41:57 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 46A676125B; Mon, 6 Jun 2022 08:41:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17BBEC341C0; Mon, 6 Jun 2022 08:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654504915; bh=WEpdSScadxR+JARqfRrZFpuBLMA2IajY1B95jy1+CZg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=McpTIIYILr+cbsE4dNsA4Ol5HKdNcBTyDd5+BP+sQCCu/NevG0uISr/Ayfq5kZFFJ /96/R6tQBIdRGTpwDnjw2e4BKDJ2ztjiaKwwnqmye6w/munE6DP45M4uK3Y5czkoNu sRT8eTDygoKyy2DEKigpGyIWyvMzSiy+hS0oWzNuYGhexvnl2uOQOsNXj9XurAgYR7 ai68WctF7E8uPessLAk415g5Jwm6rTabnVoLqgApn8BJ9ckyzCw0uFPeqUbLgVB7zP qjvrrCF1vmmNXSLNIZG8xYCI+umhmvUujfEab1UuVwGLvjk5zlYerwhi1qX3GKFnPM x0a4xv+gg7qNg== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ny8J6-00Fpzn-MT; Mon, 06 Jun 2022 09:41:52 +0100 Date: Mon, 06 Jun 2022 09:41:52 +0100 Message-ID: <874k0y5gkv.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Subject: Re: [PATCH 04/18] KVM: arm64: Move FP state ownership from flag to a tristate In-Reply-To: References: <20220528113829.1043361-1-maz@kernel.org> <20220528113829.1043361-5-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, alexandru.elisei@arm.com, oupton@google.com, will@kernel.org, tabba@google.com, qperret@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kernel-team@android.com, kvm@vger.kernel.org, Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, 03 Jun 2022 10:14:11 +0100, Mark Brown wrote: > > On Sat, May 28, 2022 at 12:38:14PM +0100, Marc Zyngier wrote: > > > As it turns out, this isn't really a good match for flags, and > > we'd be better off if this was a simpler tristate, each state > > having a name that actually reflect the state: > > > > - FP_STATE_CLEAN > > - FP_STATE_HOST_DIRTY > > - FP_STATE_GUEST_DIRTY > > I had to think a bit more than I liked about the _DIRTY in the > names of the host and guest flags, but that's really just > bikeshedding and not a meaningful issue. Another option was: - FP_STATE_FREE - FP_STATE_HOST_OWNED - FP_STATE_GUEST_OWNED I don't mind wither way. > Reviewed-by: Mark Brown Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61104C43334 for ; Mon, 6 Jun 2022 08:43:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vcF1ZjOLLQvELqj0zr+l2puiKZBjsNcU+rOb6HhpomY=; b=d6g9kmz7gxESRl X7aOk9wrRN5QRP9sL7KKdtHvdhsSKjtmTm5j9FmeFUx38n+eqqovCmyJXmFYXCCCBKyHZaZXTWywG QlHvFr0zXmZupPEnK/yo+f874f4vcrJNU7a52HlvCnz99hobhydgstuF/6NIgn7C9Wp310C/iish7 vO8yKn7LgO1apauxXTjf2ACALu2I1sRpHiTn8UyW0NxlZ5EEFNqoxCitkWHkYxCcZgZSaPxvzZbMC n1dVUsIL6d8DT1tCZQ+W8Mq+q1crc5+6Dr7ooiijmALxBReosb3YwQ+fwv+joNANV1s+NVKdVCQyB a3gsSADmg1X4+0QNypmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ny8JD-000B8d-Pa; Mon, 06 Jun 2022 08:41:59 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ny8JB-000B7U-8l for linux-arm-kernel@lists.infradead.org; Mon, 06 Jun 2022 08:41:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 46A676125B; Mon, 6 Jun 2022 08:41:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17BBEC341C0; Mon, 6 Jun 2022 08:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654504915; bh=WEpdSScadxR+JARqfRrZFpuBLMA2IajY1B95jy1+CZg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=McpTIIYILr+cbsE4dNsA4Ol5HKdNcBTyDd5+BP+sQCCu/NevG0uISr/Ayfq5kZFFJ /96/R6tQBIdRGTpwDnjw2e4BKDJ2ztjiaKwwnqmye6w/munE6DP45M4uK3Y5czkoNu sRT8eTDygoKyy2DEKigpGyIWyvMzSiy+hS0oWzNuYGhexvnl2uOQOsNXj9XurAgYR7 ai68WctF7E8uPessLAk415g5Jwm6rTabnVoLqgApn8BJ9ckyzCw0uFPeqUbLgVB7zP qjvrrCF1vmmNXSLNIZG8xYCI+umhmvUujfEab1UuVwGLvjk5zlYerwhi1qX3GKFnPM x0a4xv+gg7qNg== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ny8J6-00Fpzn-MT; Mon, 06 Jun 2022 09:41:52 +0100 Date: Mon, 06 Jun 2022 09:41:52 +0100 Message-ID: <874k0y5gkv.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Alexandru Elisei , Oliver Upton , Will Deacon , Fuad Tabba , Quentin Perret , kernel-team@android.com Subject: Re: [PATCH 04/18] KVM: arm64: Move FP state ownership from flag to a tristate In-Reply-To: References: <20220528113829.1043361-1-maz@kernel.org> <20220528113829.1043361-5-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, alexandru.elisei@arm.com, oupton@google.com, will@kernel.org, tabba@google.com, qperret@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_014157_385509_3B083A5C X-CRM114-Status: GOOD ( 19.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 03 Jun 2022 10:14:11 +0100, Mark Brown wrote: > > On Sat, May 28, 2022 at 12:38:14PM +0100, Marc Zyngier wrote: > > > As it turns out, this isn't really a good match for flags, and > > we'd be better off if this was a simpler tristate, each state > > having a name that actually reflect the state: > > > > - FP_STATE_CLEAN > > - FP_STATE_HOST_DIRTY > > - FP_STATE_GUEST_DIRTY > > I had to think a bit more than I liked about the _DIRTY in the > names of the host and guest flags, but that's really just > bikeshedding and not a meaningful issue. Another option was: - FP_STATE_FREE - FP_STATE_HOST_OWNED - FP_STATE_GUEST_OWNED I don't mind wither way. > Reviewed-by: Mark Brown Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42200C433EF for ; Mon, 6 Jun 2022 08:44:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232440AbiFFIoB (ORCPT ); Mon, 6 Jun 2022 04:44:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232277AbiFFIng (ORCPT ); Mon, 6 Jun 2022 04:43:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E54213C1CE for ; Mon, 6 Jun 2022 01:42:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5900EB8123A for ; Mon, 6 Jun 2022 08:41:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17BBEC341C0; Mon, 6 Jun 2022 08:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654504915; bh=WEpdSScadxR+JARqfRrZFpuBLMA2IajY1B95jy1+CZg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=McpTIIYILr+cbsE4dNsA4Ol5HKdNcBTyDd5+BP+sQCCu/NevG0uISr/Ayfq5kZFFJ /96/R6tQBIdRGTpwDnjw2e4BKDJ2ztjiaKwwnqmye6w/munE6DP45M4uK3Y5czkoNu sRT8eTDygoKyy2DEKigpGyIWyvMzSiy+hS0oWzNuYGhexvnl2uOQOsNXj9XurAgYR7 ai68WctF7E8uPessLAk415g5Jwm6rTabnVoLqgApn8BJ9ckyzCw0uFPeqUbLgVB7zP qjvrrCF1vmmNXSLNIZG8xYCI+umhmvUujfEab1UuVwGLvjk5zlYerwhi1qX3GKFnPM x0a4xv+gg7qNg== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ny8J6-00Fpzn-MT; Mon, 06 Jun 2022 09:41:52 +0100 Date: Mon, 06 Jun 2022 09:41:52 +0100 Message-ID: <874k0y5gkv.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Alexandru Elisei , Oliver Upton , Will Deacon , Fuad Tabba , Quentin Perret , kernel-team@android.com Subject: Re: [PATCH 04/18] KVM: arm64: Move FP state ownership from flag to a tristate In-Reply-To: References: <20220528113829.1043361-1-maz@kernel.org> <20220528113829.1043361-5-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, alexandru.elisei@arm.com, oupton@google.com, will@kernel.org, tabba@google.com, qperret@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, 03 Jun 2022 10:14:11 +0100, Mark Brown wrote: > > On Sat, May 28, 2022 at 12:38:14PM +0100, Marc Zyngier wrote: > > > As it turns out, this isn't really a good match for flags, and > > we'd be better off if this was a simpler tristate, each state > > having a name that actually reflect the state: > > > > - FP_STATE_CLEAN > > - FP_STATE_HOST_DIRTY > > - FP_STATE_GUEST_DIRTY > > I had to think a bit more than I liked about the _DIRTY in the > names of the host and guest flags, but that's really just > bikeshedding and not a meaningful issue. Another option was: - FP_STATE_FREE - FP_STATE_HOST_OWNED - FP_STATE_GUEST_OWNED I don't mind wither way. > Reviewed-by: Mark Brown Thanks, M. -- Without deviation from the norm, progress is not possible.