From: Markus Armbruster <armbru@redhat.com>
To: Andrea Bolognani <abologna@redhat.com>
Cc: qemu-devel@nongnu.org, "Eric Blake" <eblake@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH] qapi: Fix incorrect Since tags
Date: Tue, 03 May 2022 10:44:37 +0200 [thread overview]
Message-ID: <874k27dmyy.fsf@pond.sub.org> (raw)
In-Reply-To: <20220503082748.89847-1-abologna@redhat.com> (Andrea Bolognani's message of "Tue, 3 May 2022 10:27:48 +0200")
Andrea Bolognani <abologna@redhat.com> writes:
> The missing colon causes them to be interpreted as regular
> text.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
> qapi/crypto.json | 2 +-
> qapi/misc.json | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/crypto.json b/qapi/crypto.json
> index 1ec54c15ca..529aa730d4 100644
> --- a/qapi/crypto.json
> +++ b/qapi/crypto.json
> @@ -358,7 +358,7 @@
> # Defaults to the same secret that was used to open the image
> #
> #
> -# Since 5.1
> +# Since: 5.1
> ##
> { 'struct': 'QCryptoBlockAmendOptionsLUKS',
> 'data': { 'state': 'QCryptoBlockLUKSKeyslotState',
> diff --git a/qapi/misc.json b/qapi/misc.json
> index b83cc39029..f8a9feda30 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -188,7 +188,7 @@
> # Features:
> # @unstable: This command is experimental.
> #
> -# Since 3.0
> +# Since: 3.0
> #
> # Returns: nothing
> #
I posted a more complete fix as "[PATCH] qapi: Fix malformed "Since:"
section tags", and you even reviewed it :)
Thanks anyway!
next prev parent reply other threads:[~2022-05-03 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 8:27 [PATCH] qapi: Fix incorrect Since tags Andrea Bolognani
2022-05-03 8:44 ` Markus Armbruster [this message]
2022-05-03 9:46 ` Andrea Bolognani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k27dmyy.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=abologna@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.