All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 1/3] qapi-schema: support alternates with array type
Date: Tue, 22 Mar 2022 10:48:47 +0100	[thread overview]
Message-ID: <874k3qjp1c.fsf@pond.sub.org> (raw)
In-Reply-To: <20220321164243.200569-2-pbonzini@redhat.com> (Paolo Bonzini's message of "Mon, 21 Mar 2022 17:42:41 +0100")

Paolo Bonzini <pbonzini@redhat.com> writes:

> Detect array types as alternate branches, and turn the JSON list into
> a QAPISchemaArrayType.  Array types in an alternate are represented with
> QTYPE_QLIST in the type field.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

I double-checked the generated code; it looks good to me.

Thanks for implementing this, and extra thanks for the tests!

Reviewed-by: Markus Armbruster <armbru@redhat.com>



  reply	other threads:[~2022-03-22  9:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21 16:42 [PATCH 0/3] qapi-schema: support alternates with array type Paolo Bonzini
2022-03-21 16:42 ` [PATCH 1/3] " Paolo Bonzini
2022-03-22  9:48   ` Markus Armbruster [this message]
2022-04-18 14:52     ` Paolo Bonzini
2022-03-21 16:42 ` [PATCH 2/3] qapi-schema: test: add a qapi-schema-test for array alternates Paolo Bonzini
2022-03-22  9:46   ` Markus Armbruster
2022-03-21 16:42 ` [PATCH 3/3] qapi-schema: test: add a unit test for parsing " Paolo Bonzini
2022-03-22  9:47   ` Markus Armbruster
2022-04-04 12:13 ` [PATCH 0/3] qapi-schema: support alternates with array type Markus Armbruster
2022-04-18 14:50   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k3qjp1c.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.