All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: David Edmondson <david.edmondson@oracle.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH v3 2/2] migration: Tally pre-copy, downtime and post-copy bytes independently
Date: Thu, 27 Jan 2022 10:12:59 +0100	[thread overview]
Message-ID: <874k5pmtic.fsf@secure.mitica> (raw)
In-Reply-To: <20211221093441.1445590-3-david.edmondson@oracle.com> (David Edmondson's message of "Tue, 21 Dec 2021 09:34:41 +0000")

David Edmondson <david.edmondson@oracle.com> wrote:
> Provide information on the number of bytes copied in the pre-copy,
> downtime and post-copy phases of migration.
>
> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

queued.

>  static void ram_transferred_add(uint64_t bytes)
>  {
> +    if (runstate_is_running()) {
> +        ram_counters.precopy_bytes += bytes;
> +    } else if (migration_in_postcopy()) {
> +        ram_counters.postcopy_bytes += bytes;
> +    } else {
> +        ram_counters.downtime_bytes += bytes;
> +    }
>      ram_counters.transferred += bytes;
>  }

Now transferred can be calculated from the other three fields, but
changing it needs too many changes.

Later, Juan.



      reply	other threads:[~2022-01-27  9:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21  9:34 [PATCH v3 0/2] migration: Tally pre-copy, downtime and post-copy bytes independently David Edmondson
2021-12-21  9:34 ` [PATCH v3 1/2] migration: Introduce ram_transferred_add() David Edmondson
2022-01-27  9:11   ` Juan Quintela
2021-12-21  9:34 ` [PATCH v3 2/2] migration: Tally pre-copy, downtime and post-copy bytes independently David Edmondson
2022-01-27  9:12   ` Juan Quintela [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k5pmtic.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=armbru@redhat.com \
    --cc=david.edmondson@oracle.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.