From: Cornelia Huck <cohuck@redhat.com>
To: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Cc: virtio-dev@lists.oasis-open.org,
Stefan Hajnoczi <stefanha@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
David Hildenbrand <david@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Taylor Stark <tstark@linux.microsoft.com>,
Pankaj Gupta <pankaj.gupta@ionos.com>
Subject: [virtio-dev] Re: [PATCH v6] virtio-pmem: PMEM device spec
Date: Fri, 15 Oct 2021 13:13:30 +0200 [thread overview]
Message-ID: <874k9iv8v9.fsf@redhat.com> (raw)
In-Reply-To: <CAM9Jb+isBoXr2TNb9zswOeALcS4h9E-pAesD2amUdiHUibOqNg@mail.gmail.com>
On Fri, Oct 15 2021, Pankaj Gupta <pankaj.gupta.linux@gmail.com> wrote:
>> So, I ran into some problems while trying to apply this.
>>
>> First, this is against an older version of the tree, so it did not apply
>> cleanly.
>
> Sorry! somehow i missed this.
No worries, I fixed that up; but rebasing makes things easier for the
person applying it.
>>
>> Second, the conformance section looks off: we don't have a driver
>> conformance section, and the device conformance section ends up being
>> called a driver conformance section. Unfortunately, I had neglected to
>> review that properly :(
>>
>> I think the following would be correct; I'm inclined to apply this spec
>> with it as an editorial edit. Any comments/objections?
>
> my bad :(
>
> Thank you for your help!
> Hope this makes into master now.
I pushed this out now. If something is off, we can fix that on top.
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2021-10-15 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 10:32 [PATCH v6] virtio-pmem: PMEM device spec Pankaj Gupta
2021-10-06 13:28 ` Pankaj Gupta
2021-10-14 16:20 ` [virtio-dev] " Cornelia Huck
2021-10-15 3:32 ` Pankaj Gupta
2021-10-15 11:13 ` Cornelia Huck [this message]
2021-10-15 11:36 ` Pankaj Gupta
2021-10-19 6:18 ` Taylor Stark
2021-10-19 15:53 ` [virtio-dev] " Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k9iv8v9.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=mst@redhat.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pankaj.gupta@ionos.com \
--cc=stefanha@redhat.com \
--cc=tstark@linux.microsoft.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.