From: Marc Zyngier <maz@kernel.org>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: tglx@linutronix.de, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION (MCP79)
Date: Thu, 07 Oct 2021 16:03:30 +0100 [thread overview]
Message-ID: <874k9sri65.wl-maz@kernel.org> (raw)
In-Reply-To: <CALjTZvbZK3vxexyoEHmh9TPoceckvGV7ACHjOa0rJ9HH=YAyYA@mail.gmail.com>
> > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> > index 4537d1ea14fd..dc7741431bf3 100644
> > --- a/drivers/pci/quirks.c
> > +++ b/drivers/pci/quirks.c
> > @@ -5795,3 +5795,9 @@ static void apex_pci_fixup_class(struct pci_dev *pdev)
> > }
> > DECLARE_PCI_FIXUP_CLASS_HEADER(0x1ac1, 0x089a,
> > PCI_CLASS_NOT_DEFINED, 8, apex_pci_fixup_class);
> > +
> > +static void nvidia_ion_ahci_fixup(struct pci_dev *pdev)
> > +{
> > + pdev->dev_flags |= PCI_MSI_FLAGS_MASKBIT;
Duh. Make that:
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index dc7741431bf3..89c7c99cd1bb 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -5798,6 +5798,6 @@ DECLARE_PCI_FIXUP_CLASS_HEADER(0x1ac1, 0x089a,
static void nvidia_ion_ahci_fixup(struct pci_dev *pdev)
{
- pdev->dev_flags |= PCI_MSI_FLAGS_MASKBIT;
+ pdev->dev_flags |= PCI_DEV_FLAGS_HAS_MSI_MASKING;
}
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x0ab8, nvidia_ion_ahci_fixup);
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-10-07 15:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 8:50 [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION (MCP79) Rui Salvaterra
2021-10-06 11:00 ` Marc Zyngier
2021-10-06 11:06 ` Rui Salvaterra
2021-10-07 8:52 ` Marc Zyngier
2021-10-07 12:03 ` Rui Salvaterra
2021-10-07 12:15 ` Marc Zyngier
2021-10-07 13:11 ` Rui Salvaterra
2021-10-07 14:42 ` Marc Zyngier
2021-10-07 14:50 ` Rui Salvaterra
2021-10-07 15:03 ` Marc Zyngier [this message]
2021-10-07 16:13 ` Rui Salvaterra
2021-10-06 11:44 ` Rui Salvaterra
2021-10-06 11:48 ` Rui Salvaterra
2021-10-11 18:47 ` Josef Johansson
2021-10-11 19:34 ` Josef Johansson
2021-10-12 5:37 ` Josef Johansson
2021-10-12 13:07 ` Jason Andryuk
2021-10-12 13:33 ` Josef Johansson
2021-10-12 15:17 ` Josef Johansson
2021-10-12 11:34 ` Marc Zyngier
2021-10-12 12:33 ` Josef Johansson
2021-10-31 22:51 ` Rui Salvaterra
2021-11-01 11:21 ` Marc Zyngier
2021-11-01 11:36 ` Rui Salvaterra
2021-11-11 8:57 ` [tip: irq/urgent] PCI: Add MSI masking quirk for Nvidia ION AHCI tip-bot2 for Marc Zyngier
[not found] <1374495046.4164334.1635737050153@localhost>
2021-11-01 11:06 ` [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION (MCP79) Rui Salvaterra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k9sri65.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rsalvaterra@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.