From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mDKwp-0003St-2f for mharc-qemu-riscv@gnu.org; Tue, 10 Aug 2021 02:09:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDKwm-0003MD-T2 for qemu-riscv@nongnu.org; Tue, 10 Aug 2021 02:09:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21181) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDKwi-0005aE-Tg for qemu-riscv@nongnu.org; Tue, 10 Aug 2021 02:09:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628575744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OVD/w6eoRz1KhInrrXsfVH6MaoYyT4YyZj4woikZLh8=; b=K5JenG1Vyvje2Es2kPvBtldatyUd7x6zGHN7VH5mn25YiMY+Si54g4VVy+6H5WMFiHm5oR n/t39Rk+Az2nVwCEmyoX6tZcmr3wM3kVe2h64DZQg9giY3iVaFPVi+/JgFgZoxTnzJMuez iM1exVWNUjGOMb4zvDWxeAaSttV3ngA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-181-mRtW4zCmNsCneKNHQsLI3Q-1; Tue, 10 Aug 2021 02:09:03 -0400 X-MC-Unique: mRtW4zCmNsCneKNHQsLI3Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A299A1853028; Tue, 10 Aug 2021 06:08:59 +0000 (UTC) Received: from localhost (unknown [10.39.192.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 879BF10013C1; Tue, 10 Aug 2021 06:08:44 +0000 (UTC) From: Cornelia Huck To: Eduardo Habkost , qemu-devel@nongnu.org Cc: "Daniel P. Berrange" , Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Patrick Venture , Thomas Huth , Keith Busch , Klaus Jensen , "Michael S. Tsirkin" , Halil Pasic , Christian Borntraeger , Richard Henderson , David Hildenbrand , Gerd Hoffmann , Havard Skinnemoen , Tyrone Ting , Alistair Francis , Bin Meng , Palmer Dabbelt , "Edgar E. Iglesias" , Peter Maydell , Andrew Baumann , Philippe =?utf-8?Q?Mathieu?= =?utf-8?Q?-Daud=C3=A9?= , =?utf-8?Q?C=C3=A9dric?= Le Goater , David Gibson , Greg Kurz , Laurent Vivier , qemu-block@nongnu.org, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org Subject: Re: [PATCH for-6.2 06/12] [automated] Split QOM "typedef struct T { ... } T" declarations In-Reply-To: <20210806211127.646908-7-ehabkost@redhat.com> Organization: Red Hat GmbH References: <20210806211127.646908-1-ehabkost@redhat.com> <20210806211127.646908-7-ehabkost@redhat.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 10 Aug 2021 08:08:43 +0200 Message-ID: <874kbxygpg.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.702, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Aug 2021 06:09:09 -0000 On Fri, Aug 06 2021, Eduardo Habkost wrote: > Automatically split struct definition and typedef declaration in > separate declarations, using a codeconverter rule. The rule will > only touch declarations of structs/typedefs actually used by QOM > types. > > This will make automated changes to use OBJECT_DECLARE* macros > easier to implement, because automated removal of typedef lines > will be easier and safer. > > Generated using: > > $ ./scripts/codeconverter/converter.py -i \ > --pattern=3DQOMStructTypedefSplit $(git grep -l '' -- '*.[ch]') > > Signed-off-by: Eduardo Habkost > --- > Cc: "Marc-Andr=C3=A9 Lureau" > Cc: Paolo Bonzini > Cc: Patrick Venture > Cc: Thomas Huth > Cc: Keith Busch > Cc: Klaus Jensen > Cc: "Michael S. Tsirkin" > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Richard Henderson > Cc: David Hildenbrand > Cc: Gerd Hoffmann > Cc: Havard Skinnemoen > Cc: Tyrone Ting > Cc: Alistair Francis > Cc: Bin Meng > Cc: Palmer Dabbelt > Cc: "Edgar E. Iglesias" > Cc: Peter Maydell > Cc: Andrew Baumann > Cc: "Philippe Mathieu-Daud=C3=A9" > Cc: "C=C3=A9dric Le Goater" > Cc: David Gibson > Cc: Greg Kurz > Cc: Laurent Vivier > Cc: qemu-devel@nongnu.org > Cc: qemu-block@nongnu.org > Cc: qemu-s390x@nongnu.org > Cc: qemu-arm@nongnu.org > Cc: qemu-riscv@nongnu.org > Cc: qemu-ppc@nongnu.org > --- > hw/nvme/nvme.h | 10 ++++++---- > hw/usb/hcd-uhci.h | 5 +++-- > hw/usb/u2f.h | 5 +++-- > include/hw/adc/npcm7xx_adc.h | 5 +++-- > include/hw/arm/npcm7xx.h | 10 ++++++---- > include/hw/core/accel-cpu.h | 5 +++-- > include/hw/dma/sifive_pdma.h | 5 +++-- > include/hw/dma/xlnx_csu_dma.h | 5 +++-- > include/hw/gpio/npcm7xx_gpio.h | 5 +++-- > include/hw/i2c/npcm7xx_smbus.h | 5 +++-- > include/hw/mem/npcm7xx_mc.h | 5 +++-- > include/hw/misc/bcm2835_cprman.h | 20 ++++++++++++-------- > include/hw/misc/mchp_pfsoc_dmc.h | 10 ++++++---- > include/hw/misc/mchp_pfsoc_ioscb.h | 5 +++-- > include/hw/misc/mchp_pfsoc_sysreg.h | 5 +++-- > include/hw/misc/npcm7xx_clk.h | 15 +++++++++------ > include/hw/misc/npcm7xx_gcr.h | 5 +++-- > include/hw/misc/npcm7xx_mft.h | 5 +++-- > include/hw/misc/npcm7xx_rng.h | 5 +++-- > include/hw/nvram/npcm7xx_otp.h | 5 +++-- > include/hw/riscv/microchip_pfsoc.h | 10 ++++++---- > include/hw/riscv/sifive_e.h | 5 +++-- > include/hw/sd/cadence_sdhci.h | 5 +++-- > include/qemu/accel.h | 10 ++++++---- > chardev/char-parallel.c | 10 ++++++---- > hw/i2c/i2c_mux_pca954x.c | 5 +++-- > hw/m68k/mcf5206.c | 5 +++-- > hw/misc/sbsa_ec.c | 5 +++-- > hw/s390x/vhost-user-fs-ccw.c | 5 +++-- > tests/qtest/pnv-xscom-test.c | 5 +++-- > 30 files changed, 123 insertions(+), 82 deletions(-) Acked-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:c144:0:0:0:0:0 with SMTP id r65csp1021146lff; Mon, 9 Aug 2021 23:09:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWTKYbnhNT4SqwFywvO9MK/jz8wZZmt1VDww8iOMLcxeF/jJdmJxtcSXxnRpn3LTcN9gMt X-Received: by 2002:a05:6638:539:: with SMTP id j25mr25903504jar.69.1628575777940; Mon, 09 Aug 2021 23:09:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628575777; cv=none; d=google.com; s=arc-20160816; b=QpJcmkVvnZ00lJwpL04EPlcuXS7X265txQn1ATPrcWTOPd62WjGhh2m+53e4WKgB8d OMX8UYzYpjV0zHo/LJpBJ4M4cIVsAjbCcUKFLITgqiuaNqY2/lHDRriiivsfX2aK3Pnw w013aBY0cOP7yqdImpnQf3dqB/wSRHhpcpFlPUZLrxv2L/dcXsMW3zODDdXUAiMvnGCl P2SJXFEYw7hI2v5Ivss4qHNmShQvRZFYKa3czQAbYrpf5Z5FMV+gFoxpVDEWpvPoX+nr /AJ7Bk0JFwBy+zQH8am5aDGRdIk5TfB+07/SSibmOig2VnqP2QsZiif9JD29BPAoXPsY gIRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:user-agent:references:organization :in-reply-to:subject:to:from:dkim-signature; bh=OVD/w6eoRz1KhInrrXsfVH6MaoYyT4YyZj4woikZLh8=; b=pE5TMFQwxSjHjtBIa/ERfLqj2Q3DpD/6fillfx85Ut/1x8Bo2LaqXphQ639RV+KznA eUZdXtRk8NkrnEjvnktrun4uipy2FiYDxRAIeclcnG9cXBp4Nl/ug5I8TGwq98Hydcq3 pxypzlipusix98mdJS3Qu3E2HvRJU/D9qPlYw1Ug+21vhzDNj5gteRd7DgaND9LPEUbC cTlSuGRoNf1XdE09lgGw5o98H0kc6qEHeij0EYLZqnIWR4aUJLYT7zX0XeAFQNhFt4cT rHIuurfcED8Y7K/nZhKgMsTxByWKwHWlbCUnBRAWF6y2zHcdrQw5hsdAmXBMQUFPpH77 lPTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=K5JenG1V; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 10si20775106ilq.145.2021.08.09.23.09.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Aug 2021 23:09:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=K5JenG1V; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:42656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDKxF-0003yX-8V for alex.bennee@linaro.org; Tue, 10 Aug 2021 02:09:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDKwm-0003KW-04 for qemu-arm@nongnu.org; Tue, 10 Aug 2021 02:09:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32213) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDKwi-0005ae-VC for qemu-arm@nongnu.org; Tue, 10 Aug 2021 02:09:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628575744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OVD/w6eoRz1KhInrrXsfVH6MaoYyT4YyZj4woikZLh8=; b=K5JenG1Vyvje2Es2kPvBtldatyUd7x6zGHN7VH5mn25YiMY+Si54g4VVy+6H5WMFiHm5oR n/t39Rk+Az2nVwCEmyoX6tZcmr3wM3kVe2h64DZQg9giY3iVaFPVi+/JgFgZoxTnzJMuez iM1exVWNUjGOMb4zvDWxeAaSttV3ngA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-181-mRtW4zCmNsCneKNHQsLI3Q-1; Tue, 10 Aug 2021 02:09:03 -0400 X-MC-Unique: mRtW4zCmNsCneKNHQsLI3Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A299A1853028; Tue, 10 Aug 2021 06:08:59 +0000 (UTC) Received: from localhost (unknown [10.39.192.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 879BF10013C1; Tue, 10 Aug 2021 06:08:44 +0000 (UTC) From: Cornelia Huck To: Eduardo Habkost , qemu-devel@nongnu.org Subject: Re: [PATCH for-6.2 06/12] [automated] Split QOM "typedef struct T { ... } T" declarations In-Reply-To: <20210806211127.646908-7-ehabkost@redhat.com> Organization: Red Hat GmbH References: <20210806211127.646908-1-ehabkost@redhat.com> <20210806211127.646908-7-ehabkost@redhat.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 10 Aug 2021 08:08:43 +0200 Message-ID: <874kbxygpg.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) DKIMWL_WL_HIGH=-0.702, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Bin Meng , Alistair Francis , Gerd Hoffmann , Klaus Jensen , qemu-block@nongnu.org, qemu-ppc@nongnu.org, David Hildenbrand , Havard Skinnemoen , Halil Pasic , Christian Borntraeger , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Laurent Vivier , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater , Keith Busch , qemu-riscv@nongnu.org, David Gibson , "Daniel P. Berrange" , Thomas Huth , Patrick Venture , Philippe =?utf-8?Q?Mathieu?= =?utf-8?Q?-Daud=C3=A9?= , Andrew Baumann , Tyrone Ting , Palmer Dabbelt , Paolo Bonzini Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: B9uAm8vRQRM8 On Fri, Aug 06 2021, Eduardo Habkost wrote: > Automatically split struct definition and typedef declaration in > separate declarations, using a codeconverter rule. The rule will > only touch declarations of structs/typedefs actually used by QOM > types. > > This will make automated changes to use OBJECT_DECLARE* macros > easier to implement, because automated removal of typedef lines > will be easier and safer. > > Generated using: > > $ ./scripts/codeconverter/converter.py -i \ > --pattern=3DQOMStructTypedefSplit $(git grep -l '' -- '*.[ch]') > > Signed-off-by: Eduardo Habkost > --- > Cc: "Marc-Andr=C3=A9 Lureau" > Cc: Paolo Bonzini > Cc: Patrick Venture > Cc: Thomas Huth > Cc: Keith Busch > Cc: Klaus Jensen > Cc: "Michael S. Tsirkin" > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Richard Henderson > Cc: David Hildenbrand > Cc: Gerd Hoffmann > Cc: Havard Skinnemoen > Cc: Tyrone Ting > Cc: Alistair Francis > Cc: Bin Meng > Cc: Palmer Dabbelt > Cc: "Edgar E. Iglesias" > Cc: Peter Maydell > Cc: Andrew Baumann > Cc: "Philippe Mathieu-Daud=C3=A9" > Cc: "C=C3=A9dric Le Goater" > Cc: David Gibson > Cc: Greg Kurz > Cc: Laurent Vivier > Cc: qemu-devel@nongnu.org > Cc: qemu-block@nongnu.org > Cc: qemu-s390x@nongnu.org > Cc: qemu-arm@nongnu.org > Cc: qemu-riscv@nongnu.org > Cc: qemu-ppc@nongnu.org > --- > hw/nvme/nvme.h | 10 ++++++---- > hw/usb/hcd-uhci.h | 5 +++-- > hw/usb/u2f.h | 5 +++-- > include/hw/adc/npcm7xx_adc.h | 5 +++-- > include/hw/arm/npcm7xx.h | 10 ++++++---- > include/hw/core/accel-cpu.h | 5 +++-- > include/hw/dma/sifive_pdma.h | 5 +++-- > include/hw/dma/xlnx_csu_dma.h | 5 +++-- > include/hw/gpio/npcm7xx_gpio.h | 5 +++-- > include/hw/i2c/npcm7xx_smbus.h | 5 +++-- > include/hw/mem/npcm7xx_mc.h | 5 +++-- > include/hw/misc/bcm2835_cprman.h | 20 ++++++++++++-------- > include/hw/misc/mchp_pfsoc_dmc.h | 10 ++++++---- > include/hw/misc/mchp_pfsoc_ioscb.h | 5 +++-- > include/hw/misc/mchp_pfsoc_sysreg.h | 5 +++-- > include/hw/misc/npcm7xx_clk.h | 15 +++++++++------ > include/hw/misc/npcm7xx_gcr.h | 5 +++-- > include/hw/misc/npcm7xx_mft.h | 5 +++-- > include/hw/misc/npcm7xx_rng.h | 5 +++-- > include/hw/nvram/npcm7xx_otp.h | 5 +++-- > include/hw/riscv/microchip_pfsoc.h | 10 ++++++---- > include/hw/riscv/sifive_e.h | 5 +++-- > include/hw/sd/cadence_sdhci.h | 5 +++-- > include/qemu/accel.h | 10 ++++++---- > chardev/char-parallel.c | 10 ++++++---- > hw/i2c/i2c_mux_pca954x.c | 5 +++-- > hw/m68k/mcf5206.c | 5 +++-- > hw/misc/sbsa_ec.c | 5 +++-- > hw/s390x/vhost-user-fs-ccw.c | 5 +++-- > tests/qtest/pnv-xscom-test.c | 5 +++-- > 30 files changed, 123 insertions(+), 82 deletions(-) Acked-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7729C4338F for ; Tue, 10 Aug 2021 06:10:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 190DC61051 for ; Tue, 10 Aug 2021 06:10:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 190DC61051 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:44004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDKxd-0004qx-4r for qemu-devel@archiver.kernel.org; Tue, 10 Aug 2021 02:10:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDKwm-0003Kc-4y for qemu-devel@nongnu.org; Tue, 10 Aug 2021 02:09:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50558) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDKwi-0005aG-Tg for qemu-devel@nongnu.org; Tue, 10 Aug 2021 02:09:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628575744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OVD/w6eoRz1KhInrrXsfVH6MaoYyT4YyZj4woikZLh8=; b=K5JenG1Vyvje2Es2kPvBtldatyUd7x6zGHN7VH5mn25YiMY+Si54g4VVy+6H5WMFiHm5oR n/t39Rk+Az2nVwCEmyoX6tZcmr3wM3kVe2h64DZQg9giY3iVaFPVi+/JgFgZoxTnzJMuez iM1exVWNUjGOMb4zvDWxeAaSttV3ngA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-181-mRtW4zCmNsCneKNHQsLI3Q-1; Tue, 10 Aug 2021 02:09:03 -0400 X-MC-Unique: mRtW4zCmNsCneKNHQsLI3Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A299A1853028; Tue, 10 Aug 2021 06:08:59 +0000 (UTC) Received: from localhost (unknown [10.39.192.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 879BF10013C1; Tue, 10 Aug 2021 06:08:44 +0000 (UTC) From: Cornelia Huck To: Eduardo Habkost , qemu-devel@nongnu.org Subject: Re: [PATCH for-6.2 06/12] [automated] Split QOM "typedef struct T { ... } T" declarations In-Reply-To: <20210806211127.646908-7-ehabkost@redhat.com> Organization: Red Hat GmbH References: <20210806211127.646908-1-ehabkost@redhat.com> <20210806211127.646908-7-ehabkost@redhat.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 10 Aug 2021 08:08:43 +0200 Message-ID: <874kbxygpg.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.702, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Bin Meng , Alistair Francis , Gerd Hoffmann , Klaus Jensen , "Edgar E. Iglesias" , qemu-block@nongnu.org, qemu-ppc@nongnu.org, David Hildenbrand , Havard Skinnemoen , Halil Pasic , Christian Borntraeger , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Laurent Vivier , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater , Keith Busch , qemu-riscv@nongnu.org, David Gibson , "Daniel P. Berrange" , Thomas Huth , Patrick Venture , Philippe =?utf-8?Q?Mathieu?= =?utf-8?Q?-Daud=C3=A9?= , Andrew Baumann , Tyrone Ting , Palmer Dabbelt , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Aug 06 2021, Eduardo Habkost wrote: > Automatically split struct definition and typedef declaration in > separate declarations, using a codeconverter rule. The rule will > only touch declarations of structs/typedefs actually used by QOM > types. > > This will make automated changes to use OBJECT_DECLARE* macros > easier to implement, because automated removal of typedef lines > will be easier and safer. > > Generated using: > > $ ./scripts/codeconverter/converter.py -i \ > --pattern=3DQOMStructTypedefSplit $(git grep -l '' -- '*.[ch]') > > Signed-off-by: Eduardo Habkost > --- > Cc: "Marc-Andr=C3=A9 Lureau" > Cc: Paolo Bonzini > Cc: Patrick Venture > Cc: Thomas Huth > Cc: Keith Busch > Cc: Klaus Jensen > Cc: "Michael S. Tsirkin" > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Richard Henderson > Cc: David Hildenbrand > Cc: Gerd Hoffmann > Cc: Havard Skinnemoen > Cc: Tyrone Ting > Cc: Alistair Francis > Cc: Bin Meng > Cc: Palmer Dabbelt > Cc: "Edgar E. Iglesias" > Cc: Peter Maydell > Cc: Andrew Baumann > Cc: "Philippe Mathieu-Daud=C3=A9" > Cc: "C=C3=A9dric Le Goater" > Cc: David Gibson > Cc: Greg Kurz > Cc: Laurent Vivier > Cc: qemu-devel@nongnu.org > Cc: qemu-block@nongnu.org > Cc: qemu-s390x@nongnu.org > Cc: qemu-arm@nongnu.org > Cc: qemu-riscv@nongnu.org > Cc: qemu-ppc@nongnu.org > --- > hw/nvme/nvme.h | 10 ++++++---- > hw/usb/hcd-uhci.h | 5 +++-- > hw/usb/u2f.h | 5 +++-- > include/hw/adc/npcm7xx_adc.h | 5 +++-- > include/hw/arm/npcm7xx.h | 10 ++++++---- > include/hw/core/accel-cpu.h | 5 +++-- > include/hw/dma/sifive_pdma.h | 5 +++-- > include/hw/dma/xlnx_csu_dma.h | 5 +++-- > include/hw/gpio/npcm7xx_gpio.h | 5 +++-- > include/hw/i2c/npcm7xx_smbus.h | 5 +++-- > include/hw/mem/npcm7xx_mc.h | 5 +++-- > include/hw/misc/bcm2835_cprman.h | 20 ++++++++++++-------- > include/hw/misc/mchp_pfsoc_dmc.h | 10 ++++++---- > include/hw/misc/mchp_pfsoc_ioscb.h | 5 +++-- > include/hw/misc/mchp_pfsoc_sysreg.h | 5 +++-- > include/hw/misc/npcm7xx_clk.h | 15 +++++++++------ > include/hw/misc/npcm7xx_gcr.h | 5 +++-- > include/hw/misc/npcm7xx_mft.h | 5 +++-- > include/hw/misc/npcm7xx_rng.h | 5 +++-- > include/hw/nvram/npcm7xx_otp.h | 5 +++-- > include/hw/riscv/microchip_pfsoc.h | 10 ++++++---- > include/hw/riscv/sifive_e.h | 5 +++-- > include/hw/sd/cadence_sdhci.h | 5 +++-- > include/qemu/accel.h | 10 ++++++---- > chardev/char-parallel.c | 10 ++++++---- > hw/i2c/i2c_mux_pca954x.c | 5 +++-- > hw/m68k/mcf5206.c | 5 +++-- > hw/misc/sbsa_ec.c | 5 +++-- > hw/s390x/vhost-user-fs-ccw.c | 5 +++-- > tests/qtest/pnv-xscom-test.c | 5 +++-- > 30 files changed, 123 insertions(+), 82 deletions(-) Acked-by: Cornelia Huck