From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Dave Huseby" <dwh@linuxprogrammer.org>,
"Lars Schneider" <larsxschneider@gmail.com>,
"Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Subject: Re: [PATCH 1/3] SubmittingPatches: move discussion of Signed-off-by above "send"
Date: Mon, 07 Jun 2021 13:02:08 +0200 [thread overview]
Message-ID: <874kea543g.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <609ba00a1c03b_6e87020886@natae.notmuch>
On Wed, May 12 2021, Felipe Contreras wrote:
> Ævar Arnfjörð Bjarmason wrote:
>> +=== Certify your work by adding your `Signed-off-by` trailer
>> +
>> +To improve tracking of who did what, we ask you to certify that you
>> +wrote the patch or have the right to pass it on under the same license
>> +as ours, by "signing off" your patch. Without sign-off, we cannot
>> +accept your patches.
>
> This may be me, but I would expect the phrase to make sense without the
> comma:
>
>> we ask you to certify that you wrote the patch ... by "signing off"
>> your patch.
>
> Whatever you put inside the ... is additional information that doesn't
> negate the origina sentence.
>
> So:
>
>> To improve tracking of who did what, we ask you to certify that you
>> wrote the patch--or have the right to pass it on under the same
>> license as ours--by "signing off" your patch.
>
> Cheers.
I think these are good notes, but in this commit I'm merely moving
existing lines around in the file so that 2/3 and 3/3 make sense, so
I've left any change to the existing text out of v2 of this series.
I welcome an effort to improve the existing wording, but I think it's
better if you submit your own patch-on-top for that, I'd rather not get
bogged down in that any more than I already am :)
next prev parent reply other threads:[~2021-06-07 11:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 8:44 [PATCH 0/3] SubmittingPatches: a few unrelated minor fixes Ævar Arnfjörð Bjarmason
2021-05-12 8:45 ` [PATCH 1/3] SubmittingPatches: move discussion of Signed-off-by above "send" Ævar Arnfjörð Bjarmason
2021-05-12 9:29 ` Felipe Contreras
2021-06-07 11:02 ` Ævar Arnfjörð Bjarmason [this message]
2021-06-07 16:16 ` Felipe Contreras
2021-05-12 8:45 ` [PATCH 2/3] SubmittingPatches: replace discussion of Travis with GitHub Actions Ævar Arnfjörð Bjarmason
2021-05-12 12:24 ` Đoàn Trần Công Danh
2021-05-12 22:40 ` Junio C Hamano
2021-05-12 8:45 ` [PATCH 3/3] SubmittingPatches: remove pine-specific hints from MUA hints Ævar Arnfjörð Bjarmason
2021-05-12 23:51 ` Dave Huseby
2021-05-13 6:38 ` Felipe Contreras
2021-05-13 14:45 ` Dave Huseby
2021-05-13 20:08 ` Felipe Contreras
2021-05-17 19:05 ` Dave Huseby
2021-05-13 7:50 ` Ævar Arnfjörð Bjarmason
2021-05-13 14:42 ` Dave Huseby
2021-06-07 11:03 ` [PATCH v2 0/3] SubmittingPatches: a few unrelated minor fixes Ævar Arnfjörð Bjarmason
2021-06-07 11:03 ` [PATCH v2 1/3] SubmittingPatches: move discussion of Signed-off-by above "send" Ævar Arnfjörð Bjarmason
2021-06-07 15:58 ` Đoàn Trần Công Danh
2021-06-07 11:03 ` [PATCH v2 2/3] SubmittingPatches: replace discussion of Travis with GitHub Actions Ævar Arnfjörð Bjarmason
2021-06-07 17:25 ` SZEDER Gábor
2021-06-07 11:03 ` [PATCH v2 3/3] SubmittingPatches: remove pine-specific hints from MUA hints Ævar Arnfjörð Bjarmason
2021-06-07 21:49 ` Johannes Schindelin
2021-06-08 3:50 ` [PATCH v2 0/3] SubmittingPatches: a few unrelated minor fixes Junio C Hamano
2021-07-22 12:11 ` [PATCH v3 0/2] SubmittingPatches: talk about GitHub CI, not Travis + move-only Ævar Arnfjörð Bjarmason
2021-07-22 12:11 ` [PATCH v3 1/2] SubmittingPatches: move discussion of Signed-off-by above "send" Ævar Arnfjörð Bjarmason
2021-07-23 6:36 ` Bagas Sanjaya
2021-07-22 12:11 ` [PATCH v3 2/2] SubmittingPatches: replace discussion of Travis with GitHub Actions Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kea543g.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=dwh@linuxprogrammer.org \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.