From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF4AFC433B4 for ; Sat, 8 May 2021 09:15:45 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 10AA861377 for ; Sat, 8 May 2021 09:15:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10AA861377 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9343B4B128; Sat, 8 May 2021 05:15:44 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Hs2sE2ydJAIH; Sat, 8 May 2021 05:15:43 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 77C0F4B133; Sat, 8 May 2021 05:15:43 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7A4F64B122 for ; Sat, 8 May 2021 05:15:42 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ie3st88yqhJr for ; Sat, 8 May 2021 05:15:41 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 1B6724B10B for ; Sat, 8 May 2021 05:15:41 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D14EE6135D; Sat, 8 May 2021 09:15:39 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lfJ3h-0005Lz-HK; Sat, 08 May 2021 10:15:37 +0100 Date: Sat, 08 May 2021 10:15:36 +0100 Message-ID: <874kfdvb5z.wl-maz@kernel.org> From: Marc Zyngier To: Jason Wang Subject: Re: Question on guest enable msi fail when using GICv4/4.1 In-Reply-To: <373c70d3-eda3-8e84-d138-2f90d4e55217@redhat.com> References: <3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com> <87k0oaq5jf.wl-maz@kernel.org> <878s4qq00u.wl-maz@kernel.org> <874kfepht4.wl-maz@kernel.org> <373c70d3-eda3-8e84-d138-2f90d4e55217@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: jasowang@redhat.com, lingshan.zhu@intel.com, zhangshaokun@hisilicon.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org, alex.williamson@redhat.com, cohuck@redhat.com, tangnianyao@huawei.com, bhelgaas@google.com, eric.auger@redhat.com, mst@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , linux-pci@vger.kernel.org, Cornelia Huck , Shaokun Zhang , Alex Williamson , Bjorn Helgaas , Zhu Lingshan , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gU2F0LCAwOCBNYXkgMjAyMSAwMjo1MTozOSArMDEwMCwKSmFzb24gV2FuZyA8amFzb3dhbmdA cmVkaGF0LmNvbT4gd3JvdGU6Cj4gCj4gCj4g5ZyoIDIwMjEvNS84IOS4iuWNiDE6MzYsIE1hcmMg WnluZ2llciDlhpnpgZM6CgpbLi4uXQoKPiA+IEFkZGluZyBaaHUsIEphc29uLCBNU1QgdG8gdGhl IHBhcnR5LiBJdCBhbGwgc2VlbXMgdG8gYmUgY2F1c2VkIGJ5IHRoaXMKPiA+IGNvbW1pdDoKPiA+ IAo+ID4gY29tbWl0IGE5NzlhNmFhMDA5ZjNjOTk2ODk0MzJlMGNkYjU0MDJhNDQ2M2ZiODgKPiA+ IEF1dGhvcjogWmh1IExpbmdzaGFuIDxsaW5nc2hhbi56aHVAaW50ZWwuY29tPgo+ID4gRGF0ZTog ICBGcmkgSnVsIDMxIDE0OjU1OjMzIDIwMjAgKzA4MDAKPiA+IAo+ID4gICAgICBpcnFieXBhc3M6 IGRvIG5vdCBzdGFydCBjb25zL3Byb2Qgd2hlbiBmYWlsZWQgY29ubmVjdAo+ID4gICAgICAgICAg IElmIGZhaWxlZCB0byBjb25uZWN0LCB0aGVyZSBpcyBubyBuZWVkIHRvIHN0YXJ0IGNvbnN1bWVy Cj4gPiBub3IKPiA+ICAgICAgcHJvZHVjZXIuCj4gPiAgICAgICAgICAgU2lnbmVkLW9mZi1ieTog Wmh1IExpbmdzaGFuIDxsaW5nc2hhbi56aHVAaW50ZWwuY29tPgo+ID4gICAgICBTdWdnZXN0ZWQt Ynk6IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+Cj4gPiAgICAgIExpbms6IGh0dHBz Oi8vbG9yZS5rZXJuZWwub3JnL3IvMjAyMDA3MzEwNjU1MzMuNDE0NC03LWxpbmdzaGFuLnpodUBp bnRlbC5jb20KPiA+ICAgICAgU2lnbmVkLW9mZi1ieTogTWljaGFlbCBTLiBUc2lya2luIDxtc3RA cmVkaGF0LmNvbT4KPiA+IAo+ID4gCj4gPiBaaHUsIEknZCByZWFsbHkgbGlrZSB0byB1bmRlcnN0 YW5kIHdoeSB5b3UgdGhpbmsgaXQgaXMgT0sgbm90IHRvCj4gPiByZXN0YXJ0IGNvbnN1bWVyIGFu ZCBwcm9kdWNlcnMgd2hlbiBhIGNvbm5lY3Rpb24gaGFzIGZhaWxlZCB0byBiZQo+ID4gZXN0YWJs aXNoZWQgYmV0d2VlbiB0aGUgdHdvPwo+IAo+IAo+IE15IGJhZCwgSSBkaWRuJ3QgY2hlY2sgQVJN IGNvZGUgYnV0IGl0J3Mgbm90IGVhc3kgdG8gaW5mZXIgdGhhdCB0aGUKPiBjb25zLT5zdGFydC9z dG9wIGlzIG5vdCBhIHBlciBjb25zdW1lciBzcGVjaWZpYyBvcGVyYXRpb24gYnV0IGEgZ2xvYmFs Cj4gb25lIGxpa2UgVk0gaGFsdGluZy9yZXN1bWluZy4KCkkgZG9uJ3QgZGlzYWdyZWUgdGhhdCBp dCBpcyBhIGJpdCBvZiBhbiBvZGQgYmVoYXZpb3VyLCBhbmQgbWF5YmUgd2UKY2FuIGV2ZW50dWFs bHkgcmVsYXggdGhpcy4gSG93ZXZlciwgbXkgcnVsZSBvZiB0aHVtYiBmb3IgZXJyb3IKaGFuZGxp bmcgaXMgdG8gdHJ5IGFuZCBwdXQgdGhpbmdzIGJhY2sgaW4gdGhlIHN0YXRlIHlvdSBmb3VuZCB0 aGVtLgoKSXQgaXMgYWxzbyB1bmZvcnR1bmF0ZSB0aGF0IHRoaXMgc2FtZSBjb21taXQgaW50cm9k dWNlcyBhbiBpbnRlcmVzdGluZwpidWcgYnkgdW5jb25kaXRpb25hbGx5IGNhbGxpbmcgZGVsX3By b2R1Y2VyKCksIGV2ZW4gaWYgdGhlCnByb2R1Y2VyL2NvbnN1bWVyIGNvbm5lY3Rpb24gaGFzIHN1 Y2NlZWRlZC4gSSBndWVzcyBpdCBpcyBhIGdvb2QgdGhpbmcKdGhhdCBub2JvZHkgc2VlbSB0byBp bXBsZW1lbnQgYW55IG9mIHRoZSBwcm9kdWNlciBjYWxsYmFja3MuCgo+ID4gSW4gdGhlIGNhc2Ug b2YgS1ZNL2FybTY0LCB0aGlzIHJlc3VsdHMgaW4gdGhlIGd1ZXN0IGJlaW5nIGZvcmV2ZXIKPiA+ IHN1c3BlbmRlZCBhbmQgbmV2ZXIgcmVzdW1lZC4gVGhhdCdzIG9idmlvdXNseSBub3QgYW4gYWNj ZXB0YWJsZQo+ID4gcmVncmVzc2lvbiwgYXMgdGhlcmUgaXMgYSBudW1iZXIgb2YgYmVuaWduIHJl YXNvbnMgZm9yIGEgY29ubmVjdCB0bwo+ID4gZmFpbC4KPiAKPiAKPiBMZXQncyByZXZlcnQgdGhp cyBjb21taXQuCgpUaGFua3MsCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBu b3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNz LmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xpc3Rp bmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4751BC433ED for ; Sat, 8 May 2021 09:15:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13DFC61448 for ; Sat, 8 May 2021 09:15:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229701AbhEHJQl convert rfc822-to-8bit (ORCPT ); Sat, 8 May 2021 05:16:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:37364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbhEHJQk (ORCPT ); Sat, 8 May 2021 05:16:40 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D14EE6135D; Sat, 8 May 2021 09:15:39 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lfJ3h-0005Lz-HK; Sat, 08 May 2021 10:15:37 +0100 Date: Sat, 08 May 2021 10:15:36 +0100 Message-ID: <874kfdvb5z.wl-maz@kernel.org> From: Marc Zyngier To: Jason Wang Cc: Zhu Lingshan , Shaokun Zhang , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org, Alex Williamson , Cornelia Huck , Nianyao Tang , Bjorn Helgaas , Eric Auger , "Michael S. Tsirkin" Subject: Re: Question on guest enable msi fail when using GICv4/4.1 In-Reply-To: <373c70d3-eda3-8e84-d138-2f90d4e55217@redhat.com> References: <3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com> <87k0oaq5jf.wl-maz@kernel.org> <878s4qq00u.wl-maz@kernel.org> <874kfepht4.wl-maz@kernel.org> <373c70d3-eda3-8e84-d138-2f90d4e55217@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: jasowang@redhat.com, lingshan.zhu@intel.com, zhangshaokun@hisilicon.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org, alex.williamson@redhat.com, cohuck@redhat.com, tangnianyao@huawei.com, bhelgaas@google.com, eric.auger@redhat.com, mst@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sat, 08 May 2021 02:51:39 +0100, Jason Wang wrote: > > > 在 2021/5/8 上午1:36, Marc Zyngier 写道: [...] > > Adding Zhu, Jason, MST to the party. It all seems to be caused by this > > commit: > > > > commit a979a6aa009f3c99689432e0cdb5402a4463fb88 > > Author: Zhu Lingshan > > Date: Fri Jul 31 14:55:33 2020 +0800 > > > > irqbypass: do not start cons/prod when failed connect > > If failed to connect, there is no need to start consumer > > nor > > producer. > > Signed-off-by: Zhu Lingshan > > Suggested-by: Jason Wang > > Link: https://lore.kernel.org/r/20200731065533.4144-7-lingshan.zhu@intel.com > > Signed-off-by: Michael S. Tsirkin > > > > > > Zhu, I'd really like to understand why you think it is OK not to > > restart consumer and producers when a connection has failed to be > > established between the two? > > > My bad, I didn't check ARM code but it's not easy to infer that the > cons->start/stop is not a per consumer specific operation but a global > one like VM halting/resuming. I don't disagree that it is a bit of an odd behaviour, and maybe we can eventually relax this. However, my rule of thumb for error handling is to try and put things back in the state you found them. It is also unfortunate that this same commit introduces an interesting bug by unconditionally calling del_producer(), even if the producer/consumer connection has succeeded. I guess it is a good thing that nobody seem to implement any of the producer callbacks. > > In the case of KVM/arm64, this results in the guest being forever > > suspended and never resumed. That's obviously not an acceptable > > regression, as there is a number of benign reasons for a connect to > > fail. > > > Let's revert this commit. Thanks, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBE22C433ED for ; Sat, 8 May 2021 09:17:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 721876135D for ; Sat, 8 May 2021 09:17:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 721876135D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mRserGqUug9TQNZws2K/+63Z6yi1xAuJv/IzZYU7fqI=; b=p8+jmqE0NEAcofiLQBs2wDO4+ Pep+k/psFDW538AocYSE4mZJOC+IBpsnlJ137LWnMNA4gqhB9Ho5JqN1UkRZ5yt7xlNI8iGwH7w9W 0ux9v45/TnEDrGdFsveWX6i1qc8WyzXzveK/SMgDN7cgNsucQ+gSM8gP6I1/j2RqA3BM/4oIVnnkm ev2ERn9wz9lV7dMc41HkSN0jByfSSgrueyivadDLnjy8jZiEPRrMoBzbyKY/GM2EMlFhcdv9hrKwY LrKundkF4v64XZMXJY+XcBiI1oKpJvZiXn6yiI2PLl6nkQpGgodbIhjnb77TafBWCIfplWMQLuR/A AXd6Vqg2g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lfJ3y-009D7v-Tc; Sat, 08 May 2021 09:15:55 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfJ3n-009D7C-0h for linux-arm-kernel@desiato.infradead.org; Sat, 08 May 2021 09:15:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Subject:Cc:To:From: Message-ID:Date:Sender:Reply-To:Content-ID:Content-Description; bh=Iqwuq/9Knpow+ji38rh7oEz4Qrfx9jnBK5Q0AYC/u9o=; b=ngdthfGdfeT5dmsJ3tpeiX94Ub zwZgFvW142t5aq9Su52swCQIDth+ePKdURNPM1ihenJ+UMXvca5IkYWTn8NiqjxJmLXS7LCoVPejY hLs0LBDYNUYYKuyCU/iTtbQY1HLH3z63T+M4/forXbKWUgvp2PG8kdt60FzO5BhIa+uNUirjNlRk0 GendzRruzgGYtFtqjd0ovqRf6A6m4wdDnC2KYP1mgTDff6g08L/aCEFrzvwTgDpH6eYTD6z7jQmAv Gy2StHkkKiez/TmoWggdoZBe0v9gSRsqgFe2C3SN1j/6Ul4sYRfv743oCB/PLaMv1/jh7LaF3QHRb U0SzOKeg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfJ3k-007SMA-9S for linux-arm-kernel@lists.infradead.org; Sat, 08 May 2021 09:15:41 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D14EE6135D; Sat, 8 May 2021 09:15:39 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lfJ3h-0005Lz-HK; Sat, 08 May 2021 10:15:37 +0100 Date: Sat, 08 May 2021 10:15:36 +0100 Message-ID: <874kfdvb5z.wl-maz@kernel.org> From: Marc Zyngier To: Jason Wang Cc: Zhu Lingshan , Shaokun Zhang , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org, Alex Williamson , Cornelia Huck , Nianyao Tang , Bjorn Helgaas , Eric Auger , "Michael S. Tsirkin" Subject: Re: Question on guest enable msi fail when using GICv4/4.1 In-Reply-To: <373c70d3-eda3-8e84-d138-2f90d4e55217@redhat.com> References: <3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com> <87k0oaq5jf.wl-maz@kernel.org> <878s4qq00u.wl-maz@kernel.org> <874kfepht4.wl-maz@kernel.org> <373c70d3-eda3-8e84-d138-2f90d4e55217@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: jasowang@redhat.com, lingshan.zhu@intel.com, zhangshaokun@hisilicon.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org, alex.williamson@redhat.com, cohuck@redhat.com, tangnianyao@huawei.com, bhelgaas@google.com, eric.auger@redhat.com, mst@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210508_021540_396581_F00F6542 X-CRM114-Status: GOOD ( 24.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCAwOCBNYXkgMjAyMSAwMjo1MTozOSArMDEwMCwKSmFzb24gV2FuZyA8amFzb3dhbmdA cmVkaGF0LmNvbT4gd3JvdGU6Cj4gCj4gCj4g5ZyoIDIwMjEvNS84IOS4iuWNiDE6MzYsIE1hcmMg WnluZ2llciDlhpnpgZM6CgpbLi4uXQoKPiA+IEFkZGluZyBaaHUsIEphc29uLCBNU1QgdG8gdGhl IHBhcnR5LiBJdCBhbGwgc2VlbXMgdG8gYmUgY2F1c2VkIGJ5IHRoaXMKPiA+IGNvbW1pdDoKPiA+ IAo+ID4gY29tbWl0IGE5NzlhNmFhMDA5ZjNjOTk2ODk0MzJlMGNkYjU0MDJhNDQ2M2ZiODgKPiA+ IEF1dGhvcjogWmh1IExpbmdzaGFuIDxsaW5nc2hhbi56aHVAaW50ZWwuY29tPgo+ID4gRGF0ZTog ICBGcmkgSnVsIDMxIDE0OjU1OjMzIDIwMjAgKzA4MDAKPiA+IAo+ID4gICAgICBpcnFieXBhc3M6 IGRvIG5vdCBzdGFydCBjb25zL3Byb2Qgd2hlbiBmYWlsZWQgY29ubmVjdAo+ID4gICAgICAgICAg IElmIGZhaWxlZCB0byBjb25uZWN0LCB0aGVyZSBpcyBubyBuZWVkIHRvIHN0YXJ0IGNvbnN1bWVy Cj4gPiBub3IKPiA+ICAgICAgcHJvZHVjZXIuCj4gPiAgICAgICAgICAgU2lnbmVkLW9mZi1ieTog Wmh1IExpbmdzaGFuIDxsaW5nc2hhbi56aHVAaW50ZWwuY29tPgo+ID4gICAgICBTdWdnZXN0ZWQt Ynk6IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+Cj4gPiAgICAgIExpbms6IGh0dHBz Oi8vbG9yZS5rZXJuZWwub3JnL3IvMjAyMDA3MzEwNjU1MzMuNDE0NC03LWxpbmdzaGFuLnpodUBp bnRlbC5jb20KPiA+ICAgICAgU2lnbmVkLW9mZi1ieTogTWljaGFlbCBTLiBUc2lya2luIDxtc3RA cmVkaGF0LmNvbT4KPiA+IAo+ID4gCj4gPiBaaHUsIEknZCByZWFsbHkgbGlrZSB0byB1bmRlcnN0 YW5kIHdoeSB5b3UgdGhpbmsgaXQgaXMgT0sgbm90IHRvCj4gPiByZXN0YXJ0IGNvbnN1bWVyIGFu ZCBwcm9kdWNlcnMgd2hlbiBhIGNvbm5lY3Rpb24gaGFzIGZhaWxlZCB0byBiZQo+ID4gZXN0YWJs aXNoZWQgYmV0d2VlbiB0aGUgdHdvPwo+IAo+IAo+IE15IGJhZCwgSSBkaWRuJ3QgY2hlY2sgQVJN IGNvZGUgYnV0IGl0J3Mgbm90IGVhc3kgdG8gaW5mZXIgdGhhdCB0aGUKPiBjb25zLT5zdGFydC9z dG9wIGlzIG5vdCBhIHBlciBjb25zdW1lciBzcGVjaWZpYyBvcGVyYXRpb24gYnV0IGEgZ2xvYmFs Cj4gb25lIGxpa2UgVk0gaGFsdGluZy9yZXN1bWluZy4KCkkgZG9uJ3QgZGlzYWdyZWUgdGhhdCBp dCBpcyBhIGJpdCBvZiBhbiBvZGQgYmVoYXZpb3VyLCBhbmQgbWF5YmUgd2UKY2FuIGV2ZW50dWFs bHkgcmVsYXggdGhpcy4gSG93ZXZlciwgbXkgcnVsZSBvZiB0aHVtYiBmb3IgZXJyb3IKaGFuZGxp bmcgaXMgdG8gdHJ5IGFuZCBwdXQgdGhpbmdzIGJhY2sgaW4gdGhlIHN0YXRlIHlvdSBmb3VuZCB0 aGVtLgoKSXQgaXMgYWxzbyB1bmZvcnR1bmF0ZSB0aGF0IHRoaXMgc2FtZSBjb21taXQgaW50cm9k dWNlcyBhbiBpbnRlcmVzdGluZwpidWcgYnkgdW5jb25kaXRpb25hbGx5IGNhbGxpbmcgZGVsX3By b2R1Y2VyKCksIGV2ZW4gaWYgdGhlCnByb2R1Y2VyL2NvbnN1bWVyIGNvbm5lY3Rpb24gaGFzIHN1 Y2NlZWRlZC4gSSBndWVzcyBpdCBpcyBhIGdvb2QgdGhpbmcKdGhhdCBub2JvZHkgc2VlbSB0byBp bXBsZW1lbnQgYW55IG9mIHRoZSBwcm9kdWNlciBjYWxsYmFja3MuCgo+ID4gSW4gdGhlIGNhc2Ug b2YgS1ZNL2FybTY0LCB0aGlzIHJlc3VsdHMgaW4gdGhlIGd1ZXN0IGJlaW5nIGZvcmV2ZXIKPiA+ IHN1c3BlbmRlZCBhbmQgbmV2ZXIgcmVzdW1lZC4gVGhhdCdzIG9idmlvdXNseSBub3QgYW4gYWNj ZXB0YWJsZQo+ID4gcmVncmVzc2lvbiwgYXMgdGhlcmUgaXMgYSBudW1iZXIgb2YgYmVuaWduIHJl YXNvbnMgZm9yIGEgY29ubmVjdCB0bwo+ID4gZmFpbC4KPiAKPiAKPiBMZXQncyByZXZlcnQgdGhp cyBjb21taXQuCgpUaGFua3MsCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBu b3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==