From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B8BC43460 for ; Tue, 27 Apr 2021 08:03:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EEA161289 for ; Tue, 27 Apr 2021 08:03:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EEA161289 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BEC306E90F; Tue, 27 Apr 2021 08:03:43 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2E896E90F; Tue, 27 Apr 2021 08:03:41 +0000 (UTC) IronPort-SDR: /tesrDXl/0bIqfNIr8lB9eEiXl0JDZM1hS9fULi76Kuv/XKRAsUIwqGGRZZGAaW8LdB9zn7+BL MzzJs9K6YSWg== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="176584861" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="176584861" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 01:03:40 -0700 IronPort-SDR: uLSXj0EdQtmdIW8C+zJUYeRb5TCTvPoVqeHWDsN4Sc0vwYGNFSJgVpsJw2m4Agpf5QiIWRG69j +BwbPNqlLoeg== X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="429720252" Received: from aalbarra-mobl.ger.corp.intel.com (HELO localhost) ([10.249.41.45]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 01:03:36 -0700 From: Jani Nikula To: Randy Dunlap , linux-kernel@vger.kernel.org In-Reply-To: <20210426183516.18957-1-rdunlap@infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210426183516.18957-1-rdunlap@infradead.org> Date: Tue, 27 Apr 2021 11:03:34 +0300 Message-ID: <874kfs5f3d.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm: i915: fix build when ACPI is disabled and BACKLIGHT=m X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Randy Dunlap , Daniel Vetter , Damien Lespiau , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gTW9uLCAyNiBBcHIgMjAyMSwgUmFuZHkgRHVubGFwIDxyZHVubGFwQGluZnJhZGVhZC5vcmc+ IHdyb3RlOgo+IFdoZW4gQ09ORklHX0RSTV9JOTE1PXksIENPTkZJR19BQ1BJIGlzIG5vdCBzZXQs IGFuZAo+IENPTkZJR19CQUNLTElHSFRfQ0xBU1NfREVWSUNFPW0sIG5vdCBkdWUgdG8gSTkxNSBj b25maWcsCj4gdGhlcmUgYXJlIGJ1aWxkIGVycm9ycyB0cnlpbmcgdG8gcmVmZXJlbmNlIGJhY2ts aWdodF9kZXZpY2Vfe3VufXJlZ2lzdGVyKCkuCj4KPiBDaGFuZ2luZyB0aGUgdXNlIG9mIElTX0VO QUJMRUQoKSB0byBJU19SRUFDSEFCTEUoKSBpbiBpbnRlbF9wYW5lbC5bY2hdCj4gZml4ZXMgdGhp cy4KCkkgZmVlbCBsaWtlIGEgYnJva2VuIHJlY29yZC4uLgoKQ09ORklHX0RSTV9JOTE1PXkgYW5k IENPTkZJR19CQUNLTElHSFRfQ0xBU1NfREVWSUNFPW0gaXMgYW4gaW52YWxpZApjb25maWd1cmF0 aW9uLiBUaGUgcGF0Y2ggYXQgaGFuZCBqdXN0IHNpbGVudGx5IGhpZGVzIHRoZSBwcm9ibGVtLAps ZWF2aW5nIHlvdSB3aXRob3V0IGJhY2tsaWdodC4KCmk5MTUgc2hvdWxkICpkZXBlbmQqIG9uIGJh Y2tsaWdodCwgbm90IHNlbGVjdCBpdC4gSXQgd291bGQgZXhwcmVzcyB0aGUKZGVwZW5kZW5jeSB3 aXRob3V0IGNoYW5jZXMgZm9yIGludmFsaWQgY29uZmlndXJhdGlvbi4KCkhvd2V2ZXIsIGk5MTUg YWxvbmUgY2FuJ3QgZGVwZW5kIG9uIGJhY2tsaWdodCwgYWxsIHVzZXJzIG9mIGJhY2tsaWdodApz aG91bGQgZGVwZW5kIG9uIGJhY2tsaWdodCwgbm90IHNlbGVjdCBpdC4gT3RoZXJ3aXNlLCB5b3Ug ZW5kIHVwIHdpdGgKb3RoZXIgY29uZmlndXJhdGlvbiBwcm9ibGVtcywgY2lyY3VsYXIgZGVwZW5k ZW5jaWVzIGFuZAp3aGF0bm90LiBFdmVyeW9uZSBzaG91bGQgY2hhbmdlLiBTZWUgYWxzbyAoKikg d2h5IHNlbGVjdCBpcyBub3QgYSBnb29kCmlkZWEgaGVyZS4KCkkndmUgc2VudCBwYXRjaGVzIHRv IHRoaXMgZWZmZWN0IGJlZm9yZSwgZ290IHJlamVjdGVkLCBhbmQgdGhlIHNhbWUKdGhpbmcgZ2V0 cyByZXBlYXRlZCBhZCBpbmZpbml0dW0uCgpBY2NlcHRpbmcgdGhpcyBwYXRjaCB3b3VsZCBzdG9w IHRoZSBpbmZsb3cgb2YgdGhlc2UgcmVwb3J0cyBhbmQgc2ltaWxhcgpwYXRjaGVzLCBidXQgaXQg ZG9lcyBub3QgZml4IHRoZSByb290IGNhdXNlLiBJdCBqdXN0IHN3ZWVwcyB0aGUgcHJvYmxlbQp1 bmRlciB0aGUgcnVnLgoKCkJSLApKYW5pLgoKKCopIERvY3VtZW50YXRpb24va2J1aWxkL2tjb25m aWctbGFuZ3VhZ2UucnN0OgoKCXNlbGVjdCBzaG91bGQgYmUgdXNlZCB3aXRoIGNhcmUuIHNlbGVj dCB3aWxsIGZvcmNlCglhIHN5bWJvbCB0byBhIHZhbHVlIHdpdGhvdXQgdmlzaXRpbmcgdGhlIGRl cGVuZGVuY2llcy4KCUJ5IGFidXNpbmcgc2VsZWN0IHlvdSBhcmUgYWJsZSB0byBzZWxlY3QgYSBz eW1ib2wgRk9PIGV2ZW4KCWlmIEZPTyBkZXBlbmRzIG9uIEJBUiB0aGF0IGlzIG5vdCBzZXQuCglJ biBnZW5lcmFsIHVzZSBzZWxlY3Qgb25seSBmb3Igbm9uLXZpc2libGUgc3ltYm9scwoJKG5vIHBy b21wdHMgYW55d2hlcmUpIGFuZCBmb3Igc3ltYm9scyB3aXRoIG5vIGRlcGVuZGVuY2llcy4KCVRo YXQgd2lsbCBsaW1pdCB0aGUgdXNlZnVsbmVzcyBidXQgb24gdGhlIG90aGVyIGhhbmQgYXZvaWQK CXRoZSBpbGxlZ2FsIGNvbmZpZ3VyYXRpb25zIGFsbCBvdmVyLgoKCj4KPiBsZDogZHJpdmVycy9n cHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9wYW5lbC5vOiBpbiBmdW5jdGlvbiBgaW50ZWxfYmFj a2xpZ2h0X2RldmljZV9yZWdpc3Rlcic6Cj4gaW50ZWxfcGFuZWwuYzooLnRleHQrMHgyZWMxKTog dW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgYmFja2xpZ2h0X2RldmljZV9yZWdpc3RlcicKPiBsZDog ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9wYW5lbC5vOiBpbiBmdW5jdGlvbiBg aW50ZWxfYmFja2xpZ2h0X2RldmljZV91bnJlZ2lzdGVyJzoKPiBpbnRlbF9wYW5lbC5jOigudGV4 dCsweDJmOTMpOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBiYWNrbGlnaHRfZGV2aWNlX3VucmVn aXN0ZXInCj4KPiBsZDogZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9wYW5lbC5v OiBpbiBmdW5jdGlvbiBgaW50ZWxfYmFja2xpZ2h0X2RldmljZV9yZWdpc3Rlcic6Cj4gaW50ZWxf cGFuZWwuYzooLnRleHQrMHgyZWMxKTogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgYmFja2xpZ2h0 X2RldmljZV9yZWdpc3RlcicKPiBsZDogZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9wYW5lbC5vOiBpbiBmdW5jdGlvbiBgaW50ZWxfYmFja2xpZ2h0X2RldmljZV91bnJlZ2lzdGVy JzoKPiBpbnRlbF9wYW5lbC5jOigudGV4dCsweDJmOTMpOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRv IGBiYWNrbGlnaHRfZGV2aWNlX3VucmVnaXN0ZXInCj4KPiBGaXhlczogOTEyZThiMTJlZWRiICgi ZHJtL2k5MTU6IHJlZ2lzdGVyIGJhY2tsaWdodCBkZXZpY2UgYWxzbyB3aGVuIGJhY2tsaWdodCBj bGFzcyBpcyBhIG1vZHVsZSIpCj4gRml4ZXM6IDQ0YzEyMjBhNDQxYyAoImRybS9pOTE1OiBleHRy YWN0IGludGVsX3BhbmVsLmggZnJvbSBpbnRlbF9kcnYuaCIpCj4gU2lnbmVkLW9mZi1ieTogUmFu ZHkgRHVubGFwIDxyZHVubGFwQGluZnJhZGVhZC5vcmc+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5p a3VsYUBpbnRlbC5jb20+Cj4gQ2M6IERhbWllbiBMZXNwaWF1IDxkYW1pZW4ubGVzcGlhdUBpbnRl bC5jb20+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6 IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBM YWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiBDYzogUm9kcmlnbyBW aXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IENjOiBpbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiAtLS0KPiBG b3VuZCBpbiBsaW51eC1uZXh0IGJ1dCBhcHBsaWVzIHRvIG1haW5saW5lICg1LjEyKS4KPgo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3BhbmVsLmMgfCAgICAyICstCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfcGFuZWwuaCB8ICAgIDIgKy0KPiAgMiBm aWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4KPiAtLS0gbGlu dXgtbmV4dC0yMDIxMDQyNi5vcmlnL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf cGFuZWwuYwo+ICsrKyBsaW51eC1uZXh0LTIwMjEwNDI2L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rp c3BsYXkvaW50ZWxfcGFuZWwuYwo+IEBAIC0xMjU0LDcgKzEyNTQsNyBAQCB2b2lkIGludGVsX3Bh bmVsX2VuYWJsZV9iYWNrbGlnaHQoY29uc3QKPiAgCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPmJh Y2tsaWdodF9sb2NrKTsKPiAgfQo+ICAKPiAtI2lmIElTX0VOQUJMRUQoQ09ORklHX0JBQ0tMSUdI VF9DTEFTU19ERVZJQ0UpCj4gKyNpZiBJU19SRUFDSEFCTEUoQ09ORklHX0JBQ0tMSUdIVF9DTEFT U19ERVZJQ0UpCj4gIHN0YXRpYyB1MzIgaW50ZWxfcGFuZWxfZ2V0X2JhY2tsaWdodChzdHJ1Y3Qg aW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5iYXNlLmRldik7Cj4gLS0tIGxpbnV4 LW5leHQtMjAyMTA0MjYub3JpZy9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3Bh bmVsLmgKPiArKysgbGludXgtbmV4dC0yMDIxMDQyNi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw bGF5L2ludGVsX3BhbmVsLmgKPiBAQCAtNTQsNyArNTQsNyBAQCB1MzIgaW50ZWxfcGFuZWxfaW52 ZXJ0X3B3bV9sZXZlbChzdHJ1Y3QKPiAgdTMyIGludGVsX3BhbmVsX2JhY2tsaWdodF9sZXZlbF90 b19wd20oc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLCB1MzIgbGV2ZWwpOwo+ICB1 MzIgaW50ZWxfcGFuZWxfYmFja2xpZ2h0X2xldmVsX2Zyb21fcHdtKHN0cnVjdCBpbnRlbF9jb25u ZWN0b3IgKmNvbm5lY3RvciwgdTMyIHZhbCk7Cj4gIAo+IC0jaWYgSVNfRU5BQkxFRChDT05GSUdf QkFDS0xJR0hUX0NMQVNTX0RFVklDRSkKPiArI2lmIElTX1JFQUNIQUJMRShDT05GSUdfQkFDS0xJ R0hUX0NMQVNTX0RFVklDRSkKPiAgaW50IGludGVsX2JhY2tsaWdodF9kZXZpY2VfcmVnaXN0ZXIo c3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKTsKPiAgdm9pZCBpbnRlbF9iYWNrbGln aHRfZGV2aWNlX3VucmVnaXN0ZXIoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKTsK PiAgI2Vsc2UgLyogQ09ORklHX0JBQ0tMSUdIVF9DTEFTU19ERVZJQ0UgKi8KCi0tIApKYW5pIE5p a3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A35F1C433B4 for ; Tue, 27 Apr 2021 08:03:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAFD4613C2 for ; Tue, 27 Apr 2021 08:03:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAFD4613C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C287E6E913; Tue, 27 Apr 2021 08:03:43 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2E896E90F; Tue, 27 Apr 2021 08:03:41 +0000 (UTC) IronPort-SDR: /tesrDXl/0bIqfNIr8lB9eEiXl0JDZM1hS9fULi76Kuv/XKRAsUIwqGGRZZGAaW8LdB9zn7+BL MzzJs9K6YSWg== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="176584861" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="176584861" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 01:03:40 -0700 IronPort-SDR: uLSXj0EdQtmdIW8C+zJUYeRb5TCTvPoVqeHWDsN4Sc0vwYGNFSJgVpsJw2m4Agpf5QiIWRG69j +BwbPNqlLoeg== X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="429720252" Received: from aalbarra-mobl.ger.corp.intel.com (HELO localhost) ([10.249.41.45]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 01:03:36 -0700 From: Jani Nikula To: Randy Dunlap , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: i915: fix build when ACPI is disabled and BACKLIGHT=m In-Reply-To: <20210426183516.18957-1-rdunlap@infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210426183516.18957-1-rdunlap@infradead.org> Date: Tue, 27 Apr 2021 11:03:34 +0300 Message-ID: <874kfs5f3d.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Randy Dunlap , Daniel Vetter , Damien Lespiau , dri-devel@lists.freedesktop.org, Rodrigo Vivi , intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCAyNiBBcHIgMjAyMSwgUmFuZHkgRHVubGFwIDxyZHVubGFwQGluZnJhZGVhZC5vcmc+ IHdyb3RlOgo+IFdoZW4gQ09ORklHX0RSTV9JOTE1PXksIENPTkZJR19BQ1BJIGlzIG5vdCBzZXQs IGFuZAo+IENPTkZJR19CQUNLTElHSFRfQ0xBU1NfREVWSUNFPW0sIG5vdCBkdWUgdG8gSTkxNSBj b25maWcsCj4gdGhlcmUgYXJlIGJ1aWxkIGVycm9ycyB0cnlpbmcgdG8gcmVmZXJlbmNlIGJhY2ts aWdodF9kZXZpY2Vfe3VufXJlZ2lzdGVyKCkuCj4KPiBDaGFuZ2luZyB0aGUgdXNlIG9mIElTX0VO QUJMRUQoKSB0byBJU19SRUFDSEFCTEUoKSBpbiBpbnRlbF9wYW5lbC5bY2hdCj4gZml4ZXMgdGhp cy4KCkkgZmVlbCBsaWtlIGEgYnJva2VuIHJlY29yZC4uLgoKQ09ORklHX0RSTV9JOTE1PXkgYW5k IENPTkZJR19CQUNLTElHSFRfQ0xBU1NfREVWSUNFPW0gaXMgYW4gaW52YWxpZApjb25maWd1cmF0 aW9uLiBUaGUgcGF0Y2ggYXQgaGFuZCBqdXN0IHNpbGVudGx5IGhpZGVzIHRoZSBwcm9ibGVtLAps ZWF2aW5nIHlvdSB3aXRob3V0IGJhY2tsaWdodC4KCmk5MTUgc2hvdWxkICpkZXBlbmQqIG9uIGJh Y2tsaWdodCwgbm90IHNlbGVjdCBpdC4gSXQgd291bGQgZXhwcmVzcyB0aGUKZGVwZW5kZW5jeSB3 aXRob3V0IGNoYW5jZXMgZm9yIGludmFsaWQgY29uZmlndXJhdGlvbi4KCkhvd2V2ZXIsIGk5MTUg YWxvbmUgY2FuJ3QgZGVwZW5kIG9uIGJhY2tsaWdodCwgYWxsIHVzZXJzIG9mIGJhY2tsaWdodApz aG91bGQgZGVwZW5kIG9uIGJhY2tsaWdodCwgbm90IHNlbGVjdCBpdC4gT3RoZXJ3aXNlLCB5b3Ug ZW5kIHVwIHdpdGgKb3RoZXIgY29uZmlndXJhdGlvbiBwcm9ibGVtcywgY2lyY3VsYXIgZGVwZW5k ZW5jaWVzIGFuZAp3aGF0bm90LiBFdmVyeW9uZSBzaG91bGQgY2hhbmdlLiBTZWUgYWxzbyAoKikg d2h5IHNlbGVjdCBpcyBub3QgYSBnb29kCmlkZWEgaGVyZS4KCkkndmUgc2VudCBwYXRjaGVzIHRv IHRoaXMgZWZmZWN0IGJlZm9yZSwgZ290IHJlamVjdGVkLCBhbmQgdGhlIHNhbWUKdGhpbmcgZ2V0 cyByZXBlYXRlZCBhZCBpbmZpbml0dW0uCgpBY2NlcHRpbmcgdGhpcyBwYXRjaCB3b3VsZCBzdG9w IHRoZSBpbmZsb3cgb2YgdGhlc2UgcmVwb3J0cyBhbmQgc2ltaWxhcgpwYXRjaGVzLCBidXQgaXQg ZG9lcyBub3QgZml4IHRoZSByb290IGNhdXNlLiBJdCBqdXN0IHN3ZWVwcyB0aGUgcHJvYmxlbQp1 bmRlciB0aGUgcnVnLgoKCkJSLApKYW5pLgoKKCopIERvY3VtZW50YXRpb24va2J1aWxkL2tjb25m aWctbGFuZ3VhZ2UucnN0OgoKCXNlbGVjdCBzaG91bGQgYmUgdXNlZCB3aXRoIGNhcmUuIHNlbGVj dCB3aWxsIGZvcmNlCglhIHN5bWJvbCB0byBhIHZhbHVlIHdpdGhvdXQgdmlzaXRpbmcgdGhlIGRl cGVuZGVuY2llcy4KCUJ5IGFidXNpbmcgc2VsZWN0IHlvdSBhcmUgYWJsZSB0byBzZWxlY3QgYSBz eW1ib2wgRk9PIGV2ZW4KCWlmIEZPTyBkZXBlbmRzIG9uIEJBUiB0aGF0IGlzIG5vdCBzZXQuCglJ biBnZW5lcmFsIHVzZSBzZWxlY3Qgb25seSBmb3Igbm9uLXZpc2libGUgc3ltYm9scwoJKG5vIHBy b21wdHMgYW55d2hlcmUpIGFuZCBmb3Igc3ltYm9scyB3aXRoIG5vIGRlcGVuZGVuY2llcy4KCVRo YXQgd2lsbCBsaW1pdCB0aGUgdXNlZnVsbmVzcyBidXQgb24gdGhlIG90aGVyIGhhbmQgYXZvaWQK CXRoZSBpbGxlZ2FsIGNvbmZpZ3VyYXRpb25zIGFsbCBvdmVyLgoKCj4KPiBsZDogZHJpdmVycy9n cHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9wYW5lbC5vOiBpbiBmdW5jdGlvbiBgaW50ZWxfYmFj a2xpZ2h0X2RldmljZV9yZWdpc3Rlcic6Cj4gaW50ZWxfcGFuZWwuYzooLnRleHQrMHgyZWMxKTog dW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgYmFja2xpZ2h0X2RldmljZV9yZWdpc3RlcicKPiBsZDog ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9wYW5lbC5vOiBpbiBmdW5jdGlvbiBg aW50ZWxfYmFja2xpZ2h0X2RldmljZV91bnJlZ2lzdGVyJzoKPiBpbnRlbF9wYW5lbC5jOigudGV4 dCsweDJmOTMpOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBiYWNrbGlnaHRfZGV2aWNlX3VucmVn aXN0ZXInCj4KPiBsZDogZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9wYW5lbC5v OiBpbiBmdW5jdGlvbiBgaW50ZWxfYmFja2xpZ2h0X2RldmljZV9yZWdpc3Rlcic6Cj4gaW50ZWxf cGFuZWwuYzooLnRleHQrMHgyZWMxKTogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgYmFja2xpZ2h0 X2RldmljZV9yZWdpc3RlcicKPiBsZDogZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRl bF9wYW5lbC5vOiBpbiBmdW5jdGlvbiBgaW50ZWxfYmFja2xpZ2h0X2RldmljZV91bnJlZ2lzdGVy JzoKPiBpbnRlbF9wYW5lbC5jOigudGV4dCsweDJmOTMpOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRv IGBiYWNrbGlnaHRfZGV2aWNlX3VucmVnaXN0ZXInCj4KPiBGaXhlczogOTEyZThiMTJlZWRiICgi ZHJtL2k5MTU6IHJlZ2lzdGVyIGJhY2tsaWdodCBkZXZpY2UgYWxzbyB3aGVuIGJhY2tsaWdodCBj bGFzcyBpcyBhIG1vZHVsZSIpCj4gRml4ZXM6IDQ0YzEyMjBhNDQxYyAoImRybS9pOTE1OiBleHRy YWN0IGludGVsX3BhbmVsLmggZnJvbSBpbnRlbF9kcnYuaCIpCj4gU2lnbmVkLW9mZi1ieTogUmFu ZHkgRHVubGFwIDxyZHVubGFwQGluZnJhZGVhZC5vcmc+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5p a3VsYUBpbnRlbC5jb20+Cj4gQ2M6IERhbWllbiBMZXNwaWF1IDxkYW1pZW4ubGVzcGlhdUBpbnRl bC5jb20+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6 IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBM YWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiBDYzogUm9kcmlnbyBW aXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IENjOiBpbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiAtLS0KPiBG b3VuZCBpbiBsaW51eC1uZXh0IGJ1dCBhcHBsaWVzIHRvIG1haW5saW5lICg1LjEyKS4KPgo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3BhbmVsLmMgfCAgICAyICstCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfcGFuZWwuaCB8ICAgIDIgKy0KPiAgMiBm aWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4KPiAtLS0gbGlu dXgtbmV4dC0yMDIxMDQyNi5vcmlnL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf cGFuZWwuYwo+ICsrKyBsaW51eC1uZXh0LTIwMjEwNDI2L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rp c3BsYXkvaW50ZWxfcGFuZWwuYwo+IEBAIC0xMjU0LDcgKzEyNTQsNyBAQCB2b2lkIGludGVsX3Bh bmVsX2VuYWJsZV9iYWNrbGlnaHQoY29uc3QKPiAgCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPmJh Y2tsaWdodF9sb2NrKTsKPiAgfQo+ICAKPiAtI2lmIElTX0VOQUJMRUQoQ09ORklHX0JBQ0tMSUdI VF9DTEFTU19ERVZJQ0UpCj4gKyNpZiBJU19SRUFDSEFCTEUoQ09ORklHX0JBQ0tMSUdIVF9DTEFT U19ERVZJQ0UpCj4gIHN0YXRpYyB1MzIgaW50ZWxfcGFuZWxfZ2V0X2JhY2tsaWdodChzdHJ1Y3Qg aW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5iYXNlLmRldik7Cj4gLS0tIGxpbnV4 LW5leHQtMjAyMTA0MjYub3JpZy9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3Bh bmVsLmgKPiArKysgbGludXgtbmV4dC0yMDIxMDQyNi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw bGF5L2ludGVsX3BhbmVsLmgKPiBAQCAtNTQsNyArNTQsNyBAQCB1MzIgaW50ZWxfcGFuZWxfaW52 ZXJ0X3B3bV9sZXZlbChzdHJ1Y3QKPiAgdTMyIGludGVsX3BhbmVsX2JhY2tsaWdodF9sZXZlbF90 b19wd20oc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLCB1MzIgbGV2ZWwpOwo+ICB1 MzIgaW50ZWxfcGFuZWxfYmFja2xpZ2h0X2xldmVsX2Zyb21fcHdtKHN0cnVjdCBpbnRlbF9jb25u ZWN0b3IgKmNvbm5lY3RvciwgdTMyIHZhbCk7Cj4gIAo+IC0jaWYgSVNfRU5BQkxFRChDT05GSUdf QkFDS0xJR0hUX0NMQVNTX0RFVklDRSkKPiArI2lmIElTX1JFQUNIQUJMRShDT05GSUdfQkFDS0xJ R0hUX0NMQVNTX0RFVklDRSkKPiAgaW50IGludGVsX2JhY2tsaWdodF9kZXZpY2VfcmVnaXN0ZXIo c3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKTsKPiAgdm9pZCBpbnRlbF9iYWNrbGln aHRfZGV2aWNlX3VucmVnaXN0ZXIoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKTsK PiAgI2Vsc2UgLyogQ09ORklHX0JBQ0tMSUdIVF9DTEFTU19ERVZJQ0UgKi8KCi0tIApKYW5pIE5p a3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2905CC433ED for ; Tue, 27 Apr 2021 08:03:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E50B861289 for ; Tue, 27 Apr 2021 08:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234928AbhD0IEZ convert rfc822-to-8bit (ORCPT ); Tue, 27 Apr 2021 04:04:25 -0400 Received: from mga04.intel.com ([192.55.52.120]:20092 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231161AbhD0IEX (ORCPT ); Tue, 27 Apr 2021 04:04:23 -0400 IronPort-SDR: lJd17ZRMJsra3lx6sxf2A1JNAPsLTSDudSB1FClwAuvBD25TIdWvzw9kwnxsNrfLGR0EzC4lvc RhroZG97asUQ== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="194351965" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="194351965" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 01:03:40 -0700 IronPort-SDR: uLSXj0EdQtmdIW8C+zJUYeRb5TCTvPoVqeHWDsN4Sc0vwYGNFSJgVpsJw2m4Agpf5QiIWRG69j +BwbPNqlLoeg== X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="429720252" Received: from aalbarra-mobl.ger.corp.intel.com (HELO localhost) ([10.249.41.45]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 01:03:36 -0700 From: Jani Nikula To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Randy Dunlap , Ville =?utf-8?B?U3lyasOkbMOk?= , Damien Lespiau , Daniel Vetter , Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: i915: fix build when ACPI is disabled and BACKLIGHT=m In-Reply-To: <20210426183516.18957-1-rdunlap@infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210426183516.18957-1-rdunlap@infradead.org> Date: Tue, 27 Apr 2021 11:03:34 +0300 Message-ID: <874kfs5f3d.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Apr 2021, Randy Dunlap wrote: > When CONFIG_DRM_I915=y, CONFIG_ACPI is not set, and > CONFIG_BACKLIGHT_CLASS_DEVICE=m, not due to I915 config, > there are build errors trying to reference backlight_device_{un}register(). > > Changing the use of IS_ENABLED() to IS_REACHABLE() in intel_panel.[ch] > fixes this. I feel like a broken record... CONFIG_DRM_I915=y and CONFIG_BACKLIGHT_CLASS_DEVICE=m is an invalid configuration. The patch at hand just silently hides the problem, leaving you without backlight. i915 should *depend* on backlight, not select it. It would express the dependency without chances for invalid configuration. However, i915 alone can't depend on backlight, all users of backlight should depend on backlight, not select it. Otherwise, you end up with other configuration problems, circular dependencies and whatnot. Everyone should change. See also (*) why select is not a good idea here. I've sent patches to this effect before, got rejected, and the same thing gets repeated ad infinitum. Accepting this patch would stop the inflow of these reports and similar patches, but it does not fix the root cause. It just sweeps the problem under the rug. BR, Jani. (*) Documentation/kbuild/kconfig-language.rst: select should be used with care. select will force a symbol to a value without visiting the dependencies. By abusing select you are able to select a symbol FOO even if FOO depends on BAR that is not set. In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies. That will limit the usefulness but on the other hand avoid the illegal configurations all over. > > ld: drivers/gpu/drm/i915/display/intel_panel.o: in function `intel_backlight_device_register': > intel_panel.c:(.text+0x2ec1): undefined reference to `backlight_device_register' > ld: drivers/gpu/drm/i915/display/intel_panel.o: in function `intel_backlight_device_unregister': > intel_panel.c:(.text+0x2f93): undefined reference to `backlight_device_unregister' > > ld: drivers/gpu/drm/i915/display/intel_panel.o: in function `intel_backlight_device_register': > intel_panel.c:(.text+0x2ec1): undefined reference to `backlight_device_register' > ld: drivers/gpu/drm/i915/display/intel_panel.o: in function `intel_backlight_device_unregister': > intel_panel.c:(.text+0x2f93): undefined reference to `backlight_device_unregister' > > Fixes: 912e8b12eedb ("drm/i915: register backlight device also when backlight class is a module") > Fixes: 44c1220a441c ("drm/i915: extract intel_panel.h from intel_drv.h") > Signed-off-by: Randy Dunlap > Cc: Ville Syrjälä > Cc: Jani Nikula > Cc: Damien Lespiau > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > --- > Found in linux-next but applies to mainline (5.12). > > drivers/gpu/drm/i915/display/intel_panel.c | 2 +- > drivers/gpu/drm/i915/display/intel_panel.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > --- linux-next-20210426.orig/drivers/gpu/drm/i915/display/intel_panel.c > +++ linux-next-20210426/drivers/gpu/drm/i915/display/intel_panel.c > @@ -1254,7 +1254,7 @@ void intel_panel_enable_backlight(const > mutex_unlock(&dev_priv->backlight_lock); > } > > -#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) > +#if IS_REACHABLE(CONFIG_BACKLIGHT_CLASS_DEVICE) > static u32 intel_panel_get_backlight(struct intel_connector *connector) > { > struct drm_i915_private *dev_priv = to_i915(connector->base.dev); > --- linux-next-20210426.orig/drivers/gpu/drm/i915/display/intel_panel.h > +++ linux-next-20210426/drivers/gpu/drm/i915/display/intel_panel.h > @@ -54,7 +54,7 @@ u32 intel_panel_invert_pwm_level(struct > u32 intel_panel_backlight_level_to_pwm(struct intel_connector *connector, u32 level); > u32 intel_panel_backlight_level_from_pwm(struct intel_connector *connector, u32 val); > > -#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) > +#if IS_REACHABLE(CONFIG_BACKLIGHT_CLASS_DEVICE) > int intel_backlight_device_register(struct intel_connector *connector); > void intel_backlight_device_unregister(struct intel_connector *connector); > #else /* CONFIG_BACKLIGHT_CLASS_DEVICE */ -- Jani Nikula, Intel Open Source Graphics Center