From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CDDFC433E0 for ; Mon, 29 Mar 2021 14:47:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73D4F6196E for ; Mon, 29 Mar 2021 14:47:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231136AbhC2Oqh convert rfc822-to-8bit (ORCPT ); Mon, 29 Mar 2021 10:46:37 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:52709 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbhC2Oqb (ORCPT ); Mon, 29 Mar 2021 10:46:31 -0400 X-Originating-IP: 91.175.115.186 Received: from localhost (91-175-115-186.subs.proxad.net [91.175.115.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 71A3A1BF20F; Mon, 29 Mar 2021 14:46:26 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Lunn , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Marek =?utf-8?Q?Beh=C3=BAn?= , Miquel Raynal , Tomasz Maciej Nowak , Luka Perkov , Andre Heider , Vladimir Vid , Russell King , =?utf-8?Q?G=C3=A9rald?= Kerma , Konstantin Porotchkin Subject: Re: [PATCH mvebu v3 03/10] clk: mvebu: armada-37xx-periph: remove .set_parent method for CPU PM clock In-Reply-To: <20210222194158.12342-4-pali@kernel.org> References: <20210114124032.12765-1-pali@kernel.org> <20210222194158.12342-1-pali@kernel.org> <20210222194158.12342-4-pali@kernel.org> Date: Mon, 29 Mar 2021 16:46:26 +0200 Message-ID: <874kguf265.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Pali Rohár writes: > From: Marek Behún > > Remove the .set_parent method in clk_pm_cpu_ops. > > This method was supposed to be needed by the armada-37xx-cpufreq driver, > but was never actually called due to wrong assumptions in the cpufreq > driver. After this was fixed in the cpufreq driver, this method is not > needed anymore. > > Signed-off-by: Marek Behún > Acked-by: Stephen Boyd > Tested-by: Pali Rohár > Tested-by: Tomasz Maciej Nowak > Tested-by: Anders Trier Olesen > Tested-by: Philip Soares > Fixes: 2089dc33ea0e ("clk: mvebu: armada-37xx-periph: add DVFS support for cpu clocks") Acked-by: Gregory CLEMENT Thanks, Gregory > --- > drivers/clk/mvebu/armada-37xx-periph.c | 28 -------------------------- > 1 file changed, 28 deletions(-) > > diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c > index f5746f9ea929..6507bd2c5f31 100644 > --- a/drivers/clk/mvebu/armada-37xx-periph.c > +++ b/drivers/clk/mvebu/armada-37xx-periph.c > @@ -440,33 +440,6 @@ static u8 clk_pm_cpu_get_parent(struct clk_hw *hw) > return val; > } > > -static int clk_pm_cpu_set_parent(struct clk_hw *hw, u8 index) > -{ > - struct clk_pm_cpu *pm_cpu = to_clk_pm_cpu(hw); > - struct regmap *base = pm_cpu->nb_pm_base; > - int load_level; > - > - /* > - * We set the clock parent only if the DVFS is available but > - * not enabled. > - */ > - if (IS_ERR(base) || armada_3700_pm_dvfs_is_enabled(base)) > - return -EINVAL; > - > - /* Set the parent clock for all the load level */ > - for (load_level = 0; load_level < LOAD_LEVEL_NR; load_level++) { > - unsigned int reg, mask, val, > - offset = ARMADA_37XX_NB_TBG_SEL_OFF; > - > - armada_3700_pm_dvfs_update_regs(load_level, ®, &offset); > - > - val = index << offset; > - mask = ARMADA_37XX_NB_TBG_SEL_MASK << offset; > - regmap_update_bits(base, reg, mask, val); > - } > - return 0; > -} > - > static unsigned long clk_pm_cpu_recalc_rate(struct clk_hw *hw, > unsigned long parent_rate) > { > @@ -592,7 +565,6 @@ static int clk_pm_cpu_set_rate(struct clk_hw *hw, unsigned long rate, > > static const struct clk_ops clk_pm_cpu_ops = { > .get_parent = clk_pm_cpu_get_parent, > - .set_parent = clk_pm_cpu_set_parent, > .round_rate = clk_pm_cpu_round_rate, > .set_rate = clk_pm_cpu_set_rate, > .recalc_rate = clk_pm_cpu_recalc_rate, > -- > 2.20.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53DFEC433C1 for ; Mon, 29 Mar 2021 22:56:33 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8F1961987 for ; Mon, 29 Mar 2021 22:56:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8F1961987 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g7MLZl00QhQCBKsogTAWf34MLE6snITcui2Bg6tRjPM=; b=VTm62QbHL6jMwgtACnJb2XIa8 XxCKHHOYLgPvYO82rzybEmqjtsgF3SAUF+i88aD8QXF80GcSe8eGk7pr+Flk5q+NJV4pHv7Eq+N3z V9BdhR1pneihHxreY53WKQ/70nGrQvnCLQa9bLDu9Ezhnjdz1Rd7DesZbJaftEVC4oAwECz2T7kK6 ITg7E4brllKnKeFaE/GuRSef0kFgSfeHCYA1zvyygglcYqN4UwrDlvfRBcc/IHMe5y+ilCPr4R3ls fwszSPfIPL6mMvigp7GX8WBHvy9PjOP+OQVoItm9J3g9iDdAgTUNhaCqac242frYb5jKuzn2ru86z tWfNZgA4w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lR0mD-001mNp-Kd; Mon, 29 Mar 2021 22:54:30 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQt9y-000ieT-JD for linux-arm-kernel@lists.infradead.org; Mon, 29 Mar 2021 14:46:43 +0000 X-Originating-IP: 91.175.115.186 Received: from localhost (91-175-115-186.subs.proxad.net [91.175.115.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 71A3A1BF20F; Mon, 29 Mar 2021 14:46:26 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Lunn , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Marek =?utf-8?Q?Beh=C3=BAn?= , Miquel Raynal , Tomasz Maciej Nowak , Luka Perkov , Andre Heider , Vladimir Vid , Russell King , =?utf-8?Q?G=C3=A9rald?= Kerma , Konstantin Porotchkin Subject: Re: [PATCH mvebu v3 03/10] clk: mvebu: armada-37xx-periph: remove .set_parent method for CPU PM clock In-Reply-To: <20210222194158.12342-4-pali@kernel.org> References: <20210114124032.12765-1-pali@kernel.org> <20210222194158.12342-1-pali@kernel.org> <20210222194158.12342-4-pali@kernel.org> Date: Mon, 29 Mar 2021 16:46:26 +0200 Message-ID: <874kguf265.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210329_154640_760839_69B7E1A9 X-CRM114-Status: GOOD ( 17.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4gd3JpdGVzOgoKPiBGcm9tOiBNYXJlayBCZWjD um4gPGthYmVsQGtlcm5lbC5vcmc+Cj4KPiBSZW1vdmUgdGhlIC5zZXRfcGFyZW50IG1ldGhvZCBp biBjbGtfcG1fY3B1X29wcy4KPgo+IFRoaXMgbWV0aG9kIHdhcyBzdXBwb3NlZCB0byBiZSBuZWVk ZWQgYnkgdGhlIGFybWFkYS0zN3h4LWNwdWZyZXEgZHJpdmVyLAo+IGJ1dCB3YXMgbmV2ZXIgYWN0 dWFsbHkgY2FsbGVkIGR1ZSB0byB3cm9uZyBhc3N1bXB0aW9ucyBpbiB0aGUgY3B1ZnJlcQo+IGRy aXZlci4gQWZ0ZXIgdGhpcyB3YXMgZml4ZWQgaW4gdGhlIGNwdWZyZXEgZHJpdmVyLCB0aGlzIG1l dGhvZCBpcyBub3QKPiBuZWVkZWQgYW55bW9yZS4KPgo+IFNpZ25lZC1vZmYtYnk6IE1hcmVrIEJl aMO6biA8a2FiZWxAa2VybmVsLm9yZz4KPiBBY2tlZC1ieTogU3RlcGhlbiBCb3lkIDxzYm95ZEBr ZXJuZWwub3JnPgo+IFRlc3RlZC1ieTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4KPiBU ZXN0ZWQtYnk6IFRvbWFzeiBNYWNpZWogTm93YWsgPHRtbjUwNUBnbWFpbC5jb20+Cj4gVGVzdGVk LWJ5OiBBbmRlcnMgVHJpZXIgT2xlc2VuIDxhbmRlcnMudHJpZXIub2xlc2VuQGdtYWlsLmNvbT4K PiBUZXN0ZWQtYnk6IFBoaWxpcCBTb2FyZXMgPHBoaWxpcHNAbmV0aXNlbnNlLmNvbT4KPiBGaXhl czogMjA4OWRjMzNlYTBlICgiY2xrOiBtdmVidTogYXJtYWRhLTM3eHgtcGVyaXBoOiBhZGQgRFZG UyBzdXBwb3J0IGZvciBjcHUgY2xvY2tzIikKCkFja2VkLWJ5OiBHcmVnb3J5IENMRU1FTlQgPGdy ZWdvcnkuY2xlbWVudEBib290bGluLmNvbT4KClRoYW5rcywKCkdyZWdvcnkKPiAtLS0KPiAgZHJp dmVycy9jbGsvbXZlYnUvYXJtYWRhLTM3eHgtcGVyaXBoLmMgfCAyOCAtLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjggZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9jbGsvbXZlYnUvYXJtYWRhLTM3eHgtcGVyaXBoLmMgYi9kcml2ZXJzL2Ns ay9tdmVidS9hcm1hZGEtMzd4eC1wZXJpcGguYwo+IGluZGV4IGY1NzQ2ZjllYTkyOS4uNjUwN2Jk MmM1ZjMxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvY2xrL212ZWJ1L2FybWFkYS0zN3h4LXBlcmlw aC5jCj4gKysrIGIvZHJpdmVycy9jbGsvbXZlYnUvYXJtYWRhLTM3eHgtcGVyaXBoLmMKPiBAQCAt NDQwLDMzICs0NDAsNiBAQCBzdGF0aWMgdTggY2xrX3BtX2NwdV9nZXRfcGFyZW50KHN0cnVjdCBj bGtfaHcgKmh3KQo+ICAJcmV0dXJuIHZhbDsKPiAgfQo+ICAKPiAtc3RhdGljIGludCBjbGtfcG1f Y3B1X3NldF9wYXJlbnQoc3RydWN0IGNsa19odyAqaHcsIHU4IGluZGV4KQo+IC17Cj4gLQlzdHJ1 Y3QgY2xrX3BtX2NwdSAqcG1fY3B1ID0gdG9fY2xrX3BtX2NwdShodyk7Cj4gLQlzdHJ1Y3QgcmVn bWFwICpiYXNlID0gcG1fY3B1LT5uYl9wbV9iYXNlOwo+IC0JaW50IGxvYWRfbGV2ZWw7Cj4gLQo+ IC0JLyoKPiAtCSAqIFdlIHNldCB0aGUgY2xvY2sgcGFyZW50IG9ubHkgaWYgdGhlIERWRlMgaXMg YXZhaWxhYmxlIGJ1dAo+IC0JICogbm90IGVuYWJsZWQuCj4gLQkgKi8KPiAtCWlmIChJU19FUlIo YmFzZSkgfHwgYXJtYWRhXzM3MDBfcG1fZHZmc19pc19lbmFibGVkKGJhc2UpKQo+IC0JCXJldHVy biAtRUlOVkFMOwo+IC0KPiAtCS8qIFNldCB0aGUgcGFyZW50IGNsb2NrIGZvciBhbGwgdGhlIGxv YWQgbGV2ZWwgKi8KPiAtCWZvciAobG9hZF9sZXZlbCA9IDA7IGxvYWRfbGV2ZWwgPCBMT0FEX0xF VkVMX05SOyBsb2FkX2xldmVsKyspIHsKPiAtCQl1bnNpZ25lZCBpbnQgcmVnLCBtYXNrLCAgdmFs LAo+IC0JCQlvZmZzZXQgPSBBUk1BREFfMzdYWF9OQl9UQkdfU0VMX09GRjsKPiAtCj4gLQkJYXJt YWRhXzM3MDBfcG1fZHZmc191cGRhdGVfcmVncyhsb2FkX2xldmVsLCAmcmVnLCAmb2Zmc2V0KTsK PiAtCj4gLQkJdmFsID0gaW5kZXggPDwgb2Zmc2V0Owo+IC0JCW1hc2sgPSBBUk1BREFfMzdYWF9O Ql9UQkdfU0VMX01BU0sgPDwgb2Zmc2V0Owo+IC0JCXJlZ21hcF91cGRhdGVfYml0cyhiYXNlLCBy ZWcsIG1hc2ssIHZhbCk7Cj4gLQl9Cj4gLQlyZXR1cm4gMDsKPiAtfQo+IC0KPiAgc3RhdGljIHVu c2lnbmVkIGxvbmcgY2xrX3BtX2NwdV9yZWNhbGNfcmF0ZShzdHJ1Y3QgY2xrX2h3ICpodywKPiAg CQkJCQkgICAgdW5zaWduZWQgbG9uZyBwYXJlbnRfcmF0ZSkKPiAgewo+IEBAIC01OTIsNyArNTY1 LDYgQEAgc3RhdGljIGludCBjbGtfcG1fY3B1X3NldF9yYXRlKHN0cnVjdCBjbGtfaHcgKmh3LCB1 bnNpZ25lZCBsb25nIHJhdGUsCj4gIAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGNsa19vcHMgY2xr X3BtX2NwdV9vcHMgPSB7Cj4gIAkuZ2V0X3BhcmVudCA9IGNsa19wbV9jcHVfZ2V0X3BhcmVudCwK PiAtCS5zZXRfcGFyZW50ID0gY2xrX3BtX2NwdV9zZXRfcGFyZW50LAo+ICAJLnJvdW5kX3JhdGUg PSBjbGtfcG1fY3B1X3JvdW5kX3JhdGUsCj4gIAkuc2V0X3JhdGUgPSBjbGtfcG1fY3B1X3NldF9y YXRlLAo+ICAJLnJlY2FsY19yYXRlID0gY2xrX3BtX2NwdV9yZWNhbGNfcmF0ZSwKPiAtLSAKPiAy LjIwLjEKPgoKLS0gCkdyZWdvcnkgQ2xlbWVudCwgQm9vdGxpbgpFbWJlZGRlZCBMaW51eCBhbmQg S2VybmVsIGVuZ2luZWVyaW5nCmh0dHA6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=