Re: [PATCH 2/3] scripts/ci/gitlab-pipeline-status: give more information on failures

["Alex Bennée" <alex.bennee@linaro.org>]

Cleber Rosa <crosa@redhat.com> writes:

> When an HTTP GET request fails, it's useful to go beyond the "not
> successful" message, and show the code returned by the server.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  scripts/ci/gitlab-pipeline-status | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/ci/gitlab-pipeline-status b/scripts/ci/gitlab-pipeline-status
> index 0c1e8bd8a7..ad62ab3cfc 100755
> --- a/scripts/ci/gitlab-pipeline-status
> +++ b/scripts/ci/gitlab-pipeline-status
> @@ -56,7 +56,9 @@ def get_json_http_response(url):
>      connection.request('GET', url=url)
>      response = connection.getresponse()
>      if response.code != http.HTTPStatus.OK:
> -        raise CommunicationFailure("Failed to receive a successful response")
> +        msg = "Received unsuccessful response: %s (%s)" % (response.code,
> +                                                           response.reason)
> +        raise CommunicationFailure(msg)
>      return json.loads(response.read())


-- 
Alex Bennée