From: Kalle Valo <kvalo@codeaurora.org>
To: Pkshih <pkshih@realtek.com>
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony0620emma\@gmail.com" <tony0620emma@gmail.com>,
Timlee <timlee@realtek.com>,
"zhanjun\@uniontech.com" <zhanjun@uniontech.com>,
"kuba\@kernel.org" <kuba@kernel.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"davem\@davemloft.net" <davem@davemloft.net>,
"arnd\@arndb.de" <arnd@arndb.de>,
"chenhaoa\@uniontech.com" <chenhaoa@uniontech.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop
Date: Tue, 23 Feb 2021 11:29:07 +0200 [thread overview]
Message-ID: <874ki3i13w.fsf@codeaurora.org> (raw)
In-Reply-To: <1614069836.8409.0.camel@realtek.com> (pkshih@realtek.com's message of "Tue, 23 Feb 2021 08:43:59 +0000")
Pkshih <pkshih@realtek.com> writes:
> On Tue, 2021-02-23 at 09:08 +0200, Kalle Valo wrote:
>> Pkshih <pkshih@realtek.com> writes:
>>
>> >> > --- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
>> >> > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
>> >> > @@ -25,7 +25,6 @@ static struct pci_driver rtw_8822ce_driver = {
>> >> > .id_table = rtw_8822ce_id_table,
>> >> > .probe = rtw_pci_probe,
>> >> > .remove = rtw_pci_remove,
>> >> > - .driver.pm = &rtw_pm_ops,
>> >>
>> >> Why just 8822ce? Why not remove rtw_pm_ops entirely if it just creates
>> >> problems?
>> >
>> > I think we can't remove rtw_pm_ops, because wowlan will not work.
>>
>> Ah. A comment code in the code stating that would be nice.
>>
>
> I'll do it.
Thank you.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-02-23 9:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 9:46 [PATCH v2] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop Hao Chen
2021-02-22 10:29 ` Kalle Valo
2021-02-22 11:36 ` Pkshih
2021-02-22 12:57 ` Hao Chen
2021-02-22 13:13 ` Pkshih
2021-02-23 7:08 ` Kalle Valo
2021-02-23 8:43 ` Pkshih
2021-02-23 9:29 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ki3i13w.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=chenhaoa@uniontech.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=timlee@realtek.com \
--cc=tony0620emma@gmail.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.