From: Felipe Balbi <balbi@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
linux-usb@vger.kernel.org
Cc: John Youn <John.Youn@synopsys.com>
Subject: Re: [PATCH v2 6/7] usb: dwc3: gadget: Rename misleading function names
Date: Thu, 24 Sep 2020 10:47:46 +0300 [thread overview]
Message-ID: <874knnehul.fsf@kernel.org> (raw)
In-Reply-To: <554c6d34c5936630bbe292114fad9c3322a7161e.1596767991.git.thinhn@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> The functions dwc3_prepare_one_trb_sg and dwc3_prepare_one_trb_linear
> are not necessarily preparing "one" TRB, it can prepare multiple TRBs.
> Rename these functions as follow:
>
> dwc3_prepare_one_trb_sg -> dwc3_prepare_trbs_sg
> dwc3_prepare_one_trb_linear -> dwc3_prepare_trbs_linear
>
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
Tried to apply on top of -rc6:
checking file drivers/usb/dwc3/gadget.c
Hunk #1 FAILED at 1161.
Hunk #2 FAILED at 1231.
Hunk #3 FAILED at 1266.
Hunk #4 FAILED at 1294.
4 out of 4 hunks FAILED
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2020-09-24 7:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 2:46 [PATCH v2 0/7] usb: dwc3: gadget: Fix TRB preparation Thinh Nguyen
2020-08-07 2:46 ` [PATCH v2 1/7] usb: dwc3: gadget: Don't setup more than requested Thinh Nguyen
2020-08-13 16:25 ` Sasha Levin
2020-08-19 23:56 ` Sasha Levin
2020-08-26 13:54 ` Sasha Levin
2020-08-07 2:46 ` [PATCH v2 2/7] usb: dwc3: gadget: Fix handling ZLP Thinh Nguyen
2020-08-19 23:57 ` Sasha Levin
2020-08-26 13:54 ` Sasha Levin
2020-08-07 2:46 ` [PATCH v2 3/7] usb: dwc3: gadget: Handle ZLP for sg requests Thinh Nguyen
2020-08-07 2:46 ` [PATCH v2 4/7] usb: dwc3: gadget: Refactor preparing TRBs Thinh Nguyen
2020-08-17 13:42 ` Felipe Balbi
2020-08-17 17:35 ` Thinh Nguyen
2020-08-07 2:46 ` [PATCH v2 5/7] usb: dwc3: gadget: Account for extra TRB Thinh Nguyen
2020-08-07 2:46 ` [PATCH v2 6/7] usb: dwc3: gadget: Rename misleading function names Thinh Nguyen
2020-09-24 7:47 ` Felipe Balbi [this message]
2020-09-24 7:54 ` Thinh Nguyen
2020-09-24 8:53 ` Felipe Balbi
2020-09-24 9:06 ` Felipe Balbi
2020-08-07 2:47 ` [PATCH v2 7/7] usb: dwc3: ep0: Skip ZLP setup for OUT Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874knnehul.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.