From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove gen check before calling intel_rps_boost
Date: Thu, 23 Jul 2020 11:12:36 +0300 [thread overview]
Message-ID: <874kpy645n.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20200723074808.29908-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> It's been a while since gen6_rps_boost() [that only worked on gen6+] was
> replaced by intel_rps_boost() that understood itself when rps was
> active. Since the intel_rps_boost() is gen-agnostic, just call it.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_request.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index 679a915e9a63..e48daeef6882 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -1823,11 +1823,8 @@ long i915_request_wait(struct i915_request *rq,
> * but at a cost of spending more power processing the workload
> * (bad for battery).
> */
> - if (flags & I915_WAIT_PRIORITY) {
> - if (!i915_request_started(rq) &&
> - INTEL_GEN(rq->engine->i915) >= 6)
> - intel_rps_boost(rq);
> - }
> + if (flags & I915_WAIT_PRIORITY && !i915_request_started(rq))
> + intel_rps_boost(rq);
>
> wait.tsk = current;
> if (dma_fence_add_callback(&rq->fence, &wait.cb, request_wait_wake))
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-07-23 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 7:48 [Intel-gfx] [PATCH] drm/i915: Remove gen check before calling intel_rps_boost Chris Wilson
2020-07-23 8:12 ` Mika Kuoppala [this message]
2020-07-23 9:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2020-07-23 10:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-07-23 11:56 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kpy645n.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.