From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1ji9f5-0008FI-Sd for mharc-qemu-trivial@gnu.org; Mon, 08 Jun 2020 00:45:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ji9f4-0008Dw-1K for qemu-trivial@nongnu.org; Mon, 08 Jun 2020 00:45:26 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:24822 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1ji9f2-0006gt-Qh for qemu-trivial@nongnu.org; Mon, 08 Jun 2020 00:45:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591591523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TkO2tRryEFxdXSnxqcENl8+gD+uKgVegX4b04hw8ruU=; b=PrdVEW9NIvVm2FmulBbp2CBp7Q7wFCXcg9YeXmzp8mJ1JSmZbS3YhJrSL9NY9lj25sYY0F /I9iripecHw0DoFqGSAtFZHchzNL+Z+WuWsxku4NOdUl/ACwlek4/+Ni8jmX1kevHULFcK l4EMGZt//6yrdpGBc483lujVhmE6MCs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-429--NBwdgztPB29M2aboikFaQ-1; Mon, 08 Jun 2020 00:45:21 -0400 X-MC-Unique: -NBwdgztPB29M2aboikFaQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53302464; Mon, 8 Jun 2020 04:45:20 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-121.ams2.redhat.com [10.36.112.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0AF665C1D6; Mon, 8 Jun 2020 04:45:19 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7B01E11386A6; Mon, 8 Jun 2020 06:45:18 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Max Reitz , John Snow Subject: Re: [PATCH] block: Remove trailing newline in format used by error_report API References: <20200228123637.15160-1-philmd@redhat.com> <8736auipnb.fsf@dusky.pond.sub.org> Date: Mon, 08 Jun 2020 06:45:18 +0200 In-Reply-To: ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Fri, 5 Jun 2020 16:26:16 +0200") Message-ID: <874krmyxlt.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=207.211.31.81; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 00:45:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2020 04:45:26 -0000 Philippe Mathieu-Daud=C3=A9 writes: [...] > Why warn_reportf_err() doesn't take a 'Error **err' instead, to set err > to NULL after freeing *err? Why doesn't free() take a void ** argument, to set the pointer to null after freeing what it points to? Why doesn't close() take an int * argument? [...]