From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Show the full scaling curve on failure
Date: Tue, 21 Apr 2020 17:00:08 +0300 [thread overview]
Message-ID: <874ktdlz13.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20200421123733.12786-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> If we detect that the RPS end points do not scale perfectly, take the
> time to measure all the in between values as well. We are aborting the
> test, so we might as well spend the available time gathering critical
> debug information instead.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/selftest_rps.c | 36 ++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> index e0a791eac752..f8c416ab8539 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> @@ -484,11 +484,29 @@ int live_rps_frequency_cs(void *arg)
> if (!scaled_within(max.freq * min.count,
> min.freq * max.count,
> 2, 3)) {
> + int f;
> +
> pr_err("%s: CS did not scale with frequency! scaled min:%llu, max:%llu\n",
> engine->name,
> max.freq * min.count,
> min.freq * max.count);
> show_pcu_config(rps);
> +
> + for (f = min.freq + 1; f <= rps->max_freq; f++) {
> + int act = f;
> + u64 count;
> +
> + count = measure_cs_frequency_at(rps, engine, &act);
> + if (act < f)
> + break;
> +
No gripes but in here I ponder would you like to break after the info.
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> + pr_info("%s: %x:%uMHz: %lluKHz [%d%%]\n",
> + engine->name,
> + act, intel_gpu_freq(rps, act), count,
> + (int)DIV64_U64_ROUND_CLOSEST(100 * min.freq * count,
> + act * min.count));
> + }
> +
> err = -EINVAL;
> }
>
> @@ -593,11 +611,29 @@ int live_rps_frequency_srm(void *arg)
> if (!scaled_within(max.freq * min.count,
> min.freq * max.count,
> 1, 2)) {
> + int f;
> +
> pr_err("%s: CS did not scale with frequency! scaled min:%llu, max:%llu\n",
> engine->name,
> max.freq * min.count,
> min.freq * max.count);
> show_pcu_config(rps);
> +
> + for (f = min.freq + 1; f <= rps->max_freq; f++) {
> + int act = f;
> + u64 count;
> +
> + count = measure_frequency_at(rps, cntr, &act);
> + if (act < f)
> + break;
> +
> + pr_info("%s: %x:%uMHz: %lluKHz [%d%%]\n",
> + engine->name,
> + act, intel_gpu_freq(rps, act), count,
> + (int)DIV64_U64_ROUND_CLOSEST(100 * min.freq * count,
> + act * min.count));
> + }
> +
> err = -EINVAL;
> }
>
> --
> 2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-04-21 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 12:37 [Intel-gfx] [PATCH] drm/i915/selftests: Show the full scaling curve on failure Chris Wilson
2020-04-21 12:46 ` Chris Wilson
2020-04-21 13:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Show the full scaling curve on failure (rev2) Patchwork
2020-04-21 14:00 ` Mika Kuoppala [this message]
2020-04-21 14:09 ` [Intel-gfx] [PATCH] drm/i915/selftests: Show the full scaling curve on failure Chris Wilson
2020-04-21 19:26 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Show the full scaling curve on failure (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ktdlz13.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.