From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Kuznetsov Date: Mon, 23 Mar 2020 12:48:41 +0000 Subject: Re: [PATCH v3 9/9] KVM: SVM: Annotate svm_x86_ops as __initdata Message-Id: <874kuf9qza.fsf@vitty.brq.redhat.com> List-Id: References: <20200321202603.19355-1-sean.j.christopherson@intel.com> <20200321202603.19355-10-sean.j.christopherson@intel.com> In-Reply-To: <20200321202603.19355-10-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson , Paolo Bonzini Cc: Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Sean Christopherson writes: > Tag svm_x86_ops with __initdata now the the struct is copied by value to Same typo, "now that the struct". > a common x86 instance of kvm_x86_ops as part of kvm_init(). > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index b61bb306602b..ab2a1cf6c188 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -7350,7 +7350,7 @@ static void svm_pre_update_apicv_exec_ctrl(struct kvm *kvm, bool activate) > avic_update_access_page(kvm, activate); > } > > -static struct kvm_x86_ops svm_x86_ops __ro_after_init = { > +static struct kvm_x86_ops svm_x86_ops __initdata = { > .hardware_unsetup = svm_hardware_teardown, > .hardware_enable = svm_hardware_enable, > .hardware_disable = svm_hardware_disable, Reviewed-by: Vitaly Kuznetsov -- Vitaly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 379E7C54FCE for ; Mon, 23 Mar 2020 13:35:46 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id E09C320735 for ; Mon, 23 Mar 2020 13:35:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TRrPTNW/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E09C320735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 994EE4B0B5; Mon, 23 Mar 2020 09:35:45 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WTnVIxBFsJBx; Mon, 23 Mar 2020 09:35:44 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9F2E64B0D6; Mon, 23 Mar 2020 09:35:37 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 014A64A534 for ; Mon, 23 Mar 2020 08:48:48 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UrFSrAX-dmAX for ; Mon, 23 Mar 2020 08:48:47 -0400 (EDT) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 189BA4A4C0 for ; Mon, 23 Mar 2020 08:48:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584967726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jT01buco6uzW21meg0B5Msg/Bm4GIl6gV7g2Ambj934=; b=TRrPTNW/R1NsO3LwnelNOuoDFR+wCYTOqfKYhNeWyriNxid9WzWNQrjNim2cWGB0I0uHhh y8GDBT/atb8qLOcDdbdzdK2OgzKphQWgSjh+a0HxeVmbJbDtNctkijkCFIh8WQK+KOJzJq heRVxcFw0At/9ZPF21pQUUt8dOMjQFc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-4ZHkjmy5O2GFEebBji7xRA-1; Mon, 23 Mar 2020 08:48:45 -0400 X-MC-Unique: 4ZHkjmy5O2GFEebBji7xRA-1 Received: by mail-wm1-f72.google.com with SMTP id g9so1899089wmh.1 for ; Mon, 23 Mar 2020 05:48:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=wF/Z91rii7js9BxWiPX/IJSf6cOn716YQpoQOgnhvlY=; b=Mkammpv9bsOKZjPYBtdBMdlQCRrTCsHJCofzJcOPqAnuBaMERvrpro+EO0KoBwcwqh LaUJy88EepY+BzBudwiu7oH9y15nnfomnTtZ83OIfnTKMtxhjSrTwsLIn2fQYK7fpqEK OpXdv4nlU0LNqhKiy7thqKvu0sZUwYBxYdw8AZnUOn7GrNiODQMEVESHXRJhjZUBOJ7p EO1mgtXsZYOkmgo1ScxSd+ufODNeErkxsg+e6U/XxFlDocK+Uh07k+SRa0+i/XUaIQUW G6/axcrIxGAsxcnBc32rBKmWbyfRcR7rQk+RyTcAnry+oP44L5gYSM0/MUe9d8v+OVXi dVQg== X-Gm-Message-State: ANhLgQ0zK1nX15ox2l2eYzHGhzVdlEp5ybhbn6sKxYQ8fLdkqT+An78+ bgELmeWjt+INyHKjXe8epxsuKoyoFL4OUt2Yri1IF6CqFqBl65P6Fvtfl7gL2wOO+ZbxlljDjMq 4RkeOK3DSKH5o0w8is2WCLavx X-Received: by 2002:a1c:5544:: with SMTP id j65mr25700709wmb.60.1584967724307; Mon, 23 Mar 2020 05:48:44 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsE+BwUdC/3N3MhWCg3gX3gw8CdW/xveukJtA9Qqd5DxMyzUeCK03I5juokdRkfNo1dgo0DkQ== X-Received: by 2002:a1c:5544:: with SMTP id j65mr25700677wmb.60.1584967724024; Mon, 23 Mar 2020 05:48:44 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id j39sm24686004wre.11.2020.03.23.05.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 05:48:43 -0700 (PDT) From: Vitaly Kuznetsov To: Sean Christopherson , Paolo Bonzini Subject: Re: [PATCH v3 9/9] KVM: SVM: Annotate svm_x86_ops as __initdata In-Reply-To: <20200321202603.19355-10-sean.j.christopherson@intel.com> References: <20200321202603.19355-1-sean.j.christopherson@intel.com> <20200321202603.19355-10-sean.j.christopherson@intel.com> Date: Mon, 23 Mar 2020 13:48:41 +0100 Message-ID: <874kuf9qza.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Mailman-Approved-At: Mon, 23 Mar 2020 09:35:35 -0400 Cc: linux-arm-kernel@lists.infradead.org, Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, David Hildenbrand , Marc Zyngier , Joerg Roedel , Cornelia Huck , linux-mips@vger.kernel.org, Sean Christopherson , linux-kernel@vger.kernel.org, Paul Mackerras , Christian Borntraeger , kvm-ppc@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Sean Christopherson writes: > Tag svm_x86_ops with __initdata now the the struct is copied by value to Same typo, "now that the struct". > a common x86 instance of kvm_x86_ops as part of kvm_init(). > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index b61bb306602b..ab2a1cf6c188 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -7350,7 +7350,7 @@ static void svm_pre_update_apicv_exec_ctrl(struct kvm *kvm, bool activate) > avic_update_access_page(kvm, activate); > } > > -static struct kvm_x86_ops svm_x86_ops __ro_after_init = { > +static struct kvm_x86_ops svm_x86_ops __initdata = { > .hardware_unsetup = svm_hardware_teardown, > .hardware_enable = svm_hardware_enable, > .hardware_disable = svm_hardware_disable, Reviewed-by: Vitaly Kuznetsov -- Vitaly _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A396DC4332B for ; Mon, 23 Mar 2020 12:48:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74F312072E for ; Mon, 23 Mar 2020 12:48:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YUzEAw5o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728284AbgCWMss (ORCPT ); Mon, 23 Mar 2020 08:48:48 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:32352 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728262AbgCWMss (ORCPT ); Mon, 23 Mar 2020 08:48:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584967727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wF/Z91rii7js9BxWiPX/IJSf6cOn716YQpoQOgnhvlY=; b=YUzEAw5odvtGgwnsXrh8keojEDtlxHkVerI8Dfyb6mVPl1BcVoPgIxD+Oei3OxIdg080Lj 5/O0ewihSHfmeEUPLl9NCQ0hS20Sg4uVCv8Ubx1d+mPT+HR8hBfiQ4Y3gF+jHU/y1hnr1c T2yHrYRfihu1EVQlZoClXI/YTSXqQj0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-cuk6OhyzPfqo22oar_jeaA-1; Mon, 23 Mar 2020 08:48:45 -0400 X-MC-Unique: cuk6OhyzPfqo22oar_jeaA-1 Received: by mail-wm1-f70.google.com with SMTP id y1so1989801wmj.3 for ; Mon, 23 Mar 2020 05:48:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=wF/Z91rii7js9BxWiPX/IJSf6cOn716YQpoQOgnhvlY=; b=m8jn57uNSib3E0nvLbYphPcJQO6Zb+xmDu4oFifP4MyM7mmIKvD2zzY5ADBotHPoUf B+JGDUkRIwzUPhz50CoF9wsPAA3AeymSJkBmNE9Yj5nDYObjkd1LGlnqlRa+g8NiMLeC c90ROUvqRZuLQ8oc2pEeB3rnFf6x5CGWCxci8K5wZJwn/7ZLKu67ADm87T6wNFfjPE+j YkTwHx/SkruvIo2Fx1ZVDi8d5dRbUPaKz72Syj2SshqFc+w55mVCCJsKhBtg/nqCHvme ycqNx4xYHurUNcB5IG9R3x6qu2yD5a3CVgNfdYRBcTXAXt1r4mPuMMS16ToMFapVjYVd X8bA== X-Gm-Message-State: ANhLgQ1dhnUq61+1dzy+va1wjFpL7Urc8MpEtwShDC15jB3waGl8WjE2 Ej62n7H443O29pm4JfZ3DdLVXUH6LnkwiyK995DaqBrbtNvzNVL+oTzwVv3umHbziE7d5qzZlw6 VaIrii4mCxwT/SD+mVXk8AA== X-Received: by 2002:a1c:5544:: with SMTP id j65mr25700705wmb.60.1584967724307; Mon, 23 Mar 2020 05:48:44 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsE+BwUdC/3N3MhWCg3gX3gw8CdW/xveukJtA9Qqd5DxMyzUeCK03I5juokdRkfNo1dgo0DkQ== X-Received: by 2002:a1c:5544:: with SMTP id j65mr25700677wmb.60.1584967724024; Mon, 23 Mar 2020 05:48:44 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id j39sm24686004wre.11.2020.03.23.05.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 05:48:43 -0700 (PDT) From: Vitaly Kuznetsov To: Sean Christopherson , Paolo Bonzini Cc: Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 9/9] KVM: SVM: Annotate svm_x86_ops as __initdata In-Reply-To: <20200321202603.19355-10-sean.j.christopherson@intel.com> References: <20200321202603.19355-1-sean.j.christopherson@intel.com> <20200321202603.19355-10-sean.j.christopherson@intel.com> Date: Mon, 23 Mar 2020 13:48:41 +0100 Message-ID: <874kuf9qza.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Sean Christopherson writes: > Tag svm_x86_ops with __initdata now the the struct is copied by value to Same typo, "now that the struct". > a common x86 instance of kvm_x86_ops as part of kvm_init(). > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index b61bb306602b..ab2a1cf6c188 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -7350,7 +7350,7 @@ static void svm_pre_update_apicv_exec_ctrl(struct kvm *kvm, bool activate) > avic_update_access_page(kvm, activate); > } > > -static struct kvm_x86_ops svm_x86_ops __ro_after_init = { > +static struct kvm_x86_ops svm_x86_ops __initdata = { > .hardware_unsetup = svm_hardware_teardown, > .hardware_enable = svm_hardware_enable, > .hardware_disable = svm_hardware_disable, Reviewed-by: Vitaly Kuznetsov -- Vitaly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0CE8C4332B for ; Mon, 23 Mar 2020 12:49:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9DC12072E for ; Mon, 23 Mar 2020 12:49:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="l7mMf2nC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V/Aov3uQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9DC12072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fBsCVYd2f00sbGzjRmspW3IQcfWUFj9gfZn1mEDUUwE=; b=l7mMf2nCpfsiyo Et7nCoVldh7AMcVbdwVLpkS5vZCDcHvAm64ZV0PP7UKOSbrvV2oe0FOdAWpuRux22SebyQCxrHsFq 7RVs1x4BWCngL/jsvZ5CSfAlXdJLZ5AA0Hpn9d4CsoT6q6RhRAyQDka7Q8K7RwRan9bFN2oJYRAcD uP2TuGfDDrDGgPR0zRNKt0IVSf/woOgeekHMXg7ttoO0qXfrVK+jndgGG+0HFILItF7kQA/HkuFwk dgoliYyWnhQ6Y2oic4CWemN5jO/OoNnNCSwPPYtnMKsHFKu7gOoYuey5BtRM8qZQbQIa+16o4yVaW zl3R4/ncWNho3lWpv9Zg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGMVn-0006zC-Nq; Mon, 23 Mar 2020 12:48:59 +0000 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGMVe-0006py-18 for linux-arm-kernel@lists.infradead.org; Mon, 23 Mar 2020 12:48:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584967729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jT01buco6uzW21meg0B5Msg/Bm4GIl6gV7g2Ambj934=; b=V/Aov3uQLKxqYLDeMHnKSVD326jYw7ENwiO0XYXpJzCn2l8uoz/14nDpdK9tjlTpvpwiio PZreNzFaIJf0Rm4tOg1ABZuHag1D1yoClg1rJA6mpKzYhuMX9KA94VcH5JmhS6V04dWRTA udq3pr+ULXlDyBVjW+qQ5tCxRIend7c= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-PDXxN1mlMMGtdQz_2Ji65w-1; Mon, 23 Mar 2020 08:48:45 -0400 X-MC-Unique: PDXxN1mlMMGtdQz_2Ji65w-1 Received: by mail-wm1-f69.google.com with SMTP id g9so1899093wmh.1 for ; Mon, 23 Mar 2020 05:48:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=wF/Z91rii7js9BxWiPX/IJSf6cOn716YQpoQOgnhvlY=; b=sooQ3gOtrWwKMDi7vm/4XN66BL5icH/rMSvlgy0e4q4bLXLlgXU5Vj6ZUjeLTOkVKL Jje+d26u0Bzkbv77S7FEUC2B7v0vGPSRlaXeTV5tpSBlppSAb96QMv4MEqNeLySr1bqh cooXzc1iB+/VzgsEM/0R1oKGrtnYZt8hLCCENYCrg8BTjHOrCBTGT/kOJYFuRVaI0sMJ CvoZhYtbSMbs+DQ6uPApZ5S5dY0a9tMeQhG0Asdn9SZRAqxAsU538hxvDUiweHp0aXrt PG+q9z1QB1jDvALpWEGLw+F6mdPAmzKzamThR0ZKiXIjO89FpB67/xAQRXJdH0UyH9hr i+vg== X-Gm-Message-State: ANhLgQ00iRePa4jhL/G1ukMzEOveATyaRc5UbZua7xa8RXH+dF2G6HJp 7Kb8wkmAtXGxSToYm/cVDmgnTen3vGrmZSdVKnctEVYDdsAy8v0vzzeOQQw4zmQ9d5ST8eR6i/K yfTdplMNYlMem1Xt2UcBTreOVJ30TngYga9w= X-Received: by 2002:a1c:5544:: with SMTP id j65mr25700718wmb.60.1584967724309; Mon, 23 Mar 2020 05:48:44 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsE+BwUdC/3N3MhWCg3gX3gw8CdW/xveukJtA9Qqd5DxMyzUeCK03I5juokdRkfNo1dgo0DkQ== X-Received: by 2002:a1c:5544:: with SMTP id j65mr25700677wmb.60.1584967724024; Mon, 23 Mar 2020 05:48:44 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id j39sm24686004wre.11.2020.03.23.05.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 05:48:43 -0700 (PDT) From: Vitaly Kuznetsov To: Sean Christopherson , Paolo Bonzini Subject: Re: [PATCH v3 9/9] KVM: SVM: Annotate svm_x86_ops as __initdata In-Reply-To: <20200321202603.19355-10-sean.j.christopherson@intel.com> References: <20200321202603.19355-1-sean.j.christopherson@intel.com> <20200321202603.19355-10-sean.j.christopherson@intel.com> Date: Mon, 23 Mar 2020 13:48:41 +0100 Message-ID: <874kuf9qza.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200323_054850_153488_4D2ACFDE X-CRM114-Status: GOOD ( 12.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, David Hildenbrand , Marc Zyngier , Joerg Roedel , Cornelia Huck , linux-mips@vger.kernel.org, Sean Christopherson , linux-kernel@vger.kernel.org, Paul Mackerras , Christian Borntraeger , James Morse , kvm-ppc@vger.kernel.org, Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, Julien Thierry , Jim Mattson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sean Christopherson writes: > Tag svm_x86_ops with __initdata now the the struct is copied by value to Same typo, "now that the struct". > a common x86 instance of kvm_x86_ops as part of kvm_init(). > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index b61bb306602b..ab2a1cf6c188 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -7350,7 +7350,7 @@ static void svm_pre_update_apicv_exec_ctrl(struct kvm *kvm, bool activate) > avic_update_access_page(kvm, activate); > } > > -static struct kvm_x86_ops svm_x86_ops __ro_after_init = { > +static struct kvm_x86_ops svm_x86_ops __initdata = { > .hardware_unsetup = svm_hardware_teardown, > .hardware_enable = svm_hardware_enable, > .hardware_disable = svm_hardware_disable, Reviewed-by: Vitaly Kuznetsov -- Vitaly _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel