From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32503C3F2CD for ; Wed, 4 Mar 2020 15:15:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11FDC20848 for ; Wed, 4 Mar 2020 15:15:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11FDC20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9903D6E1A5; Wed, 4 Mar 2020 15:15:34 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A9456E1A5; Wed, 4 Mar 2020 15:15:33 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 07:15:19 -0800 X-IronPort-AV: E=Sophos;i="5.70,514,1574150400"; d="scan'208";a="234063946" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 07:15:16 -0800 From: Jani Nikula To: Hans de Goede , Joonas Lahtinen , Rodrigo Vivi , Ville =?utf-8?B?U3lyasOkbMOk?= Subject: Re: [PATCH resend 1/2] drm/i915: panel: Use intel_panel_compute_brightness() from pwm_setup_backlight() In-Reply-To: <895e4a40-2c3f-b964-102d-13eff5b3c268@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200221172927.510027-1-hdegoede@redhat.com> <895e4a40-2c3f-b964-102d-13eff5b3c268@redhat.com> Date: Wed, 04 Mar 2020 17:15:13 +0200 Message-ID: <874kv4p2wu.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 03 Mar 2020, Hans de Goede wrote: > Hi All, > > On 2/21/20 6:29 PM, Hans de Goede wrote: >> Use intel_panel_compute_brightness() from pwm_setup_backlight() so that >> we correctly take i915_modparams.invert_brightness and/or >> QUIRK_INVERT_BRIGHTNESS into account when setting + getting the initial >> brightness value. >> >> Signed-off-by: Hans de Goede > > ping? Any chance I can get a review from someone on this series? > > Both patches are pretty trivial really... For both, Reviewed-by: Jani Nikula And sad trombone, I was hoping I could nuke the whole module parameter one of these days. It used to be something associated with gen4 only. BR, Jani. > > Regards, > > Hans > > > >> --- >> drivers/gpu/drm/i915/display/intel_panel.c | 18 +++++++++++------- >> 1 file changed, 11 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c >> index 7b3ec6eb3382..9ebee7d93414 100644 >> --- a/drivers/gpu/drm/i915/display/intel_panel.c >> +++ b/drivers/gpu/drm/i915/display/intel_panel.c >> @@ -1843,6 +1843,7 @@ static int pwm_setup_backlight(struct intel_connector *connector, >> struct drm_i915_private *dev_priv = to_i915(dev); >> struct intel_panel *panel = &connector->panel; >> const char *desc; >> + u32 level, ns; >> int retval; >> >> /* Get the right PWM chip for DSI backlight according to VBT */ >> @@ -1866,8 +1867,12 @@ static int pwm_setup_backlight(struct intel_connector *connector, >> */ >> pwm_apply_args(panel->backlight.pwm); >> >> - retval = pwm_config(panel->backlight.pwm, CRC_PMIC_PWM_PERIOD_NS, >> - CRC_PMIC_PWM_PERIOD_NS); >> + panel->backlight.min = 0; /* 0% */ >> + panel->backlight.max = 100; /* 100% */ >> + level = intel_panel_compute_brightness(connector, 100); >> + ns = DIV_ROUND_UP(level * CRC_PMIC_PWM_PERIOD_NS, 100); >> + >> + retval = pwm_config(panel->backlight.pwm, ns, CRC_PMIC_PWM_PERIOD_NS); >> if (retval < 0) { >> DRM_ERROR("Failed to configure the pwm chip\n"); >> pwm_put(panel->backlight.pwm); >> @@ -1875,11 +1880,10 @@ static int pwm_setup_backlight(struct intel_connector *connector, >> return retval; >> } >> >> - panel->backlight.min = 0; /* 0% */ >> - panel->backlight.max = 100; /* 100% */ >> - panel->backlight.level = DIV_ROUND_UP( >> - pwm_get_duty_cycle(panel->backlight.pwm) * 100, >> - CRC_PMIC_PWM_PERIOD_NS); >> + level = DIV_ROUND_UP(pwm_get_duty_cycle(panel->backlight.pwm) * 100, >> + CRC_PMIC_PWM_PERIOD_NS); >> + panel->backlight.level = >> + intel_panel_compute_brightness(connector, level); >> panel->backlight.enabled = panel->backlight.level != 0; >> >> DRM_INFO("Using %s PWM for LCD backlight control\n", desc); >> > -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9476C3F2CD for ; Wed, 4 Mar 2020 15:15:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 816D720848 for ; Wed, 4 Mar 2020 15:15:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 816D720848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A00506E1AA; Wed, 4 Mar 2020 15:15:34 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A9456E1A5; Wed, 4 Mar 2020 15:15:33 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 07:15:19 -0800 X-IronPort-AV: E=Sophos;i="5.70,514,1574150400"; d="scan'208";a="234063946" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 07:15:16 -0800 From: Jani Nikula To: Hans de Goede , Joonas Lahtinen , Rodrigo Vivi , Ville =?utf-8?B?U3lyasOkbMOk?= In-Reply-To: <895e4a40-2c3f-b964-102d-13eff5b3c268@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200221172927.510027-1-hdegoede@redhat.com> <895e4a40-2c3f-b964-102d-13eff5b3c268@redhat.com> Date: Wed, 04 Mar 2020 17:15:13 +0200 Message-ID: <874kv4p2wu.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH resend 1/2] drm/i915: panel: Use intel_panel_compute_brightness() from pwm_setup_backlight() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 03 Mar 2020, Hans de Goede wrote: > Hi All, > > On 2/21/20 6:29 PM, Hans de Goede wrote: >> Use intel_panel_compute_brightness() from pwm_setup_backlight() so that >> we correctly take i915_modparams.invert_brightness and/or >> QUIRK_INVERT_BRIGHTNESS into account when setting + getting the initial >> brightness value. >> >> Signed-off-by: Hans de Goede > > ping? Any chance I can get a review from someone on this series? > > Both patches are pretty trivial really... For both, Reviewed-by: Jani Nikula And sad trombone, I was hoping I could nuke the whole module parameter one of these days. It used to be something associated with gen4 only. BR, Jani. > > Regards, > > Hans > > > >> --- >> drivers/gpu/drm/i915/display/intel_panel.c | 18 +++++++++++------- >> 1 file changed, 11 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c >> index 7b3ec6eb3382..9ebee7d93414 100644 >> --- a/drivers/gpu/drm/i915/display/intel_panel.c >> +++ b/drivers/gpu/drm/i915/display/intel_panel.c >> @@ -1843,6 +1843,7 @@ static int pwm_setup_backlight(struct intel_connector *connector, >> struct drm_i915_private *dev_priv = to_i915(dev); >> struct intel_panel *panel = &connector->panel; >> const char *desc; >> + u32 level, ns; >> int retval; >> >> /* Get the right PWM chip for DSI backlight according to VBT */ >> @@ -1866,8 +1867,12 @@ static int pwm_setup_backlight(struct intel_connector *connector, >> */ >> pwm_apply_args(panel->backlight.pwm); >> >> - retval = pwm_config(panel->backlight.pwm, CRC_PMIC_PWM_PERIOD_NS, >> - CRC_PMIC_PWM_PERIOD_NS); >> + panel->backlight.min = 0; /* 0% */ >> + panel->backlight.max = 100; /* 100% */ >> + level = intel_panel_compute_brightness(connector, 100); >> + ns = DIV_ROUND_UP(level * CRC_PMIC_PWM_PERIOD_NS, 100); >> + >> + retval = pwm_config(panel->backlight.pwm, ns, CRC_PMIC_PWM_PERIOD_NS); >> if (retval < 0) { >> DRM_ERROR("Failed to configure the pwm chip\n"); >> pwm_put(panel->backlight.pwm); >> @@ -1875,11 +1880,10 @@ static int pwm_setup_backlight(struct intel_connector *connector, >> return retval; >> } >> >> - panel->backlight.min = 0; /* 0% */ >> - panel->backlight.max = 100; /* 100% */ >> - panel->backlight.level = DIV_ROUND_UP( >> - pwm_get_duty_cycle(panel->backlight.pwm) * 100, >> - CRC_PMIC_PWM_PERIOD_NS); >> + level = DIV_ROUND_UP(pwm_get_duty_cycle(panel->backlight.pwm) * 100, >> + CRC_PMIC_PWM_PERIOD_NS); >> + panel->backlight.level = >> + intel_panel_compute_brightness(connector, level); >> panel->backlight.enabled = panel->backlight.level != 0; >> >> DRM_INFO("Using %s PWM for LCD backlight control\n", desc); >> > -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx