From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue PATCH v2 1/2] igc: Add support for taprio offloading
Date: Wed, 12 Feb 2020 16:24:42 -0800 [thread overview]
Message-ID: <874kvvwcz9.fsf@linux.intel.com> (raw)
In-Reply-To: <158136683984.75536.11605147606262842969@1.0.0.127.in-addr.arpa>
Andre Guedes <andre.guedes@linux.intel.com> writes:
> Hi Vinicius,
>
> Quoting Vinicius Costa Gomes (2020-02-07 10:24:42)
> ...
>> --- a/drivers/net/ethernet/intel/igc/igc_defines.h
>> +++ b/drivers/net/ethernet/intel/igc/igc_defines.h
> ...
>> +/* Transmit Scheduling */
>> +#define IGC_TQAVCTRL_TRANSMIT_MODE_TSN 0x00000001
>> +#define IGC_TQAVCTRL_ENHANCED_QAV 0x00000008
>> +
>> +#define IGC_TXQCTL_STRICT_CYCLE 0x00000002
>> +#define IGC_TXQCTL_STRICT_END 0x00000004
>> +#define IGC_TXQCTL_PREEMPTIBLE 0x00000008
>
> It seems you missed removing IGC_TXQCTL_PREEMPTIBLE here. This macro is not
> used anywhere in the code.
Will fix.
>
>> --- /dev/null
>> +++ b/drivers/net/ethernet/intel/igc/igc_tsn.h
>> @@ -0,0 +1,9 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/* Copyright (c) 2018 Intel Corporation */
>
> s/2018/2020 ?
Ugh, will fix.
>
> Regards,
>
> Andre
--
Vinicius
next prev parent reply other threads:[~2020-02-13 0:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 18:24 [Intel-wired-lan] [next-queue PATCH v2 0/2] igc: Add initial TSN qdiscs offloading Vinicius Costa Gomes
2020-02-07 18:24 ` [Intel-wired-lan] [next-queue PATCH v2 1/2] igc: Add support for taprio offloading Vinicius Costa Gomes
2020-02-10 20:33 ` Andre Guedes
2020-02-13 0:24 ` Vinicius Costa Gomes [this message]
2020-02-07 18:24 ` [Intel-wired-lan] [next-queue PATCH v2 2/2] igc: Add support for ETF offloading Vinicius Costa Gomes
2020-02-10 20:34 ` Andre Guedes
2020-02-11 1:13 ` Vinicius Costa Gomes
2020-02-11 18:16 ` Andre Guedes
2020-02-13 0:13 ` Vinicius Costa Gomes
2020-02-13 17:48 ` Andre Guedes
2020-02-13 0:23 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kvvwcz9.fsf@linux.intel.com \
--to=vinicius.gomes@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.