From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3ACBC2D0B1 for ; Thu, 6 Feb 2020 07:47:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FACC206CC for ; Thu, 6 Feb 2020 07:47:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727860AbgBFHrk convert rfc822-to-8bit (ORCPT ); Thu, 6 Feb 2020 02:47:40 -0500 Received: from mx2.suse.de ([195.135.220.15]:51630 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727768AbgBFHrk (ORCPT ); Thu, 6 Feb 2020 02:47:40 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 86837AEC4; Thu, 6 Feb 2020 07:47:35 +0000 (UTC) From: =?utf-8?Q?Aur=C3=A9lien?= Aptel To: Steve French , Ronnie Sahlberg Cc: linux-cifs Subject: Re: [PATCH] cifs: fail i/o on soft mounts if sessionsetup errors out In-Reply-To: References: <20200205010801.27759-1-lsahlber@redhat.com> Date: Thu, 06 Feb 2020 08:47:32 +0100 Message-ID: <874kw4nomj.fsf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Steve French writes: >> If we have a soft mount we should fail commands for session-setup >> failures (such as the password having changed/ account being deleted/ ...) >> and return an error back to the application. Looks good to me but we need to make sure it doesnt break failover on the buildbot. Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)