Re: [PATCH] tcg plugins: expose an API version concept

["Alex Bennée" <alex.bennee@linaro.org>]

Peter Maydell <peter.maydell@linaro.org> writes:

> On Mon, 4 Nov 2019 at 13:18, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> This is a very simple versioning API which allows the plugin
>> infrastructure to check the API a plugin was built against. We also
>> expose a min/cur API version to the plugin via the info block in case
>> it wants to avoid using old deprecated APIs in the future.
>
> I think the general idea here is fine, and I want to see
> us get the version-check into 4.2, because I don't think
> we should release a QEMU which doesn't do a basic version
> sanity check. I have some minor comments below.
>
>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  include/qemu/qemu-plugin.h | 19 +++++++++++++++++++
>>  plugins/loader.c           | 15 +++++++++++++++
>>  plugins/plugin.h           |  2 ++
>>  tests/plugin/bb.c          |  2 ++
>>  tests/plugin/empty.c       |  2 ++
>>  tests/plugin/hotpages.c    |  2 ++
>>  tests/plugin/howvec.c      |  2 ++
>>  tests/plugin/insn.c        |  2 ++
>>  tests/plugin/mem.c         |  2 ++
>>  9 files changed, 48 insertions(+)
>>
>> diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
>> index a00a7deb461..5502e112c81 100644
>> --- a/include/qemu/qemu-plugin.h
>> +++ b/include/qemu/qemu-plugin.h
>
> As an aside, is this the header file used for building
> the plugins? It seems a bit odd to have put it
> in include/qemu, which is for headers used when building
> QEMU itself.

It's also included by the internal plugin header. We could put it
somewhere else. include/api/? Where do the QMP specs end up?

I'll make the other changes in v2.

--
Alex Bennée