From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915/execlists: Ignore lost completion events Date: Tue, 10 Sep 2019 13:17:46 +0300 Message-ID: <874l1ktpyt.fsf@gaia.fi.intel.com> References: <20190907084334.28952-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id E337B6E848 for ; Tue, 10 Sep 2019 10:18:01 +0000 (UTC) In-Reply-To: <20190907084334.28952-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gSWNlbGFr ZSBoaXQgYW4gaXNzdWUgd2hlcmUgaXQgbWlzc2VkIHJlcG9ydGluZyBhIGNvbXBsZXRpb24gZXZl bnQgYW5kCj4gaW5zdGVhZCBqdW1wZWQgc3RyYWlnaHQgdG8gYSBpZGxlLT5hY3RpdmUgZXZlbnQg KHNraXBwaW5nIG92ZXIgdGhlCj4gYWN0aXZlLT5pZGxlIGFuZCBub3QgZXZlbiBoaXR0aW5nIHRo ZSBsaXRlLXJlc3RvcmUgcHJlZW1wdGlvbikuCj4KPiA2NjE0OTc1MTF1cyA6IHByb2Nlc3NfY3Ni OiByY3MwIGNzLWlycSBoZWFkPTExLCB0YWlsPTAKPiA2NjE0OTc1MTJ1cyA6IHByb2Nlc3NfY3Ni OiByY3MwIGNzYlswXTogc3RhdHVzPTB4MTAwMDgwMDI6MHgwMDAwMDAyMCBbbGl0ZS1yZXN0b3Jl XQo+IDY2MTQ5NzUxMnVzIDogdHJhY2VfcG9ydHM6IHJjczA6IHByZWVtcHRlZCB7IDI4Y2M4OjEx MDUyLCAwOjAgfQo+IDY2MTQ5NzUxM3VzIDogdHJhY2VfcG9ydHM6IHJjczA6IHByb21vdGUgeyAy OGNjODoxMTA1NCwgMDowIH0KPiA2NjE0OTc1MTR1cyA6IF9faTkxNV9yZXF1ZXN0X3N1Ym1pdDog cmNzMCBmZW5jZSAyOGNjODoxMTA1NiwgY3VycmVudCAxMTA1Mgo+IDY2MTQ5NzUxNHVzIDogX19l eGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0OiByY3MwOiBxdWV1ZV9wcmlvcml0eV9oaW50Oi0y MTQ3NDgzNjQ4LCBzdWJtaXQ6eWVzCj4gNjYxNDk3NTE1dXMgOiB0cmFjZV9wb3J0czogcmNzMDog c3VibWl0IHsgMjhjYzg6MTEwNTYsIDA6MCB9Cj4gNjYxNDk3NTMwdXMgOiBwcm9jZXNzX2NzYjog cmNzMCBjcy1pcnEgaGVhZD0wLCB0YWlsPTEKPiA2NjE0OTc1MzB1cyA6IHByb2Nlc3NfY3NiOiBy Y3MwIGNzYlsxXTogc3RhdHVzPTB4MTAwMDgwMDI6MHgwMDAwMDAyMCBbbGl0ZS1yZXN0b3JlXQo+ IDY2MTQ5NzUzMXVzIDogdHJhY2VfcG9ydHM6IHJjczA6IHByZWVtcHRlZCB7IDI4Y2M4OjExMDU0 ISwgMDowIH0KPiA2NjE0OTc1MzV1cyA6IHRyYWNlX3BvcnRzOiByY3MwOiBwcm9tb3RlIHsgMjhj Yzg6MTEwNTYsIDA6MCB9Cj4gNjYxNDk3NTQwdXMgOiBfX2k5MTVfcmVxdWVzdF9zdWJtaXQ6IHJj czAgZmVuY2UgMjhjYzg6MTEwNTgsIGN1cnJlbnQgMTEwNTQKPiA2NjE0OTc1NDR1cyA6IF9fZXhl Y2xpc3RzX3N1Ym1pc3Npb25fdGFza2xldDogcmNzMDogcXVldWVfcHJpb3JpdHlfaGludDotMjE0 NzQ4MzY0OCwgc3VibWl0Onllcwo+IDY2MTQ5NzU0NXVzIDogdHJhY2VfcG9ydHM6IHJjczA6IHN1 Ym1pdCB7IDI4Y2M4OjExMDU4LCAwOjAgfQo+IDY2MTQ5NzU1M3VzIDogcHJvY2Vzc19jc2I6IHJj czAgY3MtaXJxIGhlYWQ9MSwgdGFpbD0yCj4gNjYxNDk3NTUzdXMgOiBwcm9jZXNzX2NzYjogcmNz MCBjc2JbMl06IHN0YXR1cz0weDEwMDAwMDAxOjB4MDAwMDAwMDAgW2lkbGUtPmFjdGl2ZV0KPiA2 NjE0OTc1NzR1cyA6IHByb2Nlc3NfY3NiOiBwcm9jZXNzX2NzYjoxNTM4IEdFTV9CVUdfT04oKmV4 ZWNsaXN0cy0+YWN0aXZlKQo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0Bj aHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGlu dXguaW50ZWwuY29tPgoKVHJhY2UgaXMgY29udmluY2luZywgdGhvIGFsd2F5cyBpdCBmZWVscyBi aXQgdW5lYXN5CmZvciB0aGUgaGFyZHdhcmUgdG8gY2hhbmdlIHRoZSBiZWhhdmlvdXIgJ3N1ZGRl bmx5Jy4KQW5kIHN0YXRlIGZvbGRzIHRvIGEgYmluYXJ5IHNvIG90aGluZyBtdWNoIHRvIGFyZ3Vl IGFnYWluc3QuCgpSZXZpZXdlZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51 eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMu YyB8IDYzICsrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAx OCBpbnNlcnRpb25zKCspLCA0NSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2lu dGVsX2xyYy5jCj4gaW5kZXggMGRkZmJlYmJjYmJjLi4zYWFkMzViNTcwZDQgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbHJjLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9ndC9pbnRlbF9scmMuYwo+IEBAIC02OTMsNiArNjkzLDkgQEAgdHJhY2VfcG9y dHMoY29uc3Qgc3RydWN0IGludGVsX2VuZ2luZV9leGVjbGlzdHMgKmV4ZWNsaXN0cywKPiAgCWNv bnN0IHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSA9Cj4gIAkJY29udGFpbmVyX29mKGV4 ZWNsaXN0cywgdHlwZW9mKCplbmdpbmUpLCBleGVjbGlzdHMpOwo+ICAKPiArCWlmICghcG9ydHNb MF0pCj4gKwkJcmV0dXJuOwo+ICsKPiAgCUdFTV9UUkFDRSgiJXM6ICVzIHsgJWxseDolbGxkJXMs ICVsbHg6JWxsZCB9XG4iLAo+ICAJCSAgZW5naW5lLT5uYW1lLCBtc2csCj4gIAkJICBwb3J0c1sw XS0+ZmVuY2UuY29udGV4dCwKPiBAQCAtMTM4MSwxMyArMTM4NCw2IEBAIHJlc2V0X2luX3Byb2dy ZXNzKGNvbnN0IHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICpleGVjbGlzdHMpCj4gIAly ZXR1cm4gdW5saWtlbHkoIV9fdGFza2xldF9pc19lbmFibGVkKCZleGVjbGlzdHMtPnRhc2tsZXQp KTsKPiAgfQo+ICAKPiAtZW51bSBjc2Jfc3RlcCB7Cj4gLQlDU0JfTk9QLAo+IC0JQ1NCX1BST01P VEUsCj4gLQlDU0JfUFJFRU1QVCwKPiAtCUNTQl9DT01QTEVURSwKPiAtfTsKPiAtCj4gIC8qCj4g ICAqIFN0YXJ0aW5nIHdpdGggR2VuMTIsIHRoZSBzdGF0dXMgaGFzIGEgbmV3IGZvcm1hdDoKPiAg ICoKPiBAQCAtMTQxNCw3ICsxNDEwLDcgQEAgZW51bSBjc2Jfc3RlcCB7Cj4gICAqICAgICBiaXRz IDQ3LTU3OiBzdyBjb250ZXh0IGlkIG9mIHRoZSBscmMgdGhlIEdUIHN3aXRjaGVkIGF3YXkgZnJv bQo+ICAgKiAgICAgYml0cyA1OC02Mzogc3cgY291bnRlciBvZiB0aGUgbHJjIHRoZSBHVCBzd2l0 Y2hlZCBhd2F5IGZyb20KPiAgICovCj4gLXN0YXRpYyBpbmxpbmUgZW51bSBjc2Jfc3RlcAo+ICtz dGF0aWMgaW5saW5lIGJvb2wKPiAgZ2VuMTJfY3NiX3BhcnNlKGNvbnN0IHN0cnVjdCBpbnRlbF9l bmdpbmVfZXhlY2xpc3RzICpleGVjbGlzdHMsIGNvbnN0IHUzMiAqY3NiKQo+ICB7Cj4gIAl1MzIg bG93ZXJfZHcgPSBjc2JbMF07Cj4gQEAgLTE0MjQsNyArMTQyMCw3IEBAIGdlbjEyX2NzYl9wYXJz ZShjb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqZXhlY2xpc3RzLCBjb25zdCB1 MzIgKmNzYikKPiAgCWJvb2wgbmV3X3F1ZXVlID0gbG93ZXJfZHcgJiBHRU4xMl9DVFhfU1RBVFVT X1NXSVRDSEVEX1RPX05FV19RVUVVRTsKPiAgCj4gIAlpZiAoIWN0eF9hd2F5X3ZhbGlkICYmIGN0 eF90b192YWxpZCkKPiAtCQlyZXR1cm4gQ1NCX1BST01PVEU7Cj4gKwkJcmV0dXJuIHRydWU7Cj4g IAo+ICAJLyoKPiAgCSAqIFRoZSBjb250ZXh0IHN3aXRjaCBkZXRhaWwgaXMgbm90IGd1YXJhbnRl ZWQgdG8gYmUgNSB3aGVuIGEgcHJlZW1wdGlvbgo+IEBAIC0xNDM0LDcgKzE0MzAsNyBAQCBnZW4x Ml9jc2JfcGFyc2UoY29uc3Qgc3RydWN0IGludGVsX2VuZ2luZV9leGVjbGlzdHMgKmV4ZWNsaXN0 cywgY29uc3QgdTMyICpjc2IpCj4gIAkgKiB3b3VsZCByZXF1aXJlIHNvbWUgZXh0cmEgaGFuZGxp bmcsIGJ1dCB3ZSBkb24ndCBzdXBwb3J0IHRoYXQuCj4gIAkgKi8KPiAgCWlmIChuZXdfcXVldWUg JiYgY3R4X2F3YXlfdmFsaWQpCj4gLQkJcmV0dXJuIENTQl9QUkVFTVBUOwo+ICsJCXJldHVybiB0 cnVlOwo+ICAKPiAgCS8qCj4gIAkgKiBzd2l0Y2ggZGV0YWlsID0gNSBpcyBjb3ZlcmVkIGJ5IHRo ZSBjYXNlIGFib3ZlIGFuZCB3ZSBkbyBub3QgZXhwZWN0IGEKPiBAQCAtMTQ0MywyOSArMTQzOSwx MyBAQCBnZW4xMl9jc2JfcGFyc2UoY29uc3Qgc3RydWN0IGludGVsX2VuZ2luZV9leGVjbGlzdHMg KmV4ZWNsaXN0cywgY29uc3QgdTMyICpjc2IpCj4gIAkgKi8KPiAgCUdFTV9CVUdfT04oR0VOMTJf Q1RYX1NXSVRDSF9ERVRBSUwodXBwZXJfZHcpKTsKPiAgCj4gLQlpZiAoKmV4ZWNsaXN0cy0+YWN0 aXZlKSB7Cj4gLQkJR0VNX0JVR19PTighY3R4X2F3YXlfdmFsaWQpOwo+IC0JCXJldHVybiBDU0Jf Q09NUExFVEU7Cj4gLQl9Cj4gLQo+IC0JcmV0dXJuIENTQl9OT1A7Cj4gKwlyZXR1cm4gZmFsc2U7 Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbmxpbmUgZW51bSBjc2Jfc3RlcAo+ICtzdGF0aWMgaW5saW5l IGJvb2wKPiAgZ2VuOF9jc2JfcGFyc2UoY29uc3Qgc3RydWN0IGludGVsX2VuZ2luZV9leGVjbGlz dHMgKmV4ZWNsaXN0cywgY29uc3QgdTMyICpjc2IpCj4gIHsKPiAtCXVuc2lnbmVkIGludCBzdGF0 dXMgPSAqY3NiOwo+IC0KPiAtCWlmIChzdGF0dXMgJiBHRU44X0NUWF9TVEFUVVNfSURMRV9BQ1RJ VkUpCj4gLQkJcmV0dXJuIENTQl9QUk9NT1RFOwo+IC0KPiAtCWlmIChzdGF0dXMgJiBHRU44X0NU WF9TVEFUVVNfUFJFRU1QVEVEKQo+IC0JCXJldHVybiBDU0JfUFJFRU1QVDsKPiAtCj4gLQlpZiAo KmV4ZWNsaXN0cy0+YWN0aXZlKQo+IC0JCXJldHVybiBDU0JfQ09NUExFVEU7Cj4gLQo+IC0JcmV0 dXJuIENTQl9OT1A7Cj4gKwlyZXR1cm4gKmNzYiAmIChHRU44X0NUWF9TVEFUVVNfSURMRV9BQ1RJ VkUgfCBHRU44X0NUWF9TVEFUVVNfUFJFRU1QVEVEKTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQg cHJvY2Vzc19jc2Ioc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+IEBAIC0xNTA0LDcg KzE0ODQsNyBAQCBzdGF0aWMgdm9pZCBwcm9jZXNzX2NzYihzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmUpCj4gIAlybWIoKTsKPiAgCj4gIAlkbyB7Cj4gLQkJZW51bSBjc2Jfc3RlcCBjc2Jf c3RlcDsKPiArCQlib29sIHByb21vdGU7Cj4gIAo+ICAJCWlmICgrK2hlYWQgPT0gbnVtX2VudHJp ZXMpCj4gIAkJCWhlYWQgPSAwOwo+IEBAIC0xNTMyLDIwICsxNTEyLDE2IEBAIHN0YXRpYyB2b2lk IHByb2Nlc3NfY3NiKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgCQkJICBidWZb MiAqIGhlYWQgKyAwXSwgYnVmWzIgKiBoZWFkICsgMV0pOwo+ICAKPiAgCQlpZiAoSU5URUxfR0VO KGVuZ2luZS0+aTkxNSkgPj0gMTIpCj4gLQkJCWNzYl9zdGVwID0gZ2VuMTJfY3NiX3BhcnNlKGV4 ZWNsaXN0cywgYnVmICsgMiAqIGhlYWQpOwo+ICsJCQlwcm9tb3RlID0gZ2VuMTJfY3NiX3BhcnNl KGV4ZWNsaXN0cywgYnVmICsgMiAqIGhlYWQpOwo+ICAJCWVsc2UKPiAtCQkJY3NiX3N0ZXAgPSBn ZW44X2NzYl9wYXJzZShleGVjbGlzdHMsIGJ1ZiArIDIgKiBoZWFkKTsKPiAtCj4gLQkJc3dpdGNo IChjc2Jfc3RlcCkgewo+IC0JCWNhc2UgQ1NCX1BSRUVNUFQ6IC8qIGNhbmNlbCBvbGQgaW5mbGln aHQsIHByZXBhcmUgZm9yIHN3aXRjaCAqLwo+ICsJCQlwcm9tb3RlID0gZ2VuOF9jc2JfcGFyc2Uo ZXhlY2xpc3RzLCBidWYgKyAyICogaGVhZCk7Cj4gKwkJaWYgKHByb21vdGUpIHsKPiArCQkJLyog Y2FuY2VsIG9sZCBpbmZsaWdodCwgcHJlcGFyZSBmb3Igc3dpdGNoICovCj4gIAkJCXRyYWNlX3Bv cnRzKGV4ZWNsaXN0cywgInByZWVtcHRlZCIsIGV4ZWNsaXN0cy0+YWN0aXZlKTsKPiAtCj4gIAkJ CXdoaWxlICgqZXhlY2xpc3RzLT5hY3RpdmUpCj4gIAkJCQlleGVjbGlzdHNfc2NoZWR1bGVfb3V0 KCpleGVjbGlzdHMtPmFjdGl2ZSsrKTsKPiAgCj4gLQkJCS8qIGZhbGx0aHJvdWdoICovCj4gLQkJ Y2FzZSBDU0JfUFJPTU9URTogLyogc3dpdGNoIHBlbmRpbmcgdG8gaW5mbGlnaHQgKi8KPiAtCQkJ R0VNX0JVR19PTigqZXhlY2xpc3RzLT5hY3RpdmUpOwo+ICsJCQkvKiBzd2l0Y2ggcGVuZGluZyB0 byBpbmZsaWdodCAqLwo+ICAJCQlHRU1fQlVHX09OKCFhc3NlcnRfcGVuZGluZ192YWxpZChleGVj bGlzdHMsICJwcm9tb3RlIikpOwo+ICAJCQlleGVjbGlzdHMtPmFjdGl2ZSA9Cj4gIAkJCQltZW1j cHkoZXhlY2xpc3RzLT5pbmZsaWdodCwKPiBAQCAtMTU2MCw5ICsxNTM2LDEwIEBAIHN0YXRpYyB2 b2lkIHByb2Nlc3NfY3NiKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgCQkJCXJp bmdfc2V0X3BhdXNlZChlbmdpbmUsIDApOwo+ICAKPiAgCQkJV1JJVEVfT05DRShleGVjbGlzdHMt PnBlbmRpbmdbMF0sIE5VTEwpOwo+IC0JCQlicmVhazsKPiArCQl9IGVsc2Ugewo+ICsJCQlHRU1f QlVHX09OKCEqZXhlY2xpc3RzLT5hY3RpdmUpOwo+ICAKPiAtCQljYXNlIENTQl9DT01QTEVURTog LyogcG9ydDAgY29tcGxldGVkLCBhZHZhbmNlZCB0byBwb3J0MSAqLwo+ICsJCQkvKiBwb3J0MCBj b21wbGV0ZWQsIGFkdmFuY2VkIHRvIHBvcnQxICovCj4gIAkJCXRyYWNlX3BvcnRzKGV4ZWNsaXN0 cywgImNvbXBsZXRlZCIsIGV4ZWNsaXN0cy0+YWN0aXZlKTsKPiAgCj4gIAkJCS8qCj4gQEAgLTE1 NzcsMTAgKzE1NTQsNiBAQCBzdGF0aWMgdm9pZCBwcm9jZXNzX2NzYihzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmUpCj4gIAo+ICAJCQlHRU1fQlVHX09OKGV4ZWNsaXN0cy0+YWN0aXZlIC0g ZXhlY2xpc3RzLT5pbmZsaWdodCA+Cj4gIAkJCQkgICBleGVjbGlzdHNfbnVtX3BvcnRzKGV4ZWNs aXN0cykpOwo+IC0JCQlicmVhazsKPiAtCj4gLQkJY2FzZSBDU0JfTk9QOgo+IC0JCQlicmVhazsK PiAgCQl9Cj4gIAl9IHdoaWxlIChoZWFkICE9IHRhaWwpOwo+ICAKPiAtLSAKPiAyLjIzLjAKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4