From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0lwk-0000k0-Kd for ath10k@lists.infradead.org; Thu, 22 Aug 2019 12:12:08 +0000 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0F3DF81F01 for ; Thu, 22 Aug 2019 12:12:05 +0000 (UTC) Received: by mail-ed1-f69.google.com with SMTP id n7so3276344edr.5 for ; Thu, 22 Aug 2019 05:12:04 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: RE: [PATCH 4/7] ath10k: disable TX complete indication of htt for sdio In-Reply-To: <86d0eabcc63849efa914f2c14a3cd59f@aptaiexm02f.ap.qualcomm.com> References: <1566302108-18219-1-git-send-email-wgong@codeaurora.org> <1566302108-18219-5-git-send-email-wgong@codeaurora.org> <87blwkt480.fsf@toke.dk> <00992d0991704b0fae73a500bb2eb504@aptaiexm02f.ap.qualcomm.com> <8736husub0.fsf@toke.dk> <86d0eabcc63849efa914f2c14a3cd59f@aptaiexm02f.ap.qualcomm.com> Date: Thu, 22 Aug 2019 14:12:01 +0200 Message-ID: <874l29pffy.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Wen Gong , Wen Gong , "ath10k@lists.infradead.org" Cc: "linux-wireless@vger.kernel.org" V2VuIEdvbmcgPHdnb25nQHF0aS5xdWFsY29tbS5jb20+IHdyaXRlczoKCj4+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tCj4+IEZyb206IFRva2UgSMO4aWxhbmQtSsO4cmdlbnNlbiA8dG9rZUBy ZWRoYXQuY29tPgo+PiBTZW50OiBXZWRuZXNkYXksIEF1Z3VzdCAyMSwgMjAxOSA2OjEwIFBNCj4+ IFRvOiBXZW4gR29uZyA8d2dvbmdAcXRpLnF1YWxjb21tLmNvbT47IFdlbiBHb25nCj4+IDx3Z29u Z0Bjb2RlYXVyb3JhLm9yZz47IGF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCj4+IENjOiBsaW51 eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmcKPj4gU3ViamVjdDogW0VYVF0gUkU6IFtQQVRDSCA0 LzddIGF0aDEwazogZGlzYWJsZSBUWCBjb21wbGV0ZSBpbmRpY2F0aW9uIG9mIGh0dAo+PiBmb3Ig c2Rpbwo+PiAKPj4gV2VuIEdvbmcgPHdnb25nQHF0aS5xdWFsY29tbS5jb20+IHdyaXRlczoKPj4g Cj4+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4+ID4+IEZyb206IGF0aDEwayA8YXRo MTBrLWJvdW5jZXNAbGlzdHMuaW5mcmFkZWFkLm9yZz4gT24gQmVoYWxmIE9mIFRva2UKPj4gPj4g SMO4aWxhbmQtSsO4cmdlbnNlbgo+PiA+PiBTZW50OiBUdWVzZGF5LCBBdWd1c3QgMjAsIDIwMTkg ODoyNCBQTQo+PiA+PiBUbzogV2VuIEdvbmcgPHdnb25nQGNvZGVhdXJvcmEub3JnPjsgYXRoMTBr QGxpc3RzLmluZnJhZGVhZC5vcmcKPj4gPj4gQ2M6IGxpbnV4LXdpcmVsZXNzQHZnZXIua2VybmVs Lm9yZwo+PiA+PiBTdWJqZWN0OiBbRVhUXSBSZTogW1BBVENIIDQvN10gYXRoMTBrOiBkaXNhYmxl IFRYIGNvbXBsZXRlIGluZGljYXRpb24gb2YKPj4gaHR0Cj4+ID4gV2hlbiB0aGlzIHBhdGNoIGFw cGxpZWQsIGZpcm13YXJlIHdpbGwgbm90IGluZGljYXRlIHR4IGNvbXBsZXRlIGZvciB0eAo+PiA+ IERhdGEsIGl0IG9ubHkgaW5kaWNhdGUgSFRUX1QySF9NU0dfVFlQRV9UWF9DUkVESVRfVVBEQVRF X0lORCwKPj4gPiBUaGlzIGh0dCBtc2cgd2lsbCB0ZWxsIGhvdyBtYW55IGRhdGEgdHggY29tcGxl dGUgd2l0aG91dCBzdGF0dXMoc3RhdHVzCj4+IG1heWJlIHN1Y2Nlc3MvZmFpbCkuCj4+IAo+PiBB aCwgc28gdGhpcyBpcyBiYXNpY2FsbHkgYSBjb3VudGVyIG9mIGhvdyBtdWNoIGRhdGEgaXMgY3Vy cmVudGx5IHF1ZXVlZAo+PiBpbiB0aGUgZmlybXdhcmU/Cj4gWWVzLgo+PiAKPj4gPj4gQW5kIGNv dWxkIHlvdSBleHBsYWluIHdoYXQgdGhlIGNyZWRpdHMgdGhpbmcgaXMgZm9yLCBwbGVhc2U/IDop Cj4+ID4gRm9yIGhpZ2ggbGF0ZW5jeSBidXMgY2hpcCwgYWxsIHRoZSB0eCBkYXRhJ3MgY29udGVu dChpbmNsdWRlIGlwL3VkcC90Y3AKPj4gaGVhZGVyCj4+ID4gYW5kIHBheWxvYWQpIHdpbGwgYmUg dHJhbnNmZXIgdG8gZmlybXdhcmUncyBtZW1vcnkgdmlhIGJ1cy4KPj4gPiBBbmQgZmlybXdhcmUg aGFzIGxpbWl0ZWQgbWVtb3J5IGZvciB0eCBkYXRhLCB0aGUgdHggZGF0YSdzIGNvbnRlbnQgbXVz dAo+PiA+IFNhdmVkIGluIGZpcm13YXJlIG1lbW9yeSBiZWZvcmUgaXQgdHggY29tcGxldGUsIGlm IGF0aDEwayB0cmFuc2ZlciB0eAo+PiA+IGRhdGEgbW9yZSB0aGFuIHRoZSBsaW1pdCwgZmlybXdh cmUgd2lsbCBvY2N1ciBlcnJvci4gVGhlIGNyZWRpdCBpcyB1c2VkCj4+ID4gdG8gYXZvaWQgYXRo MTBrIGV4Y2VlZCB0aGUgbGltaXQuCj4+IAo+PiBXaGF0J3MgYSB0eXBpY2FsIGxpbWl0IGluIHRo ZSBmaXJtd2FyZT8KPiBJdCBpcyA5NiBkYXRhIHBhY2tldCBpbiBteSB0ZXN0LiBJdCBjYW4gY2hh bmdlZCBpbiBmaXJtd2FyZSBjb2RlLgoKUmlnaHQsIEkgc2VlLiBJcyB0aGlzIGNvdW50ZXIgYXZh aWxhYmxlIGluIGFsbCBhdGgxMGsgZmlybXdhcmUsIG9yIGlzIGl0ClNESU8gb25seT8KCkknbSBh c2tpbmcgYmVjYXVzZSB0aGlzIGNvdWxkIGFsc28gYmUgYSB3YXkgb2YgaW1wbGVtZW50aW5nIHNv bWV0aGluZwpsaWtlIEJ5dGUgUXVldWUgTGltaXRzICh0aG91Z2ggSSdtIG5vdCBzdXJlIGhvdyBl ZmZlY3RpdmUgaXQgd291bGQgYmUpLgoKLVRva2UKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9h dGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8465C3A5A1 for ; Thu, 22 Aug 2019 12:12:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5D67233FD for ; Thu, 22 Aug 2019 12:12:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733117AbfHVMMG convert rfc822-to-8bit (ORCPT ); Thu, 22 Aug 2019 08:12:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42194 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730980AbfHVMMG (ORCPT ); Thu, 22 Aug 2019 08:12:06 -0400 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0E51364132 for ; Thu, 22 Aug 2019 12:12:05 +0000 (UTC) Received: by mail-ed1-f70.google.com with SMTP id z2so3271222ede.2 for ; Thu, 22 Aug 2019 05:12:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=9h83h1p/qy02LMcxTntGw58CIiMA2cd2aWOiL/YUHAM=; b=HHHv0iv9uqAhagnLYYQuvMFxl6JT6zivrcnxhC90UdPvAdDU/8LRvha1wHpE8YqTym 7Euby4uOYewN3Q/5uEvSsI1Wi1zM9H819leL9B6XR+Jw0HDKhGR2hydKcqO1VwL5H0Za I4nXJ/+Gmq6oS/g8hiCpWuKReq1Dif54LeomS4cJeKX1KU4t9Ri2FHG6bvsJE/+6wl4G 9BAopuDAtcMiR5fWcsZBLul0kiUL3FasbVENt8pG5SG/2ZUtD62HO98EsnmRNTUHYtGR nbrvMMXHJWL4OHcPPV0pmsKfkrZpIzUnZyLB+kuNOeEBWVgiFIerZ7A9uG6jDFY8s8Rq 3pbg== X-Gm-Message-State: APjAAAVTC7Y6lpoaE42y9FalkROmGcGprX16A/YMZakYnRB0z9NalYSA 3UbOeo4cHZtk6E4j7i165FDvboxSZzOxt0UzorktIqdHHBTaDvcZaSomEBgKboCEZERjXshYQAK BU4Wp0bTdzqPMBTFcRk8RwPz+2S4= X-Received: by 2002:aa7:d043:: with SMTP id n3mr7422556edo.258.1566475923862; Thu, 22 Aug 2019 05:12:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqxfgFd0pqx/wt/2/8MBMZSdmQSjSFql9LbG8CrRYzr9Cjm4n9JWISkqTDdPw9bSmMel8QQqmA== X-Received: by 2002:aa7:d043:: with SMTP id n3mr7422537edo.258.1566475923726; Thu, 22 Aug 2019 05:12:03 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id e29sm4798065eda.51.2019.08.22.05.12.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2019 05:12:02 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 9BBC0181CEF; Thu, 22 Aug 2019 14:12:01 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Wen Gong , Wen Gong , "ath10k\@lists.infradead.org" Cc: "linux-wireless\@vger.kernel.org" Subject: RE: [PATCH 4/7] ath10k: disable TX complete indication of htt for sdio In-Reply-To: <86d0eabcc63849efa914f2c14a3cd59f@aptaiexm02f.ap.qualcomm.com> References: <1566302108-18219-1-git-send-email-wgong@codeaurora.org> <1566302108-18219-5-git-send-email-wgong@codeaurora.org> <87blwkt480.fsf@toke.dk> <00992d0991704b0fae73a500bb2eb504@aptaiexm02f.ap.qualcomm.com> <8736husub0.fsf@toke.dk> <86d0eabcc63849efa914f2c14a3cd59f@aptaiexm02f.ap.qualcomm.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 22 Aug 2019 14:12:01 +0200 Message-ID: <874l29pffy.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong writes: >> -----Original Message----- >> From: Toke Høiland-Jørgensen >> Sent: Wednesday, August 21, 2019 6:10 PM >> To: Wen Gong ; Wen Gong >> ; ath10k@lists.infradead.org >> Cc: linux-wireless@vger.kernel.org >> Subject: [EXT] RE: [PATCH 4/7] ath10k: disable TX complete indication of htt >> for sdio >> >> Wen Gong writes: >> >> >> -----Original Message----- >> >> From: ath10k On Behalf Of Toke >> >> Høiland-Jørgensen >> >> Sent: Tuesday, August 20, 2019 8:24 PM >> >> To: Wen Gong ; ath10k@lists.infradead.org >> >> Cc: linux-wireless@vger.kernel.org >> >> Subject: [EXT] Re: [PATCH 4/7] ath10k: disable TX complete indication of >> htt >> > When this patch applied, firmware will not indicate tx complete for tx >> > Data, it only indicate HTT_T2H_MSG_TYPE_TX_CREDIT_UPDATE_IND, >> > This htt msg will tell how many data tx complete without status(status >> maybe success/fail). >> >> Ah, so this is basically a counter of how much data is currently queued >> in the firmware? > Yes. >> >> >> And could you explain what the credits thing is for, please? :) >> > For high latency bus chip, all the tx data's content(include ip/udp/tcp >> header >> > and payload) will be transfer to firmware's memory via bus. >> > And firmware has limited memory for tx data, the tx data's content must >> > Saved in firmware memory before it tx complete, if ath10k transfer tx >> > data more than the limit, firmware will occur error. The credit is used >> > to avoid ath10k exceed the limit. >> >> What's a typical limit in the firmware? > It is 96 data packet in my test. It can changed in firmware code. Right, I see. Is this counter available in all ath10k firmware, or is it SDIO only? I'm asking because this could also be a way of implementing something like Byte Queue Limits (though I'm not sure how effective it would be). -Toke