From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Move OA files to separate folder
Date: Wed, 26 Jun 2019 16:02:49 +0300 [thread overview]
Message-ID: <874l4csdmu.fsf@intel.com> (raw)
In-Reply-To: <156155320544.2637.2792208469247178449@skylake-alporthouse-com>
On Wed, 26 Jun 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Michal Wajdeczko (2019-06-26 13:38:26)
>> OA files look to be auto-generated so we can keep them all in
>> dedicated subdirectory.
>
> The question I couldn't answer was how coupled into the GEM api is the
> i915_perf ioctl. Is the GEM context filtering an adjunct or core? The
> move makes sense, but I couldn't decide if it should be gem/oa instead.
>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>
>> ---
>> drivers/gpu/drm/i915/Makefile | 36 ++++++++++---------
>> drivers/gpu/drm/i915/i915_perf.c | 28 +++++++--------
>> drivers/gpu/drm/i915/oa/Makefile | 0
>
> Ok, so you chose not to hook up the standalone header test (to be
> replaced by builtin kbuild magic) -- iirc, Jani said the autogenerated
> headers were not standalone. Oh well.
That's right. We'll need to fix that afterwards.
BR,
Jani.
>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-26 13:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 12:38 [PATCH] drm/i915: Move OA files to separate folder Michal Wajdeczko
2019-06-26 12:46 ` Chris Wilson
2019-06-26 13:02 ` Jani Nikula [this message]
2019-06-26 12:47 ` Lionel Landwerlin
2019-06-26 12:47 ` Jani Nikula
2019-06-26 13:46 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-06-26 13:47 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-06-26 14:32 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-26 19:09 ` [PATCH] " Umesh Nerlige Ramappa
2019-06-26 22:27 ` Chris Wilson
2019-06-26 23:06 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874l4csdmu.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.