From: Kalle Valo <kvalo@codeaurora.org>
To: Nathan Huckleberry <nhuck@google.com>
Cc: eliad@wizery.com, davem@davemloft.net, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: Cleanup of -Wunused-const-variable in drivers/net/wireless/ti/wl18xx/main.c
Date: Fri, 14 Jun 2019 08:25:56 +0300 [thread overview]
Message-ID: <874l4slouz.fsf@codeaurora.org> (raw)
In-Reply-To: <CAJkfWY4WkeMv3Z+Nh4B0xtErTAi6mVCriURZTjd2Q__gMtaEqA@mail.gmail.com> (Nathan Huckleberry's message of "Thu, 13 Jun 2019 11:00:33 -0700")
Nathan Huckleberry <nhuck@google.com> writes:
> I'm looking into cleaning up ignored warnings in the kernel so we can
> remove compiler flags to ignore warnings.
>
> There are two unused variables ('wl18xx_iface_ap_cl_limits' and
> 'wl18xx_iface_ap_go_limits') in drivers/net/wireless/ti/wl18xx/main.c.
> These appear to be limits when using p2p devices, yet they are never
> used.
>
> Wanted to reach out for the best course of action to fix the warning.
>
> https://github.com/ClangBuiltLinux/linux/issues/530
The the variables were added in this commit:
commit 7845af35e0deeb7537de759ebc69d6395d4123bf
Author: Eliad Peller <eliad@wizery.com>
AuthorDate: Thu Jul 30 22:38:22 2015 +0300
Commit: Kalle Valo <kvalo@codeaurora.org>
CommitDate: Mon Aug 10 22:16:34 2015 +0300
wlcore: add p2p device support
And even that commit didn't use them, no idea why. Just send a patch
removing them, if someone needs them later they can be added again.
--
Kalle Valo
prev parent reply other threads:[~2019-06-14 5:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 18:00 Cleanup of -Wunused-const-variable in drivers/net/wireless/ti/wl18xx/main.c Nathan Huckleberry
2019-06-14 5:25 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874l4slouz.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhuck@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.