From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [RFC PATCH] drm/panfrost: Add initial panfrost driver Date: Wed, 13 Mar 2019 10:56:07 -0700 Message-ID: <874l868xqg.fsf@anholt.net> References: <20190308002408.32682-1-robh@kernel.org> <87h8cdxrck.fsf@anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1954518899==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 94A0489C6C for ; Wed, 13 Mar 2019 17:56:09 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Tomeu Vizoso , Maxime Ripard , dri-devel , David Airlie , "Marty E. Plummer" , Sean Paul , Alyssa Rosenzweig List-Id: dri-devel@lists.freedesktop.org --===============1954518899== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Rob Herring writes: > On Fri, Mar 8, 2019 at 10:29 AM Eric Anholt wrote: >> >> Rob Herring writes: >> >> > From: "Marty E. Plummer" >> > >> > This adds the initial driver for panfrost which supports Arm Mali >> > Midgard and Bifrost family of GPUs. Currently, only the T860 Midgard GPU >> > has been tested. > > [...] > >> It looks like you've got v3d's silliness with the fences -- we reserve a >> shared slot, then use excl only anyway. For v3d I'm planning on moving >> to just excl -- only one of my entrypoints has info on write vs >> read-only, and I don't know of a usecase where having multiple read-only >> consumers of a shared buffer simultaneously matters. >> >> More importantly, I think you also have my bug of not doing implicit >> synchronization on buffers, which will break X11 rendering >> sometimes. X11's GL requirements are that previously-submitted rendering >> by the client fd will execute before X11's rendering on its fd to the >> same buffers. If you're running a single client, X11's copies are cheap >> enough that it'll probably work out most of the time. > > Is there a fix for this? I didn't find anything that looked like one. Missed this part. I'm thinking something like what the lima driver has for implicit sync. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlyJRDcACgkQtdYpNtH8 nujzaw/+LSUHh566Itl7ilV/9ZIgAJMoBuYw26YFwgbosqtvuDK5YN+efKkPBJ/7 Lq/9SAAzhqWZMbDeCGcMjlUsR3fypJ8C4vyLYUzNzoE7Uh2pfoamAXfyvqRBel3u 6ZCMZPp1i12G6zCjUkdTobaBL+Q3CvQn3tUd7b7ua52iSQSwogikslTZF3t/xd6o yuMVvehbhCUJi0KQOKlbRHIHROmNelbwpuoV42/rnl1exxoHbbraHiWK7iQYGBVb jw9m3c6V/Y3e37AarpAxG/7HfAO+75r1yc1zdsEz5j2ApvJByGG/vwH/1wraAwjQ UpAx9L6JhDVAOQImEImaNLwlsIgMjhmV0/8ugQzn7LiXtD5mKKY6WknwAYUJCmZv P4zFL/rvOmOXCtM0KM/WoNz0DIeqmd2pU7r7s40I5E8rzaUjHrTSNAjVDOT4p7pm x4co03o64w77+04CqIEIwawVgAtrVX2W6Sm2SLK1NY0WvsNOVi0QU/jOcCPAAuYH Fa+Vk5ne50NrSXlLPe/uWEG1dIHAXFrpikMKbDzZetRSa0lUJy7yGHlDk2qQzq7u ettReVG6ZQDgmIKvepcUeTPIXGLZJQB6IC84ftW//nST2alyIX8RNjovxLjFxacP z7PC0A2X8r3zflNIjg7+4dZP9XSzXsQruywaZz6d94pwc/lyfKY= =QVt8 -----END PGP SIGNATURE----- --=-=-=-- --===============1954518899== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1954518899==--