From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 2/5] drm/i915/backlight: Fix backlight takeover on LPT, v3. Date: Tue, 22 Jan 2019 19:44:38 +0200 Message-ID: <874la0fuyh.fsf@intel.com> References: <20190108160842.13396-1-maarten.lankhorst@linux.intel.com> <20190108160842.13396-2-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 171D36E3EB for ; Tue, 22 Jan 2019 17:44:25 +0000 (UTC) In-Reply-To: <20190108160842.13396-2-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org Cc: Hans de Goede , Tolga Cakir , Basil Eric Rabi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAwOCBKYW4gMjAxOSwgTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0 QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gbHlueHBvaW50IHRoZSBiaW9zIHNvbWV0aW1l cyBzZXRzIHVwIHRoZSBiYWNrbGlnaHQgdXNpbmcgdGhlIENQVQo+IGRpc3BsYXksIGJ1dCB0aGUg ZHJpdmVyIGV4cGVjdHMgdXNpbmcgdGhlIFBXTSBQQ0ggb3ZlcnJpZGUgcmVnaXN0ZXIuCj4KPiBS ZWFkIHRoZSB2YWx1ZSBmcm9tIHRoZSBDUFUgcmVnaXN0ZXIsIHRoZW4gY29udmVydCBpdCB0byB0 aGUgb3RoZXIKPiB1bml0cyBieSBjb252ZXJ0aW5nIGZyb20gdGhlIG9sZCBkdXR5IGN5Y2xlLCB0 byBmcmVxLCB0byB0aGUgbmV3IHVuaXRzLgo+Cj4gVGhpcyB2YWx1ZSBpcyB0aGVuIHByb2dyYW1t ZWQgaW4gdGhlIG92ZXJyaWRlIHJlZ2lzdGVyLCBhZnRlciB3aGljaAo+IHdlIHNldCB0aGUgb3Zl cnJpZGUgYW5kIGRpc2FibGUgdGhlIENQVSBkaXNwbGF5IGNvbnRyb2wuIFRoaXMgYWxsb3dzCj4g dXMgdG8gc3dpdGNoIHRoZSBzb3VyY2Ugd2l0aG91dCBmbGlja2VyaW5nLCBhbmQgbWFrZSB0aGUg YmFja2xpZ2h0Cj4gY29udHJvbHMgd29yayBpbiB0aGUgZHJpdmVyLgo+Cj4gQ2hhbmdlcyBzaW5j ZSB2MToKPiAtIFJlYWQgQkxDX1BXTV9DUFVfQ1RMMiB0byBjcHVfY3RsMi4KPiAtIENsZWFuIHVw IGNwdV9tb2RlIGlmIHNsaWdodGx5Lgo+IC0gQWx3YXlzIGRpc2FibGUgQkxNX1BXTV9FTkFCTEUg aW4gY3B1X2N0bDIuCj4gQ2hhbmdlcyBzaW5jZSB2MjoKPiAtIFNpbXBsaWZ5IGNwdV9tb2RlIGhh bmRsaW5nIChKYW5pKQo+Cj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0 ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZy ZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MjI1Cj4gQ2M6IEJhc2lsIEVyaWMgUmFi aSA8ZXJpY2Jhc2lsLnJhYmlAZ21haWwuY29tPgo+IENjOiBIYW5zIGRlIEdvZWRlIDxqd3JkZWdv ZWRlQGZlZG9yYXByb2plY3Qub3JnPgo+IENjOiBUb2xnYSBDYWtpciA8Y2V2ZWxuZXRAZ21haWwu Y29tPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+IFRlc3RlZC1ieTogVG9sZ2EgQ2FraXIgPGNldmVsbmV0QGdtYWlsLmNvbT4KPiBDYzogSmFu aSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbT4KClJldmlld2VkLWJ5OiBKYW5p IE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcGFuZWwuYyB8IDI2ICsrKysrKysrKysrKysrKysrKysrKystLS0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4gaW5kZXggZjcxYjMzY2YxYzk3Li4xYzllZjU0ZDU4ZmUg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiBAQCAtMTQ5Myw4ICsxNDkzLDgg QEAgc3RhdGljIGludCBscHRfc2V0dXBfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3Ig KmNvbm5lY3RvciwgZW51bSBwaXBlIHVudXMKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gdG9faTkxNShjb25uZWN0b3ItPmJhc2UuZGV2KTsKPiAgCXN0cnVjdCBp bnRlbF9wYW5lbCAqcGFuZWwgPSAmY29ubmVjdG9yLT5wYW5lbDsKPiAtCXUzMiBwY2hfY3RsMSwg cGNoX2N0bDIsIHZhbDsKPiAtCWJvb2wgYWx0Owo+ICsJdTMyIGNwdV9jdGwyLCBwY2hfY3RsMSwg cGNoX2N0bDIsIHZhbDsKPiArCWJvb2wgYWx0LCBjcHVfbW9kZTsKPiAgCj4gIAlpZiAoSEFTX1BD SF9MUFQoZGV2X3ByaXYpKQo+ICAJCWFsdCA9IEk5MTVfUkVBRChTT1VUSF9DSElDS0VOMikgJiBM UFRfUFdNX0dSQU5VTEFSSVRZOwo+IEBAIC0xNTA4LDYgKzE1MDgsOCBAQCBzdGF0aWMgaW50IGxw dF9zZXR1cF9iYWNrbGlnaHQoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLCBlbnVt IHBpcGUgdW51cwo+ICAJcGNoX2N0bDIgPSBJOTE1X1JFQUQoQkxDX1BXTV9QQ0hfQ1RMMik7Cj4g IAlwYW5lbC0+YmFja2xpZ2h0Lm1heCA9IHBjaF9jdGwyID4+IDE2Owo+ICAKPiArCWNwdV9jdGwy ID0gSTkxNV9SRUFEKEJMQ19QV01fQ1BVX0NUTDIpOwo+ICsKPiAgCWlmICghcGFuZWwtPmJhY2ts aWdodC5tYXgpCj4gIAkJcGFuZWwtPmJhY2tsaWdodC5tYXggPSBnZXRfYmFja2xpZ2h0X21heF92 YnQoY29ubmVjdG9yKTsKPiAgCj4gQEAgLTE1MTYsMTIgKzE1MTgsMjggQEAgc3RhdGljIGludCBs cHRfc2V0dXBfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciwgZW51 bSBwaXBlIHVudXMKPiAgCj4gIAlwYW5lbC0+YmFja2xpZ2h0Lm1pbiA9IGdldF9iYWNrbGlnaHRf bWluX3ZidChjb25uZWN0b3IpOwo+ICAKPiAtCXZhbCA9IGxwdF9nZXRfYmFja2xpZ2h0KGNvbm5l Y3Rvcik7Cj4gKwlwYW5lbC0+YmFja2xpZ2h0LmVuYWJsZWQgPSBwY2hfY3RsMSAmIEJMTV9QQ0hf UFdNX0VOQUJMRTsKPiArCj4gKwljcHVfbW9kZSA9IHBhbmVsLT5iYWNrbGlnaHQuZW5hYmxlZCAm JiBIQVNfUENIX0xQVChkZXZfcHJpdikgJiYKPiArCQkgICAhKHBjaF9jdGwxICYgQkxNX1BDSF9P VkVSUklERV9FTkFCTEUpICYmCj4gKwkJICAgKGNwdV9jdGwyICYgQkxNX1BXTV9FTkFCTEUpOwo+ ICsJaWYgKGNwdV9tb2RlKQo+ICsJCXZhbCA9IHBjaF9nZXRfYmFja2xpZ2h0KGNvbm5lY3Rvcik7 Cj4gKwllbHNlCj4gKwkJdmFsID0gbHB0X2dldF9iYWNrbGlnaHQoY29ubmVjdG9yKTsKPiAgCXZh bCA9IGludGVsX3BhbmVsX2NvbXB1dGVfYnJpZ2h0bmVzcyhjb25uZWN0b3IsIHZhbCk7Cj4gIAlw YW5lbC0+YmFja2xpZ2h0LmxldmVsID0gY2xhbXAodmFsLCBwYW5lbC0+YmFja2xpZ2h0Lm1pbiwK PiAgCQkJCSAgICAgICBwYW5lbC0+YmFja2xpZ2h0Lm1heCk7Cj4gIAo+IC0JcGFuZWwtPmJhY2ts aWdodC5lbmFibGVkID0gcGNoX2N0bDEgJiBCTE1fUENIX1BXTV9FTkFCTEU7Cj4gKwlpZiAoY3B1 X21vZGUpIHsKPiArCQlEUk1fREVCVUdfS01TKCJDUFUgYmFja2xpZ2h0IHJlZ2lzdGVyIHdhcyBl bmFibGVkLCBzd2l0Y2hpbmcgdG8gUENIIG92ZXJyaWRlXG4iKTsKPiArCj4gKwkJLyogV3JpdGUg Y29udmVydGVkIENQVSBQV00gdmFsdWUgdG8gUENIIG92ZXJyaWRlIHJlZ2lzdGVyICovCj4gKwkJ bHB0X3NldF9iYWNrbGlnaHQoY29ubmVjdG9yLT5iYXNlLnN0YXRlLCBwYW5lbC0+YmFja2xpZ2h0 LmxldmVsKTsKPiArCQlJOTE1X1dSSVRFKEJMQ19QV01fUENIX0NUTDEsIHBjaF9jdGwxIHwgQkxN X1BDSF9PVkVSUklERV9FTkFCTEUpOwo+ICsKPiArCQlJOTE1X1dSSVRFKEJMQ19QV01fQ1BVX0NU TDIsIGNwdV9jdGwyICYgfkJMTV9QV01fRU5BQkxFKTsKPiArCX0KPiAgCj4gIAlyZXR1cm4gMDsK PiAgfQoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==