From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Michael Kelley <mikelley@microsoft.com>,
"kvm\@vger.kernel.org" <kvm@vger.kernel.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Roman Kagan" <rkagan@virtuozzo.com>,
"KY Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Stephen Hemminger" <sthemmin@microsoft.com>,
"x86@kernel.org" <x86@kernel.org>,
"Nadav Amit" <nadav.amit@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: RE: [PATCH v2] x86/hyper-v: Mark TLFS structures packed
Date: Mon, 03 Dec 2018 14:45:28 +0100 [thread overview]
Message-ID: <874lbuyb9j.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <CY4PR21MB0773D5DFA13BFA0701771F5ED7AE0@CY4PR21MB0773.namprd21.prod.outlook.com>
Michael Kelley <mikelley@microsoft.com> writes:
> From: Vitaly Kuznetsov <vkuznets@redhat.com> Sent: Friday, November 30, 2018 4:54 AM
>>
>> @@ -466,7 +466,7 @@ union hv_message_flags {
>> struct {
>> __u8 msg_pending:1;
>> __u8 reserved:7;
>> - };
>> + } __packed;
>> };
>>
>> /* Define port identifier type. */
>
> I think __packed is also needed in the definition
> of struct u defined within union hv_port_id. That
> struct has bit fields, so shouldn't it be done just like
> union hv_message_flags above?
>
True, missed it, thanks! Will send v3 out shortly.
--
Vitaly
prev parent reply other threads:[~2018-12-03 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 12:54 [PATCH v2] x86/hyper-v: Mark TLFS structures packed Vitaly Kuznetsov
2018-12-01 6:21 ` Nadav Amit
2018-12-02 23:35 ` Vitaly Kuznetsov
2018-12-03 7:15 ` Roman Kagan
2018-12-03 1:41 ` Michael Kelley
2018-12-03 13:45 ` Vitaly Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lbuyb9j.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=haiyangz@microsoft.com \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=nadav.amit@gmail.com \
--cc=pbonzini@redhat.com \
--cc=rkagan@virtuozzo.com \
--cc=rkrcmar@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.