All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 5/8] docker: Restrict the 'travis' job to the Travis image
Date: Fri, 29 Jun 2018 15:11:34 +0100	[thread overview]
Message-ID: <874lhlvg15.fsf@linaro.org> (raw)
In-Reply-To: <20180628164643.9668-6-f4bug@amsat.org>


Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> We can still run any test in Travis.


I don't know about this one. The travis job isn't a fill in for real
travis, but a way to work through the matrix. I don't think it needs to
be restricted to any particular image.

>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  tests/docker/Makefile.include | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 91d9665517..7d9d568eee 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -99,11 +99,17 @@ docker-image-tricore-cross: docker-image-debian9
>
>  # Expand all the pre-requistes for each docker image and test combination
>  $(foreach i,$(DOCKER_IMAGES) $(DOCKER_DEPRECATED_IMAGES), \
> -	$(foreach t,$(DOCKER_TESTS) $(DOCKER_TOOLS), \
> +	$(foreach t,$(DOCKER_TESTS), \
>  		$(eval .PHONY: docker-$t@$i) \
>  		$(eval docker-$t@$i: docker-image-$i docker-run-$t@$i) \
> +		$(eval docker-test: docker-$t@$i) \
>  	) \
> -	$(foreach t,$(DOCKER_TESTS), \
> +)
> +# we only run Travis tests on the Travis image
> +$(foreach i,travis, \
> +	$(foreach t,$(DOCKER_TOOLS), \
> +		$(eval .PHONY: docker-$t@$i) \
> +		$(eval docker-$t@$i: docker-image-$i docker-run-$t@$i) \
>  		$(eval docker-test: docker-$t@$i) \
>  	) \
>  )


--
Alex Bennée

  reply	other threads:[~2018-06-29 14:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 16:46 [Qemu-devel] [PATCH 0/8] Docker improvements Philippe Mathieu-Daudé
2018-06-28 16:46 ` [Qemu-devel] [PATCH 1/8] docker: ubuntu: Update the package list before installing new ones Philippe Mathieu-Daudé
2018-06-28 16:46 ` [Qemu-devel] [PATCH 2/8] docker: ubuntu: Use SDL2 Philippe Mathieu-Daudé
2018-06-28 16:46 ` [Qemu-devel] [PATCH 3/8] docker: Clean the MXE base image Philippe Mathieu-Daudé
2018-06-28 16:46 ` [Qemu-devel] [RFC PATCH 4/8] docker: Add packages required to build a Linux kernel Philippe Mathieu-Daudé
2018-06-29 14:09   ` Alex Bennée
2018-06-29 14:55     ` Philippe Mathieu-Daudé
2018-06-28 16:46 ` [Qemu-devel] [RFC PATCH 5/8] docker: Restrict the 'travis' job to the Travis image Philippe Mathieu-Daudé
2018-06-29 14:11   ` Alex Bennée [this message]
2018-06-29 15:33     ` Philippe Mathieu-Daudé
2018-06-29 14:22   ` Fam Zheng
2018-06-28 16:46 ` [Qemu-devel] [PATCH 6/8] docker: Do not run tests in 'intermediate' images Philippe Mathieu-Daudé
2018-06-28 16:46 ` [Qemu-devel] [PATCH 7/8] docker: Cross build QEMU on ppc32 hosts Philippe Mathieu-Daudé
2018-06-29 14:29   ` Alex Bennée
2018-06-29 14:53     ` Philippe Mathieu-Daudé
2018-06-29 15:01       ` Alex Bennée
2018-06-28 16:46 ` [Qemu-devel] [PATCH 8/8] .shippable.yml: Restore the powerpc-cross image Philippe Mathieu-Daudé
2018-06-29 14:37 ` [Qemu-devel] [PATCH 0/8] Docker improvements Alex Bennée
2018-06-29 15:34   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lhlvg15.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.