From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: core: introduce per-port over-current counters From: Felipe Balbi Message-Id: <874lmdgk5k.fsf@linux.intel.com> Date: Mon, 19 Feb 2018 15:53:59 +0200 To: Richard Leitner , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, stern@rowland.harvard.edu, linux@roeck-us.net, mathias.nyman@linux.intel.com, johan@kernel.org, ekorenevsky@gmail.com, peter.chen@nxp.com, drake@endlessm.com, joe@perches.com, Richard Leitner List-ID: SGksCgpSaWNoYXJkIExlaXRuZXIgPGRldkBnMGhsMW4ubmV0PiB3cml0ZXM6Cgo+IEZyb206IFJp Y2hhcmQgTGVpdG5lciA8cmljaGFyZC5sZWl0bmVyQHNraWRhdGEuY29tPgo+Cj4gRm9yIHNvbWUg dXNlcnNwYWNlIGFwcGxpY2F0aW9ucyBpbmZvcm1hdGlvbiBvbiB0aGUgbnVtYmVyIG9mCj4gb3Zl ci1jdXJyZW50IGNvbmRpdGlvbnMgYXQgc3BlY2lmaWMgVVNCIGh1YiBwb3J0cyBpcyByZWxldmFu dC4gVGhlcmVmb3JlCj4gaW50cm9kdWNlIGEgb2NfY291bnRlciBpbiB0aGUgdXNiIHBvcnQgc3Ry dWN0IHdoaWNoIGlzIGV4cG9ydGVkIHZpYQo+IHN5c2ZzLgoKcmVsZXZhbnQgaG93PyBXaGF0IGNh biB0aGUgYXBwbGljYXRpb24gZG8gd2l0aCB0aGF0IGtub3dsZWRnZT8KCj4gU2lnbmVkLW9mZi1i eTogUmljaGFyZCBMZWl0bmVyIDxyaWNoYXJkLmxlaXRuZXJAc2tpZGF0YS5jb20+Cj4gLS0tCj4g VGVzdGVkIG9uIGFuIGkuTVg2REwgYmFzZWQgYm9hcmQuCj4gLS0tCj4gIGRyaXZlcnMvdXNiL2Nv cmUvaHViLmMgIHwgIDQgKysrLQo+ICBkcml2ZXJzL3VzYi9jb3JlL2h1Yi5oICB8ICAxICsKPiAg ZHJpdmVycy91c2IvY29yZS9wb3J0LmMgfCAxMCArKysrKysrKysrCj4gIDMgZmlsZXMgY2hhbmdl ZCwgMTQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvdXNiL2NvcmUvaHViLmMgYi9kcml2ZXJzL3VzYi9jb3JlL2h1Yi5jCj4gaW5kZXggYzVjMWY2 Y2YzMjI4Li40NDhmYmExZTE4MjcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2IvY29yZS9odWIu Ywo+ICsrKyBiL2RyaXZlcnMvdXNiL2NvcmUvaHViLmMKPiBAQCAtNTEwNCw4ICs1MTA0LDEwIEBA IHN0YXRpYyB2b2lkIHBvcnRfZXZlbnQoc3RydWN0IHVzYl9odWIgKmh1YiwgaW50IHBvcnQxKQo+ ICAKPiAgCWlmIChwb3J0Y2hhbmdlICYgVVNCX1BPUlRfU1RBVF9DX09WRVJDVVJSRU5UKSB7Cj4g IAkJdTE2IHN0YXR1cyA9IDAsIHVudXNlZDsKPiArCQlwb3J0X2Rldi0+b2NfY291bnQrKzsKPiAg Cj4gLQkJZGV2X2RiZygmcG9ydF9kZXYtPmRldiwgIm92ZXItY3VycmVudCBjaGFuZ2VcbiIpOwo+ ICsJCWRldl9kYmcoJnBvcnRfZGV2LT5kZXYsICJvdmVyLWN1cnJlbnQgY2hhbmdlICMldVxuIiwK PiArCQkJcG9ydF9kZXYtPm9jX2NvdW50KTsKPiAgCQl1c2JfY2xlYXJfcG9ydF9mZWF0dXJlKGhk ZXYsIHBvcnQxLAo+ICAJCQkJVVNCX1BPUlRfRkVBVF9DX09WRVJfQ1VSUkVOVCk7Cj4gIAkJbXNs ZWVwKDEwMCk7CS8qIENvb2wgZG93biAqLwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9jb3Jl L2h1Yi5oIGIvZHJpdmVycy91c2IvY29yZS9odWIuaAo+IGluZGV4IDJhNzAwY2NjODY4Yy4uYjVj ZjU2N2JmOWUyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdXNiL2NvcmUvaHViLmgKPiArKysgYi9k cml2ZXJzL3VzYi9jb3JlL2h1Yi5oCj4gQEAgLTEwMCw2ICsxMDAsNyBAQCBzdHJ1Y3QgdXNiX3Bv cnQgewo+ICAJdW5zaWduZWQgaW50IGlzX3N1cGVyc3BlZWQ6MTsKPiAgCXVuc2lnbmVkIGludCB1 c2IzX2xwbV91MV9wZXJtaXQ6MTsKPiAgCXVuc2lnbmVkIGludCB1c2IzX2xwbV91Ml9wZXJtaXQ6 MTsKPiArCXVuc2lnbmVkIGludCBvY19jb3VudDsKPiAgfTsKPiAgCj4gICNkZWZpbmUgdG9fdXNi X3BvcnQoX2RldikgXAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9jb3JlL3BvcnQuYyBiL2Ry aXZlcnMvdXNiL2NvcmUvcG9ydC5jCj4gaW5kZXggMWEwMWU5YWQzODA0Li4wYmZlNDEwZWI4YTcg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2IvY29yZS9wb3J0LmMKPiArKysgYi9kcml2ZXJzL3Vz Yi9jb3JlL3BvcnQuYwo+IEBAIC00MSw2ICs0MSwxNSBAQCBzdGF0aWMgc3NpemVfdCBjb25uZWN0 X3R5cGVfc2hvdyhzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gIH0KPiAgc3RhdGljIERFVklDRV9BVFRS X1JPKGNvbm5lY3RfdHlwZSk7Cj4gIAo+ICtzdGF0aWMgc3NpemVfdCBvY19jb3VudF9zaG93KHN0 cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9hdHRyaWJ1dGUgKmF0dHIsCj4gKwkJCSAg ICAgY2hhciAqYnVmKQo+ICt7Cj4gKwlzdHJ1Y3QgdXNiX3BvcnQgKnBvcnRfZGV2ID0gdG9fdXNi X3BvcnQoZGV2KTsKPiArCj4gKwlyZXR1cm4gc3ByaW50ZihidWYsICIldVxuIiwgcG9ydF9kZXYt Pm9jX2NvdW50KTsKPiArfQo+ICtzdGF0aWMgREVWSUNFX0FUVFJfUk8ob2NfY291bnQpOwoKSSB3 b3VsZCBhY3R1YWxseSBzcGVsbCB0aGlzIG91dCBodW1hbiByZWFkYWJsZTogb3Zlcl9jdXJyZW50 X2NvdW50Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-177322-1519048495-2-133984629075624521 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1519048494; b=CQersDe6erbqyLYSHw7YiIor+MULcnneo0LOb13yt7raxvD EXNbyMAvd0bxjQBS88Q0ZmquxcQvJ0mjmhOshyaianQiw6BeOz+UIXstmY5IDilJ CrMHGxbD9+G8JzcwV+PbYR47q2fRg8t2ov/PiB+5oh6xP4N9RWD+xX35ilr1Dceh EIkJXC6uxEvfcxGHl93jMs50oo/qQs7GnzvjKcg/z6o2Mho1LI2AWG5KGcAI4jZ9 1PHx0PtHM2Y2PBh0DOYxnwXzuZsImKCp1kS/nurCn+G+QfW/nXwmyyfndpCRq6Jv /tlxEHxzWUWRNMpavlU78NljOye06foRlIl+dqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:in-reply-to:references :date:message-id:mime-version:content-type:sender:list-id; s= arctest; t=1519048494; bh=5GvhXDWgQyDDNCw4bP0jo+UA1iUJpnQmDyiRHu ZdBXU=; b=bFtqFR0h0KpuZZn8bDae2oqB+Mtf+KSeZLRkW3075s1k8BoefBAoQH MC34hT5uUzy6LVAhl+lDC3WCGympGJ4GdJi4t30KhtZPjJgVRZ13NiwgrofZ+9tr oXvEEaZP0kim9lYVfMymfcP0CabdAGsOcLQRA7BX/sB+doXmedDNOrhrZDCzfXqM sXMFpq8+fz/dPZDFVZpQVuBg7xL14p6wEeI0eDWaEs9Xxoq13t1B6FPi5BaxVZv3 lDrpQ61GLVz8857wpEFWmaVfe+S5Wxg3/3jFZctBjB6nFJouSl8jTz9o4G/cuBU9 0ifZl1TghOOuUnV/uwqxD02tjGgtl+ow== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linux.intel.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linux.intel.com header.result=pass header_org.domain=intel.com header_org.result=pass header_is_org_domain=no Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linux.intel.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linux.intel.com header.result=pass header_org.domain=intel.com header_org.result=pass header_is_org_domain=no Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752805AbeBSNyk (ORCPT ); Mon, 19 Feb 2018 08:54:40 -0500 Received: from mga04.intel.com ([192.55.52.120]:42124 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752666AbeBSNyk (ORCPT ); Mon, 19 Feb 2018 08:54:40 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,535,1511856000"; d="scan'208";a="29115765" From: Felipe Balbi To: Richard Leitner , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, stern@rowland.harvard.edu, linux@roeck-us.net, mathias.nyman@linux.intel.com, johan@kernel.org, ekorenevsky@gmail.com, peter.chen@nxp.com, drake@endlessm.com, joe@perches.com, Richard Leitner Subject: Re: [PATCH] usb: core: introduce per-port over-current counters In-Reply-To: <20180219120107.20434-1-dev@g0hl1n.net> References: <20180219120107.20434-1-dev@g0hl1n.net> Date: Mon, 19 Feb 2018 15:53:59 +0200 Message-ID: <874lmdgk5k.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi, Richard Leitner writes: > From: Richard Leitner > > For some userspace applications information on the number of > over-current conditions at specific USB hub ports is relevant. Therefore > introduce a oc_counter in the usb port struct which is exported via > sysfs. relevant how? What can the application do with that knowledge? > Signed-off-by: Richard Leitner > --- > Tested on an i.MX6DL based board. > --- > drivers/usb/core/hub.c | 4 +++- > drivers/usb/core/hub.h | 1 + > drivers/usb/core/port.c | 10 ++++++++++ > 3 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > index c5c1f6cf3228..448fba1e1827 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -5104,8 +5104,10 @@ static void port_event(struct usb_hub *hub, int port1) > > if (portchange & USB_PORT_STAT_C_OVERCURRENT) { > u16 status = 0, unused; > + port_dev->oc_count++; > > - dev_dbg(&port_dev->dev, "over-current change\n"); > + dev_dbg(&port_dev->dev, "over-current change #%u\n", > + port_dev->oc_count); > usb_clear_port_feature(hdev, port1, > USB_PORT_FEAT_C_OVER_CURRENT); > msleep(100); /* Cool down */ > diff --git a/drivers/usb/core/hub.h b/drivers/usb/core/hub.h > index 2a700ccc868c..b5cf567bf9e2 100644 > --- a/drivers/usb/core/hub.h > +++ b/drivers/usb/core/hub.h > @@ -100,6 +100,7 @@ struct usb_port { > unsigned int is_superspeed:1; > unsigned int usb3_lpm_u1_permit:1; > unsigned int usb3_lpm_u2_permit:1; > + unsigned int oc_count; > }; > > #define to_usb_port(_dev) \ > diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c > index 1a01e9ad3804..0bfe410eb8a7 100644 > --- a/drivers/usb/core/port.c > +++ b/drivers/usb/core/port.c > @@ -41,6 +41,15 @@ static ssize_t connect_type_show(struct device *dev, > } > static DEVICE_ATTR_RO(connect_type); > > +static ssize_t oc_count_show(struct device *dev, struct device_attribute *attr, > + char *buf) > +{ > + struct usb_port *port_dev = to_usb_port(dev); > + > + return sprintf(buf, "%u\n", port_dev->oc_count); > +} > +static DEVICE_ATTR_RO(oc_count); I would actually spell this out human readable: over_current_count -- balbi