All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Include the global reset count for intel_engine_dump()
Date: Mon, 30 Oct 2017 13:55:39 +0200	[thread overview]
Message-ID: <874lqgg890.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20171027173652.11443-2-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Since a global reset affects the engine, include that along side the
> per-engine reset counter when pretty printing the engine state in
> intel_engine_dump().
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_engine_cs.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index a8ea27bea171..6a06d74d70cc 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1702,8 +1702,9 @@ void intel_engine_dump(struct intel_engine_cs *engine, struct drm_printer *m)
>  		   engine->hangcheck.seqno,
>  		   jiffies_to_msecs(jiffies - engine->hangcheck.action_timestamp),
>  		   engine->timeline->inflight_seqnos);
> -	drm_printf(m, "\tReset count: %d\n",
> -		   i915_reset_engine_count(error, engine));
> +	drm_printf(m, "\tReset count: %d (global %d)\n",
> +		   i915_reset_engine_count(error, engine),
> +		   i915_reset_count(error));
>  
>  	rcu_read_lock();
>  
> -- 
> 2.15.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-10-30 11:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27 17:36 [PATCH 1/2] drm/i915: Add is-wedged flag to intel_engine_dump() Chris Wilson
2017-10-27 17:36 ` [PATCH 2/2] drm/i915: Include the global reset count for intel_engine_dump() Chris Wilson
2017-10-30 11:55   ` Mika Kuoppala [this message]
2017-10-27 18:15 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Add is-wedged flag to intel_engine_dump() Patchwork
2017-10-30 11:43 ` [PATCH 1/2] " Mika Kuoppala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lqgg890.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.