From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH] drm/i915: add register macro definition
	style guide
Date: Tue, 08 Aug 2017 11:31:05 +0300
Message-ID: <874ltifol2.fsf@nikula.org>
References: <20170804103836.17629-1-jani.nikula@intel.com>
 <20170807161014.oxduk55k64ow6yiy@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id D6FBD89CA0
 for <intel-gfx@lists.freedesktop.org>; Tue,  8 Aug 2017 08:26:11 +0000 (UTC)
In-Reply-To: <20170807161014.oxduk55k64ow6yiy@phenom.ffwll.local>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCAwNyBBdWcgMjAxNywgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90
ZToKPiBPbiBGcmksIEF1ZyAwNCwgMjAxNyBhdCAwMTozODozNlBNICswMzAwLCBKYW5pIE5pa3Vs
YSB3cm90ZToKPj4gVGhpcyBpcyBub3QgdG8gdHJ5IHRvIGZvcmNlIGEgbmV3IHN0eWxlOyB0aGlz
IGlzIG15IGludGVycHJldGF0aW9uIG9mCj4+IHdoYXQgdGhlIG1vc3QgY29tbW9uIGV4aXN0aW5n
IHN0eWxlIGlzLgo+PiAKPj4gV2l0aCBob3BlcyBJIGRvbid0IG5lZWQgdG8gYW5zd2VyIHNvIG1h
bnkgcXVlc3Rpb25zIGFib3V0IHN0eWxlIGdvaW5nCj4+IGZvcndhcmQuCj4+IAo+PiBDYzogRGFu
aWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPj4gU2lnbmVkLW9mZi1ieTogSmFu
aSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4gCj4+IC0tLQo+PiAKPj4gTi5iLiBv
bmx5IHRoZSAqaW50ZXJwcmV0YXRpb24qIG9mIHRoZSBleGlzdGluZyBzdHlsZSBpcyB1cCBmb3Ig
ZGViYXRlCj4+IGhlcmUuIFByb3Bvc2FscyB0byAqY2hhbmdlKiB0aGUgc3R5bGUgZ29pbmcgZm9y
d2FyZCBjYW4gYmUgZG9uZSBpbiBvdGhlcgo+PiBwYXRjaGVzIGNoYW5naW5nIHRoaXMgZGVzY3Jp
cHRpb24uIEhvd2V2ZXIsIEkgZG91YnQgdGhlIHVzZWZ1bG5lc3Mgb2YKPj4gc3VjaCBjaGFuZ2Vz
LCB3aXRoIHRoZSBwb3NzaWJsZSBleGNlcHRpb24gb2YgcHJvbW90aW5nIHRoZSB1c2Ugb2YgQklU
KCkuCj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCB8IDc3ICsrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4+ICAxIGZpbGUgY2hhbmdlZCwg
NzcgaW5zZXJ0aW9ucygrKQo+PiAKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4+IGluZGV4IGIy
NTQ2YWRlMmM0NS4uMzI0Y2YwNGQ2YmZlIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pOTE1X3JlZy5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgK
Pj4gQEAgLTI1LDYgKzI1LDgzIEBACj4+ICAjaWZuZGVmIF9JOTE1X1JFR19IXwo+PiAgI2RlZmlu
ZSBfSTkxNV9SRUdfSF8KPj4gIAo+PiArLyoKPgo+IERPQzogc2VjdGlvbiwgcGx1cyBwdWxsIGl0
IGludG8gb3VyIGtlcm5lbGRvYz8KCkknbSBjb25mdXNlZCBhYm91dCB3aGF0IHlvdSB0aGluayB3
ZSBzaG91bGQgYW5kIHNob3VsZCBub3QgaW5jbHVkZSBpbgp0aGUgc3BoaW54IGRvY3MuIEkndmUg
c2VlbiB5b3UgcmVtb3ZlIGEgYnVuY2ggb2YgZG9jdW1lbnRhdGlvbiBmb3IgaTkxNQppbnRlcm5h
bCBmdW5jdGlvbnMgdGhhdCBJIHRob3VnaHQgd2VyZSB1c2VmdWwsIGFuZCB5b3Ugc2FpZCB3ZXJl
bid0Cm5lZWRlZCBiZWNhdXNlIHRoZXkgd2VyZSBpbnRlcm5hbC4gQW5kIGhlcmUgSSB0aG91Z2h0
IG5vYm9keSBuZWVkcyB0bwpyZWFkIHRoaXMgdW50aWwgdGhleSdyZSBhYm91dCBlZGl0IHRoZSBm
aWxlLiBTbyBJIHRob3VnaHQgYWJvdXQgdGhpcyBhbmQKb3B0ZWQgYWdhaW5zdC4KCj4KPj4gKyAq
IFRoZSBpOTE1IHJlZ2lzdGVyIG1hY3JvIGRlZmluaXRpb24gc3R5bGUgZ3VpZGUuCj4+ICsgKgo+
PiArICogRm9sbG93IHRoZSBzdHlsZSBkZXNjcmliZWQgaGVyZSBmb3IgbmV3IG1hY3JvcywgYW5k
IHdoaWxlIGNoYW5naW5nIGV4aXN0aW5nCj4+ICsgKiBtYWNyb3MuIERvIG5vdCBtYXNzIGNoYW5n
ZSBleGlzdGluZyBkZWZpbml0aW9ucyBqdXN0IHRvIHVwZGF0ZSB0aGUgc3R5bGUuCj4+ICsgKgo+
PiArICogTEFZT1VUCj4+ICsgKgo+PiArICogS2VlcCBoZWxwZXIgbWFjcm9zIG5lYXIgdGhlIHRv
cC4gRm9yIGV4YW1wbGUsIF9QSVBFKCkgYW5kIGZyaWVuZHMuCj4+ICsgKgo+PiArICogUHJlZml4
IG1hY3JvcyB0aGF0IGdlbmVyYWxseSBzaG91bGQgbm90IGJlIHVzZWQgb3V0c2lkZSBvZiB0aGlz
IGZpbGUgd2l0aAo+PiArICogdW5kZXJzY29yZSAnXycuIEZvciBleGFtcGxlLCBfUElQRSgpIGFu
ZCBmcmllbmRzLCBzaW5nbGUgaW5zdGFuY2VzIG9mCj4+ICsgKiByZWdpc3RlcnMgdGhhdCBhcmUg
ZGVmaW5lZCBzb2xlbHkgZm9yIHRoZSB1c2UgYnkgZnVuY3Rpb24tbGlrZSBtYWNyb3MuCj4+ICsg
Kgo+PiArICogQXZvaWQgdXNpbmcgdGhlIHVuZGVyc2NvcmUgcHJlZml4ZWQgbWFjcm9zIG91dHNp
ZGUgb2YgdGhpcyBmaWxlLiBUaGVyZSBhcmUKPj4gKyAqIGV4Y2VwdGlvbnMsIGJ1dCBrZWVwIHRo
ZW0gdG8gYSBtaW5pbXVtLgo+PiArICoKPj4gKyAqIFRoZXJlIGFyZSB0d28gYmFzaWMgdHlwZXMg
b2YgcmVnaXN0ZXIgZGVmaW5pdGlvbnM6IFNpbmdsZSByZWdpc3RlcnMgYW5kCj4+ICsgKiByZWdp
c3RlciBncm91cHMuIFJlZ2lzdGVyIGdyb3VwcyBhcmUgcmVnaXN0ZXJzIHdoaWNoIGhhdmUgdHdv
IG9yIG1vcmUKPj4gKyAqIGluc3RhbmNlcywgZm9yIGV4YW1wbGUgb25lIHBlciBwaXBlLCBwb3J0
LCB0cmFuc2NvZGVyLCBldGMuIFJlZ2lzdGVyIGdyb3Vwcwo+PiArICogc2hvdWxkIGJlIGRlZmlu
ZWQgdXNpbmcgZnVuY3Rpb24tbGlrZSBtYWNyb3MuCj4+ICsgKgo+PiArICogRm9yIHNpbmdsZSBy
ZWdpc3RlcnMsIGRlZmluZSB0aGUgcmVnaXN0ZXIgb2Zmc2V0IGZpcnN0LCBmb2xsb3dlZCBieSBy
ZWdpc3Rlcgo+PiArICogY29udGVudHMuCj4+ICsgKgo+PiArICogRm9yIHJlZ2lzdGVyIGdyb3Vw
cywgZGVmaW5lIHRoZSByZWdpc3RlciBpbnN0YW5jZSBvZmZzZXRzIGZpcnN0LCBwcmVmaXhlZAo+
PiArICogd2l0aCB1bmRlcnNjb3JlLCBmb2xsb3dlZCBieSBhIGZ1bmN0aW9uLWxpa2UgbWFjcm8g
Y2hvb3NpbmcgdGhlIHJpZ2h0Cj4+ICsgKiBpbnN0YW5jZSBiYXNlZCBvbiB0aGUgcGFyYW1ldGVy
LCBmb2xsb3dlZCBieSByZWdpc3RlciBjb250ZW50cy4KPj4gKyAqCj4+ICsgKiBEZWZpbmUgdGhl
IHJlZ2lzdGVyIGNvbnRlbnRzIGZyb20gbW9zdCBzaWduaWZpY2FudCB0byBsZWFzdCBzaWduaWZp
Y2FudAo+PiArICogYml0LiBJbmRlbnQgdGhlIGJpdCBhbmQgYml0IGZpZWxkIG1hY3JvcyB1c2lu
ZyB0d28gZXh0cmEgc3BhY2VzIGJldHdlZW4KPj4gKyAqICNkZWZpbmUgYW5kIHRoZSBtYWNybyBu
YW1lLgo+Cj4gTWF5YmUgbm90ZSB0aGF0IHNpbmNlIGh3IGVuZ2luZWVycyBsb3ZlIHRvIHVzZSBi
aXQgMzEgZm9yIGVuYWJsaW5nIGEgYmxvY2sKPiB0aGlzIGdpdmVzIHNvbWUgbmF0dXJhbCBvcmRl
cmluZy4KPgo+PiArICoKPj4gKyAqIEZvciBiaXQgZmllbGRzLCBkZWZpbmUgYSBfTUFTSyBhbmQg
YSBfU0hJRlQgbWFjcm8uIERlZmluZSBiaXQgZmllbGQgY29udGVudHMKPj4gKyAqIHNvIHRoYXQg
dGhleSBhcmUgYWxyZWFkeSBzaGlmdGVkIGluIHBsYWNlLCBhbmQgY2FuIGJlIGRpcmVjdGx5IE9S
J2QuIEZvcgo+PiArICogY29udmVuaWVuY2UsIGZ1bmN0aW9uLWxpa2UgbWFjcm9zIG1heSBiZSB1
c2VkIHRvIGRlZmluZSBiaXQgZmllbGRzLCBidXQgZG8KPj4gKyAqIG5vdGUgdGhhdCB0aGUgbWFj
cm9zIG1heSBiZSBuZWVkZWQgdG8gcmVhZCBhcyB3ZWxsIGFzIHdyaXRlIHRoZSByZWdpc3Rlcgo+
PiArICogY29udGVudHMuCj4+ICsgKgo+PiArICogRGVmaW5lIGJpdHMgdXNpbmcgKDEgPDwgTikg
aW5zdGVhZCBvZiBCSVQoTikuIFdlIG1heSBjaGFuZ2UgdGhpcyBpbiB0aGUKPj4gKyAqIGZ1dHVy
ZSwgYnV0IHRoaXMgaXMgdGhlIHByZXZhaWxpbmcgc3R5bGUuCj4+ICsgKgo+PiArICogR3JvdXAg
dGhlIHJlZ2lzdGVyIGFuZCBpdHMgY29udGVudHMgdG9nZXRoZXIgd2l0aG91dCBibGFuayBsaW5l
cywgc2VwYXJhdGUKPj4gKyAqIGZyb20gb3RoZXIgcmVnaXN0ZXJzIGFuZCB0aGVpciBjb250ZW50
cyB3aXRoIG9uZSBibGFuayBsaW5lLgo+PiArICoKPj4gKyAqIEluZGVudCBtYWNybyB2YWx1ZXMg
ZnJvbSBtYWNybyBuYW1lcyB1c2luZyBUQUJzLiBVc2UgYnJhY2VzIGluIG1hY3JvIHZhbHVlcwo+
PiArICogYXMgbmVlZGVkIHRvIGF2b2lkIHVuaW50ZW5kZWQgcHJlY2VkZW5jZSBhZnRlciBtYWNy
byBzdWJzdGl0dXRpb24uIFVzZSBzcGFjZXMKPj4gKyAqIGluIG1hY3JvIHZhbHVlcyBhY2NvcmRp
bmcgdG8ga2VybmVsIGNvZGluZyBzdHlsZS4gVXNlIGxvd2VyIGNhc2UgaW4KPj4gKyAqIGhleGFk
ZWNpbWFsIHZhbHVlcy4KPgo+IEkgdGhpbmsgd2Ugc2hvdWxkIGFkZDoKPgo+ICJJbmRlbnQgcmVn
aXN0ZXIgY29udGVudHMgbWFjcm9zIGJ5IGFuIGFkZGl0aW9uYWwgc3BhY2UsIHRvIHNldCB0aGVt
IG9mZgo+IGZyb20gdGhlIHJlZ2lzdGVyIHRoZXkgYXJlIGZvci4iCj4KPiBGZWVsIGZyZWUgdG8g
cmV3b3JkL3BsYWNlIG1vcmUgc3VpdGFibHkuCgpJIGFscmVhZHkgaGF2ZSB0aGlzIHRoZXJlOiAi
SW5kZW50IHRoZSBiaXQgYW5kIGJpdCBmaWVsZCBtYWNyb3MgdXNpbmcKdHdvIGV4dHJhIHNwYWNl
cyBiZXR3ZWVuICNkZWZpbmUgYW5kIHRoZSBtYWNybyBuYW1lLiIKCj4+ICsgKgo+PiArICogTkFN
SU5HCj4+ICsgKgo+PiArICogVHJ5IHRvIG5hbWUgcmVnaXN0ZXJzIGFjY29yZGluZyB0byB0aGUg
c3BlY3MuIElmIHRoZSByZWdpc3RlciBuYW1lIGNoYW5nZXMgaW4KPj4gKyAqIHRoZSBzcGVjcyBm
cm9tIHBsYXRmb3JtIHRvIGFub3RoZXIsIHN0aWNrIHRvIHRoZSBvcmlnaW5hbCBuYW1lLgo+PiAr
ICoKPj4gKyAqIFRyeSB0byByZS11c2UgZXhpc3RpbmcgcmVnaXN0ZXIgbWFjcm8gZGVmaW5pdGlv
bnMuIE9ubHkgYWRkIG5ldyBtYWNyb3MgZm9yCj4+ICsgKiBuZXcgcmVnaXN0ZXIgb2Zmc2V0cywg
b3Igd2hlbiB0aGUgcmVnaXN0ZXIgY29udGVudHMgaGF2ZSBjaGFuZ2VkIGVub3VnaCB0bwo+PiAr
ICogd2FycmFudCBhIGZ1bGwgcmVkZWZpbml0aW9uLgo+PiArICoKPj4gKyAqIFdoZW4gYSByZWdp
c3RlciBvciBhIGJpdCAoZmllbGQpIGNoYW5nZXMgZm9yIGEgbmV3IHBsYXRmb3JtLCBwcmVmaXgg
dGhlIG5ldwo+PiArICogbWFjcm8gdXNpbmcgdGhlIHBsYXRmb3JtIGFjcm9ueW0gb3IgZ2VuZXJh
dGlvbi4gRm9yIGV4YW1wbGUsIFNLTF8gb3IKPj4gKyAqIEdFTjhfLiBUaGUgcHJlZml4IHNpZ25p
ZmllcyB0aGUgc3RhcnQgcGxhdGZvcm0vZ2VuZXJhdGlvbiBvZiB0aGUgcmVnaXN0ZXIuCj4KPiBz
L29mL3VzaW5nLwo+Cj4gTm90ZSB0aGF0IHdlIGFsc28gaGF2ZSBwaWxlcyBvZiByZWdpc3RlciBk
ZWZpbml0aW9ucyB1c2luZyBwbGF0Zm9ybQo+IHBvc3RmaXguIFRoYXQgdGVuZHMgdG8gYmUgdXNl
ZCB3aGVuIHdlIGhhdmUgYW4gZXh0ZW5zaW9uIG9mIGFuIGV4aXN0aW5nCj4gcmVnaXN0ZXIgKGku
ZS4gZm9yIG5ldyBiaXQgdmFsdWVzKSwgaW5zdGVhZCBvZiBhIGNvbXBsZXRlbHkgbmV3IHJlZ2lz
dGVyCj4gc2V0Lgo+Cj4gU2luY2UgeW91IHdhbnQgdG8ganVzdCBkZXNjcmliZSB0aGUgY3VycmVu
dCBzdHlsZSBJIHRoaW5rIHRoaXMgc2hvdWxkIGJlCj4gYWRkZWQuCgpZZWFoLCBtYXliZS4gUGFy
dCBvZiB0aGUgcmVhc29uIEkgc3RhcnRlZCB0aGlzLiBCdXQgSSBkaWRuJ3QgdGhpbmsgaXQKd2Fz
IGNvbW1vbiBlbm91Z2ggd29ydGggbWVudGlvbmluZywgYW5kIEkgd2Fzbid0IHJlYWxseSBzdXJl
IHdoYXQgdGhlCnJ1bGUgd2FzLi4uIFJlZ2lzdGVycyBwcmVmaXhlZCwgY29udGVudHMgcG9zdGZp
eGVkPyBVZ2guCgpCUiwKSmFuaS4KCj4gSSdsbCBsZWF2ZSB0aGUgbml0cyB0byB5b3VyIGp1ZGdl
bWVudCwgYnV0IGltbyB0aGUga2VybmVsZG9jIERPQzogc2VjdGlvbgo+IHNob3VsZCBiZSBkb25l
LiBXaXRoIHRoYXQ6Cj4KPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRl
ckBmZndsbC5jaD4KPgo+PiArICoKPj4gKyAqIEVYQU1QTEUKPj4gKyAqCj4+ICsgKiAjZGVmaW5l
IF9GT09fQQkJCTB4ZjAwMAo+PiArICogI2RlZmluZSBfRk9PX0IJCQkweGYwMDEKPj4gKyAqICNk
ZWZpbmUgRk9PKHBpcGUpCQkJX01NSU9fUElQRShwaXBlLCBfRk9PX0EsIF9GT09fQikKPj4gKyAq
ICNkZWZpbmUgICBGT09fRU5BQkxFCQkJKDEgPDwgMzEpCj4+ICsgKiAjZGVmaW5lICAgRk9PX01P
REVfTUFTSwkJKDB4ZiA8PCAxNikKPj4gKyAqICNkZWZpbmUgICBGT09fTU9ERV9TSElGVAkJMTYK
Pj4gKyAqICNkZWZpbmUgICBGT09fTU9ERV9CQVIJCSgwIDw8IDE2KQo+PiArICogI2RlZmluZSAg
IEZPT19NT0RFX0JBWgkJKDEgPDwgMTYpCj4+ICsgKiAjZGVmaW5lICAgR0VONl9GT09fTU9ERV9R
VVgJCSgyIDw8IDE2KQo+PiArICoKPj4gKyAqLwo+PiArCj4+ICB0eXBlZGVmIHN0cnVjdCB7Cj4+
ICAJdWludDMyX3QgcmVnOwo+PiAgfSBpOTE1X3JlZ190Owo+PiAtLSAKPj4gMi4xMS4wCj4+IAoK
LS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp
bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m
cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK