From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Fri, 19 May 2017 12:03:31 +0000 Subject: Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Message-Id: <874lwhoxyk.fsf@intel.com> List-Id: References: <20170519110203.19417-1-colin.king@canonical.com> In-Reply-To: <20170519110203.19417-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , Tom Cooksey , Eric Anholt , David Airlie , dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, 19 May 2017, Colin King wrote: > From: Colin Ian King > > structure pl111_display_funcs can be made static as it does not need to be > in global scope. Fixes sparse warning: > > "warning: symbol 'pl111_display_funcs' was not declared. Should it > be static?" > > Fixes: bed41005e6174d ("drm/pl111: Initial drm/kms driver for pl111") The patch looks good and I appreciate what you're doing, but I question the usefulness of adding Fixes: tags for trivial stuff like this. I'd prefer Fixes: was reserved for actual fixes that should be backported to any kernels that have the commit being fixed. The same applies to many other patches you've sent recently. BR, Jani. > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/pl111/pl111_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c > index 39a5c33bce7d..bd8ff82c2fd9 100644 > --- a/drivers/gpu/drm/pl111/pl111_display.c > +++ b/drivers/gpu/drm/pl111/pl111_display.c > @@ -280,7 +280,7 @@ static int pl111_display_prepare_fb(struct drm_simple_display_pipe *pipe, > return drm_fb_cma_prepare_fb(&pipe->plane, plane_state); > } > > -const struct drm_simple_display_pipe_funcs pl111_display_funcs = { > +static const struct drm_simple_display_pipe_funcs pl111_display_funcs = { > .check = pl111_display_check, > .enable = pl111_display_enable, > .disable = pl111_display_disable, -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Date: Fri, 19 May 2017 15:03:31 +0300 Message-ID: <874lwhoxyk.fsf@intel.com> References: <20170519110203.19417-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF7E46E6B7 for ; Fri, 19 May 2017 12:00:05 +0000 (UTC) In-Reply-To: <20170519110203.19417-1-colin.king@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Colin King , Tom Cooksey , Eric Anholt , David Airlie , dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAxOSBNYXkgMjAxNywgQ29saW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29t PiB3cm90ZToKPiBGcm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29t Pgo+Cj4gc3RydWN0dXJlIHBsMTExX2Rpc3BsYXlfZnVuY3MgY2FuIGJlIG1hZGUgc3RhdGljIGFz IGl0IGRvZXMgbm90IG5lZWQgdG8gYmUKPiBpbiBnbG9iYWwgc2NvcGUuICBGaXhlcyBzcGFyc2Ug d2FybmluZzoKPgo+ICJ3YXJuaW5nOiBzeW1ib2wgJ3BsMTExX2Rpc3BsYXlfZnVuY3MnIHdhcyBu b3QgZGVjbGFyZWQuIFNob3VsZCBpdAo+IGJlIHN0YXRpYz8iCj4KPiBGaXhlczogYmVkNDEwMDVl NjE3NGQgKCJkcm0vcGwxMTE6IEluaXRpYWwgZHJtL2ttcyBkcml2ZXIgZm9yIHBsMTExIikKClRo ZSBwYXRjaCBsb29rcyBnb29kIGFuZCBJIGFwcHJlY2lhdGUgd2hhdCB5b3UncmUgZG9pbmcsIGJ1 dCBJIHF1ZXN0aW9uCnRoZSB1c2VmdWxuZXNzIG9mIGFkZGluZyBGaXhlczogdGFncyBmb3IgdHJp dmlhbCBzdHVmZiBsaWtlIHRoaXMuIEknZApwcmVmZXIgRml4ZXM6IHdhcyByZXNlcnZlZCBmb3Ig YWN0dWFsIGZpeGVzIHRoYXQgc2hvdWxkIGJlIGJhY2twb3J0ZWQgdG8KYW55IGtlcm5lbHMgdGhh dCBoYXZlIHRoZSBjb21taXQgYmVpbmcgZml4ZWQuCgpUaGUgc2FtZSBhcHBsaWVzIHRvIG1hbnkg b3RoZXIgcGF0Y2hlcyB5b3UndmUgc2VudCByZWNlbnRseS4KCkJSLApKYW5pLgoKPiBTaWduZWQt b2ZmLWJ5OiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vcGwxMTEvcGwxMTFfZGlzcGxheS5jIHwgMiArLQo+ICAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vcGwxMTEvcGwxMTFfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL3Bs MTExL3BsMTExX2Rpc3BsYXkuYwo+IGluZGV4IDM5YTVjMzNiY2U3ZC4uYmQ4ZmY4MmMyZmQ5IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9wbDExMS9wbDExMV9kaXNwbGF5LmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vcGwxMTEvcGwxMTFfZGlzcGxheS5jCj4gQEAgLTI4MCw3ICsyODAs NyBAQCBzdGF0aWMgaW50IHBsMTExX2Rpc3BsYXlfcHJlcGFyZV9mYihzdHJ1Y3QgZHJtX3NpbXBs ZV9kaXNwbGF5X3BpcGUgKnBpcGUsCj4gIAlyZXR1cm4gZHJtX2ZiX2NtYV9wcmVwYXJlX2ZiKCZw aXBlLT5wbGFuZSwgcGxhbmVfc3RhdGUpOwo+ICB9Cj4gIAo+IC1jb25zdCBzdHJ1Y3QgZHJtX3Np bXBsZV9kaXNwbGF5X3BpcGVfZnVuY3MgcGwxMTFfZGlzcGxheV9mdW5jcyA9IHsKPiArc3RhdGlj IGNvbnN0IHN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZV9mdW5jcyBwbDExMV9kaXNwbGF5 X2Z1bmNzID0gewo+ICAJLmNoZWNrID0gcGwxMTFfZGlzcGxheV9jaGVjaywKPiAgCS5lbmFibGUg PSBwbDExMV9kaXNwbGF5X2VuYWJsZSwKPiAgCS5kaXNhYmxlID0gcGwxMTFfZGlzcGxheV9kaXNh YmxlLAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRl cgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754052AbdESMAL (ORCPT ); Fri, 19 May 2017 08:00:11 -0400 Received: from mga03.intel.com ([134.134.136.65]:59375 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752887AbdESMAH (ORCPT ); Fri, 19 May 2017 08:00:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,363,1491289200"; d="scan'208";a="859026022" From: Jani Nikula To: Colin King , Tom Cooksey , Eric Anholt , David Airlie , dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static In-Reply-To: <20170519110203.19417-1-colin.king@canonical.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170519110203.19417-1-colin.king@canonical.com> Date: Fri, 19 May 2017 15:03:31 +0300 Message-ID: <874lwhoxyk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 May 2017, Colin King wrote: > From: Colin Ian King > > structure pl111_display_funcs can be made static as it does not need to be > in global scope. Fixes sparse warning: > > "warning: symbol 'pl111_display_funcs' was not declared. Should it > be static?" > > Fixes: bed41005e6174d ("drm/pl111: Initial drm/kms driver for pl111") The patch looks good and I appreciate what you're doing, but I question the usefulness of adding Fixes: tags for trivial stuff like this. I'd prefer Fixes: was reserved for actual fixes that should be backported to any kernels that have the commit being fixed. The same applies to many other patches you've sent recently. BR, Jani. > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/pl111/pl111_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c > index 39a5c33bce7d..bd8ff82c2fd9 100644 > --- a/drivers/gpu/drm/pl111/pl111_display.c > +++ b/drivers/gpu/drm/pl111/pl111_display.c > @@ -280,7 +280,7 @@ static int pl111_display_prepare_fb(struct drm_simple_display_pipe *pipe, > return drm_fb_cma_prepare_fb(&pipe->plane, plane_state); > } > > -const struct drm_simple_display_pipe_funcs pl111_display_funcs = { > +static const struct drm_simple_display_pipe_funcs pl111_display_funcs = { > .check = pl111_display_check, > .enable = pl111_display_enable, > .disable = pl111_display_disable, -- Jani Nikula, Intel Open Source Technology Center