From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: change connector disconnected debug message to an error Date: Thu, 02 Feb 2017 10:32:59 +0200 Message-ID: <874m0d0z7o.fsf@intel.com> References: <20170202025904.25810-1-shuahkh@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 077CD6E932 for ; Thu, 2 Feb 2017 08:33:02 +0000 (UTC) In-Reply-To: <20170202025904.25810-1-shuahkh@osg.samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: daniel.vetter@intel.com, seanpaul@chromium.org, airlied@linux.ie Cc: Shuah Khan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAwMiBGZWIgMjAxNywgU2h1YWggS2hhbiA8c2h1YWhraEBvc2cuc2Ftc3VuZy5jb20+ IHdyb3RlOgo+IENoYW5nZSBkcm1faGVscGVyX3Byb2JlX3NpbmdsZV9jb25uZWN0b3JfbW9kZXMo KSB0byBwcmludCBhbiBlcnJvciB0bwo+IHJlcG9ydCBjb25uZWN0b3IgZGlzY29ubmVjdGVkIHN0 YXR1cyBpbnN0ZWFkIG9mIGEgZGVidWcgbWVzc2FnZS4KPgo+IFdoZW4gdGhpcyBjb25kaXRpb24g b2NjdXJzLCBhcHBsaWNhdGlvbiBkb2Vzbid0IGtub3cgdGhlIHJlYWwgZXJyb3IgYW5kCj4gcmVw b3J0cyBpdCBhcyBkcml2ZXIgbGFja2luZyBzdXBwb3J0IGZvciBtb2RlIHNldHRpbmcuIENoYW5n ZSBpdCB0byBhbgo+IGVycm9yIHRvIG1ha2UgaXQgZWFzaWVyIHRvIGRlYnVnLgoKUGxlYXNlIGV4 cGxhaW4gd2hhdCBtYWtlcyB0aGlzIGNvbmRpdGlvbiBhbiBlcnJvci4gQ29ubmVjdG9ycyBnZXQK Y29ubmVjdGVkIGFuZCBkaXNjb25uZWN0ZWQsIGJ1c2luZXNzIGFzIHVzdWFsLCB3aHkgc2hvdWxk IHRoaXMgYmUgYW4KZXJyb3I/CgpCUiwKSmFuaS4KCgo+Cj4gU2lnbmVkLW9mZi1ieTogU2h1YWgg S2hhbiA8c2h1YWhraEBvc2cuc2Ftc3VuZy5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9k cm1fcHJvYmVfaGVscGVyLmMgfCA0ICsrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJt X3Byb2JlX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYwo+IGlu ZGV4IGFjOTUzZjAuLjY0NzJiN2YgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9w cm9iZV9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMK PiBAQCAtMjgyLDggKzI4Miw4IEBAIGludCBkcm1faGVscGVyX3Byb2JlX3NpbmdsZV9jb25uZWN0 b3JfbW9kZXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCWRldi0+bW9kZV9j b25maWcucG9sbF9ydW5uaW5nID0gZHJtX2ttc19oZWxwZXJfcG9sbDsKPiAgCj4gIAlpZiAoY29u bmVjdG9yLT5zdGF0dXMgPT0gY29ubmVjdG9yX3N0YXR1c19kaXNjb25uZWN0ZWQpIHsKPiAtCQlE Uk1fREVCVUdfS01TKCJbQ09OTkVDVE9SOiVkOiVzXSBkaXNjb25uZWN0ZWRcbiIsCj4gLQkJCWNv bm5lY3Rvci0+YmFzZS5pZCwgY29ubmVjdG9yLT5uYW1lKTsKPiArCQlEUk1fRVJST1IoIltDT05O RUNUT1I6JWQ6JXNdIGRpc2Nvbm5lY3RlZFxuIiwKPiArCQkJICBjb25uZWN0b3ItPmJhc2UuaWQs IGNvbm5lY3Rvci0+bmFtZSk7Cj4gIAkJZHJtX21vZGVfY29ubmVjdG9yX3VwZGF0ZV9lZGlkX3By b3BlcnR5KGNvbm5lY3RvciwgTlVMTCk7Cj4gIAkJdmVyYm9zZV9wcnVuZSA9IGZhbHNlOwo+ICAJ CWdvdG8gcHJ1bmU7CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xv Z3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751175AbdBBIdE (ORCPT ); Thu, 2 Feb 2017 03:33:04 -0500 Received: from mga06.intel.com ([134.134.136.31]:1072 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbdBBIdD (ORCPT ); Thu, 2 Feb 2017 03:33:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,323,1477983600"; d="scan'208";a="816162758" From: Jani Nikula To: Shuah Khan , daniel.vetter@intel.com, seanpaul@chromium.org, airlied@linux.ie Cc: Shuah Khan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: change connector disconnected debug message to an error In-Reply-To: <20170202025904.25810-1-shuahkh@osg.samsung.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170202025904.25810-1-shuahkh@osg.samsung.com> Date: Thu, 02 Feb 2017 10:32:59 +0200 Message-ID: <874m0d0z7o.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Feb 2017, Shuah Khan wrote: > Change drm_helper_probe_single_connector_modes() to print an error to > report connector disconnected status instead of a debug message. > > When this condition occurs, application doesn't know the real error and > reports it as driver lacking support for mode setting. Change it to an > error to make it easier to debug. Please explain what makes this condition an error. Connectors get connected and disconnected, business as usual, why should this be an error? BR, Jani. > > Signed-off-by: Shuah Khan > --- > drivers/gpu/drm/drm_probe_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c > index ac953f0..6472b7f 100644 > --- a/drivers/gpu/drm/drm_probe_helper.c > +++ b/drivers/gpu/drm/drm_probe_helper.c > @@ -282,8 +282,8 @@ int drm_helper_probe_single_connector_modes(struct drm_connector *connector, > dev->mode_config.poll_running = drm_kms_helper_poll; > > if (connector->status == connector_status_disconnected) { > - DRM_DEBUG_KMS("[CONNECTOR:%d:%s] disconnected\n", > - connector->base.id, connector->name); > + DRM_ERROR("[CONNECTOR:%d:%s] disconnected\n", > + connector->base.id, connector->name); > drm_mode_connector_update_edid_property(connector, NULL); > verbose_prune = false; > goto prune; -- Jani Nikula, Intel Open Source Technology Center