From: Jani Nikula <jani.nikula@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
kbuild test robot <fengguang.wu@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m
Date: Mon, 09 Jan 2017 12:59:06 +0200 [thread overview]
Message-ID: <874m18fqit.fsf@intel.com> (raw)
In-Reply-To: <f671c5f4-97b0-3f5a-1c23-847f36ec3b9f@infradead.org>
On Thu, 05 Jan 2017, Randy Dunlap <rdunlap@infradead.org> wrote:
> That particular circular/recursive dependency is ugly. I spent about
> one hour trying/testing various fixes and don't have one.
I didn't really look at this one all that much, but when I face problems
with kconfig, it's almost invariably because of overuse of
select. Documentation/kbuild/kconfig-language.txt says, "In general use
select only for non-visible symbols (no prompts anywhere) and for
symbols with no dependencies." People violate this all the time because
it's convenient. If they depended, they'd have to enable all deps to
even see their config.
I wish kconfig would warn about incorrect use of select... though I
guess that would produce a wall of warnings. Additionally, it really
should be easier to find and enable unmet dependencies in
menuconfig. Someone(tm) has a lot of work to do...
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
kbuild test robot <fengguang.wu@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m
Date: Mon, 09 Jan 2017 12:59:06 +0200 [thread overview]
Message-ID: <874m18fqit.fsf@intel.com> (raw)
In-Reply-To: <f671c5f4-97b0-3f5a-1c23-847f36ec3b9f@infradead.org>
On Thu, 05 Jan 2017, Randy Dunlap <rdunlap@infradead.org> wrote:
> That particular circular/recursive dependency is ugly. I spent about
> one hour trying/testing various fixes and don't have one.
I didn't really look at this one all that much, but when I face problems
with kconfig, it's almost invariably because of overuse of
select. Documentation/kbuild/kconfig-language.txt says, "In general use
select only for non-visible symbols (no prompts anywhere) and for
symbols with no dependencies." People violate this all the time because
it's convenient. If they depended, they'd have to enable all deps to
even see their config.
I wish kconfig would warn about incorrect use of select... though I
guess that would produce a wall of warnings. Additionally, it really
should be easier to find and enable unmet dependencies in
menuconfig. Someone(tm) has a lot of work to do...
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2017-01-09 10:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 0:20 [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Randy Dunlap
2017-01-04 8:45 ` Daniel Vetter
2017-01-04 8:45 ` Daniel Vetter
2017-01-04 14:25 ` Ilia Mirkin
2017-01-04 14:25 ` Ilia Mirkin
2017-01-05 2:52 ` Randy Dunlap
2017-01-05 3:09 ` Ilia Mirkin
2017-01-05 3:09 ` Ilia Mirkin
2017-01-05 3:17 ` Randy Dunlap
2017-01-05 3:23 ` Ilia Mirkin
2017-01-05 3:23 ` Ilia Mirkin
2017-01-04 19:29 ` Jani Nikula
2017-01-04 19:29 ` Jani Nikula
2017-01-04 22:24 ` Randy Dunlap
2017-01-05 8:01 ` Daniel Vetter
2017-01-05 16:08 ` Randy Dunlap
2017-01-09 10:59 ` Jani Nikula [this message]
2017-01-09 10:59 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m18fqit.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.