From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Date: Mon, 09 Jan 2017 12:59:06 +0200 Message-ID: <874m18fqit.fsf@intel.com> References: <029a1ec5-48ac-a3ce-3106-430e0f2584bb@infradead.org> <20170104084508.m54kwdkl2z6s3ruk@phenom.ffwll.local> <87k2aamxni.fsf@intel.com> <20170105080104.7m6cnfjavjdgngml@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F07F6E1EA for ; Mon, 9 Jan 2017 10:59:09 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Randy Dunlap , kbuild test robot , LKML , dri-devel , Ben Skeggs List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAwNSBKYW4gMjAxNywgUmFuZHkgRHVubGFwIDxyZHVubGFwQGluZnJhZGVhZC5vcmc+ IHdyb3RlOgo+IFRoYXQgcGFydGljdWxhciBjaXJjdWxhci9yZWN1cnNpdmUgZGVwZW5kZW5jeSBp cyB1Z2x5LiBJIHNwZW50IGFib3V0Cj4gb25lIGhvdXIgdHJ5aW5nL3Rlc3RpbmcgdmFyaW91cyBm aXhlcyBhbmQgZG9uJ3QgaGF2ZSBvbmUuCgpJIGRpZG4ndCByZWFsbHkgbG9vayBhdCB0aGlzIG9u ZSBhbGwgdGhhdCBtdWNoLCBidXQgd2hlbiBJIGZhY2UgcHJvYmxlbXMKd2l0aCBrY29uZmlnLCBp dCdzIGFsbW9zdCBpbnZhcmlhYmx5IGJlY2F1c2Ugb2Ygb3ZlcnVzZSBvZgpzZWxlY3QuIERvY3Vt ZW50YXRpb24va2J1aWxkL2tjb25maWctbGFuZ3VhZ2UudHh0IHNheXMsICJJbiBnZW5lcmFsIHVz ZQpzZWxlY3Qgb25seSBmb3Igbm9uLXZpc2libGUgc3ltYm9scyAobm8gcHJvbXB0cyBhbnl3aGVy ZSkgYW5kIGZvcgpzeW1ib2xzIHdpdGggbm8gZGVwZW5kZW5jaWVzLiIgUGVvcGxlIHZpb2xhdGUg dGhpcyBhbGwgdGhlIHRpbWUgYmVjYXVzZQppdCdzIGNvbnZlbmllbnQuIElmIHRoZXkgZGVwZW5k ZWQsIHRoZXknZCBoYXZlIHRvIGVuYWJsZSBhbGwgZGVwcyB0bwpldmVuIHNlZSB0aGVpciBjb25m aWcuCgpJIHdpc2gga2NvbmZpZyB3b3VsZCB3YXJuIGFib3V0IGluY29ycmVjdCB1c2Ugb2Ygc2Vs ZWN0Li4uIHRob3VnaCBJCmd1ZXNzIHRoYXQgd291bGQgcHJvZHVjZSBhIHdhbGwgb2Ygd2Fybmlu Z3MuIEFkZGl0aW9uYWxseSwgaXQgcmVhbGx5CnNob3VsZCBiZSBlYXNpZXIgdG8gZmluZCBhbmQg ZW5hYmxlIHVubWV0IGRlcGVuZGVuY2llcyBpbgptZW51Y29uZmlnLiBTb21lb25lKHRtKSBoYXMg YSBsb3Qgb2Ygd29yayB0byBkby4uLgoKQlIsCkphbmkuCgoKCi0tIApKYW5pIE5pa3VsYSwgSW50 ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935696AbdAIK7K (ORCPT ); Mon, 9 Jan 2017 05:59:10 -0500 Received: from mga01.intel.com ([192.55.52.88]:42255 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935153AbdAIK7J (ORCPT ); Mon, 9 Jan 2017 05:59:09 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="806714707" From: Jani Nikula To: Randy Dunlap , kbuild test robot , LKML , dri-devel , Ben Skeggs Subject: Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <029a1ec5-48ac-a3ce-3106-430e0f2584bb@infradead.org> <20170104084508.m54kwdkl2z6s3ruk@phenom.ffwll.local> <87k2aamxni.fsf@intel.com> <20170105080104.7m6cnfjavjdgngml@phenom.ffwll.local> Date: Mon, 09 Jan 2017 12:59:06 +0200 Message-ID: <874m18fqit.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 Jan 2017, Randy Dunlap wrote: > That particular circular/recursive dependency is ugly. I spent about > one hour trying/testing various fixes and don't have one. I didn't really look at this one all that much, but when I face problems with kconfig, it's almost invariably because of overuse of select. Documentation/kbuild/kconfig-language.txt says, "In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies." People violate this all the time because it's convenient. If they depended, they'd have to enable all deps to even see their config. I wish kconfig would warn about incorrect use of select... though I guess that would produce a wall of warnings. Additionally, it really should be easier to find and enable unmet dependencies in menuconfig. Someone(tm) has a lot of work to do... BR, Jani. -- Jani Nikula, Intel Open Source Technology Center