From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 04/14] drm/i915: Clean up the .get_cdclk() assignment if ladder Date: Mon, 19 Dec 2016 19:35:20 +0200 Message-ID: <874m1zes9z.fsf@intel.com> References: <20161219123501.3750-1-ville.syrjala@linux.intel.com> <20161219123501.3750-5-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C96CF6E564 for ; Mon, 19 Dec 2016 17:35:27 +0000 (UTC) In-Reply-To: <20161219123501.3750-5-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAxOSBEZWMgMjAxNiwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6 Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Pgo+IExldCdzIGNsZWFuIHVwIHRoZSBtZXNzIHdlIGhhdmUgaW4gdGhlIGlmIGxhZGRlciB0aGF0 IGFzc2lnbnMgdGhlCj4gLmdldF9jZGNsaygpIGhvb2tzLiBUaGUgZ3JvdXBpbmcgb2YgdGhlIHBs YXRmb3JtcyBieSB0aGUgZnVuY3Rpb24KPiByZXN1bHRzIGluIGEgdGhpbmcgdGhhdCdzIG5vdCBy ZWFsbHkgbGVnaWJsZSwgc28gbGV0J3MgZG8gaXQgdGhlCj4gb3RoZXIgd2F5IGFyb3VuZCBhbmQg b3JkZXIgdGhlIGlmIGxhZGRlciBieSBwbGF0Zm9ybSBhbmQgZHVwbGljYXRlCj4gd2hhdGV2ZXIg YXNzaWdubWVudHMgd2UgbmVlZC4KPgo+IFRvIGZ1cnRoZXIgYXZvaWQgY29uZnVzaW9uIHdpdGgg dGhlIGZ1bmN0aW9uIG5hbWVzIGxldCdzIHJlbmFtZQo+IHRoZW0gdG8ganVzdCBmaXhlZF88ZnJl cT5fZ2V0X2NkY2xrKCkuIFRoZSBvdGhlciBvcHRpb24gd291bGQKPiBiZSB0byBkdXBsaWNhdGUg dGhlIGZ1bmN0aW9ucyBlbnRpcmVseSBidXQgaXQgc2VlbXMgcXVpdGUKPiBwb2ludGxlc3MgdG8g ZG8gdGhhdCBzaW5jZSBlYWNoIG9uZSBqdXN0IHJldHVybnMgYSBmaXhlZCB2YWx1ZS4KPgo+IFNp Z25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5j b20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDQxICsr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjQg aW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gaW5kZXggYmJmZWYzNDg3ODNiLi4yOWY5MWU3OTkyNzIgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTczNzksMjIgKzczNzksMjIgQEAgc3Rh dGljIGludCB2YWxsZXl2aWV3X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYpCj4gIAkJCQkgICAgICBDQ0tfRElTUExBWV9DTE9DS19DT05UUk9MKTsKPiAgfQo+ICAK PiAtc3RhdGljIGludCBpbGtfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPiArc3RhdGljIGludCBmaXhlZF80NTBtaHpfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJcmV0dXJuIDQ1MDAwMDsKPiAgfQo+ICAKPiAt c3RhdGljIGludCBpOTQ1X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpCj4gK3N0YXRpYyBpbnQgZml4ZWRfNDAwbWh6X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiAgCXJldHVybiA0MDAwMDA7Cj4gIH0KPiAgCj4gLXN0 YXRpYyBpbnQgaTkxNV9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICtzdGF0aWMgaW50IGZpeGVkXzMzM21oel9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gIAlyZXR1cm4gMzMzMzMzOwo+ICB9Cj4gIAo+IC1zdGF0 aWMgaW50IGk5eHhfbWlzY19nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+ICtzdGF0aWMgaW50IGZpeGVkXzIwMG1oel9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gIAlyZXR1cm4gMjAwMDAwOwo+ICB9Cj4gQEAgLTc0 NDQsNyArNzQ0NCw3IEBAIHN0YXRpYyBpbnQgaTkxNWdtX2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAl9Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgaTg2NV9n ZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICtzdGF0aWMgaW50 IGZpeGVkXzI2Nm1oel9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICB7Cj4gIAlyZXR1cm4gMjY2NjY3Owo+ICB9Cj4gQEAgLTc0ODcsNyArNzQ4Nyw3IEBAIHN0 YXRpYyBpbnQgaTg1eF9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgaTgzMF9nZXRfY2RjbGsoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICtzdGF0aWMgaW50IGZpeGVkXzEzM21o el9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gIAly ZXR1cm4gMTMzMzMzOwo+ICB9Cj4gQEAgLTE2MDk4LDMyICsxNjA5OCwzOSBAQCB2b2lkIGludGVs X2luaXRfZGlzcGxheV9ob29rcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g IAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gaGFzd2VsbF9nZXRfY2RjbGs7Cj4gIAll bHNlIGlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2 KSkKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSB2YWxsZXl2aWV3X2dldF9jZGNs azsKPiArCWVsc2UgaWYgKElTX0dFTjYoZGV2X3ByaXYpIHx8IElTX0lWWUJSSURHRShkZXZfcHJp dikpCj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfNDAwbWh6X2dldF9j ZGNsazsKPiAgCWVsc2UgaWYgKElTX0dFTjUoZGV2X3ByaXYpKQo+IC0JCWRldl9wcml2LT5kaXNw bGF5LmdldF9jZGNsayA9IGlsa19nZXRfY2RjbGs7Cj4gLQllbHNlIGlmIChJU19JOTQ1RyhkZXZf cHJpdikgfHwgSVNfSTk2NUcoZGV2X3ByaXYpIHx8Cj4gLQkJIElTX0dFTjYoZGV2X3ByaXYpIHx8 IElTX0lWWUJSSURHRShkZXZfcHJpdikpCj4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xr ID0gaTk0NV9nZXRfY2RjbGs7Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4 ZWRfNDUwbWh6X2dldF9jZGNsazsKPiAgCWVsc2UgaWYgKElTX0dNNDUoZGV2X3ByaXYpKQo+ICAJ CWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGdtNDVfZ2V0X2NkY2xrOwo+ICsJZWxzZSBp ZiAoSVNfRzRYKGRldl9wcml2KSkKPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBn MzNfZ2V0X2NkY2xrOwo+ICAJZWxzZSBpZiAoSVNfSTk2NUdNKGRldl9wcml2KSkKPiAgCQlkZXZf cHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpOTY1Z21fZ2V0X2NkY2xrOwo+ICsJZWxzZSBpZiAo SVNfSTk2NUcoZGV2X3ByaXYpKQo+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZp eGVkXzQwMG1oel9nZXRfY2RjbGs7Cj4gIAllbHNlIGlmIChJU19QSU5FVklFVyhkZXZfcHJpdikp Cj4gIAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gcG52X2dldF9jZGNsazsKPiAtCWVs c2UgaWYgKElTX0czMyhkZXZfcHJpdikgfHwgSVNfRzRYKGRldl9wcml2KSkKPiArCWVsc2UgaWYg KElTX0czMyhkZXZfcHJpdikpCj4gIAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZzMz X2dldF9jZGNsazsKPiAtCWVsc2UgaWYgKElTX0k5MTVHKGRldl9wcml2KSkKPiAtCQlkZXZfcHJp di0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpOTE1X2dldF9jZGNsazsKPiAtCWVsc2UgaWYgKElTX0k5 NDVHTShkZXZfcHJpdikgfHwgSVNfSTg0NUcoZGV2X3ByaXYpKQo+IC0JCWRldl9wcml2LT5kaXNw bGF5LmdldF9jZGNsayA9IGk5eHhfbWlzY19nZXRfY2RjbGs7Cj4gKwllbHNlIGlmIChJU19JOTQ1 R00oZGV2X3ByaXYpKQo+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzIw MG1oel9nZXRfY2RjbGs7Cj4gKwllbHNlIGlmIChJU19JOTQ1RyhkZXZfcHJpdikpCj4gKwkJZGV2 X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfNDAwbWh6X2dldF9jZGNsazsKPiAgCWVs c2UgaWYgKElTX0k5MTVHTShkZXZfcHJpdikpCj4gIAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2Nk Y2xrID0gaTkxNWdtX2dldF9jZGNsazsKPiArCWVsc2UgaWYgKElTX0k5MTVHKGRldl9wcml2KSkK PiArCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBmaXhlZF8zMzNtaHpfZ2V0X2NkY2xr Owo+ICAJZWxzZSBpZiAoSVNfSTg2NUcoZGV2X3ByaXYpKQo+IC0JCWRldl9wcml2LT5kaXNwbGF5 LmdldF9jZGNsayA9IGk4NjVfZ2V0X2NkY2xrOwo+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9j ZGNsayA9IGZpeGVkXzI2Nm1oel9nZXRfY2RjbGs7Cj4gIAllbHNlIGlmIChJU19JODVYKGRldl9w cml2KSkKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpODV4X2dldF9jZGNsazsK PiArCWVsc2UgIGlmIChJU19JODQ1RyhkZXZfcHJpdikpCj4gKwkJZGV2X3ByaXYtPmRpc3BsYXku Z2V0X2NkY2xrID0gZml4ZWRfMjAwbWh6X2dldF9jZGNsazsKPiAgCWVsc2UgeyAvKiA4MzAgKi8K PiAgCQlXQVJOKCFJU19JODMwKGRldl9wcml2KSwgIlVua25vd24gcGxhdGZvcm0uIEFzc3VtaW5n IDEzMyBNSHogQ0RDTEtcbiIpOwo+IC0JCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGk4 MzBfZ2V0X2NkY2xrOwo+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzEz M21oel9nZXRfY2RjbGs7Cj4gIAl9CgpJIHdvbmRlciBpZiAic3dpdGNoIChkZXZfcHJpdi0+aW5m by5wbGF0Zm9ybSkiIGlzIGEgdmlhYmxlIGFsdGVybmF0aXZlCnRvIHNvbWUgb2YgdGhlIHdvcnN0 IGlmIGxhZGRlcnMgd2UgaGF2ZSwgbGlrZSB0aGlzIG9uZS4KCkJSLApKYW5pLgoKCj4gIAo+ICAJ aWYgKElTX0dFTjUoZGV2X3ByaXYpKSB7CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291 cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=