diff for duplicates of <874m2otenv.fsf@kamboji.qca.qualcomm.com> diff --git a/a/1.txt b/N1/1.txt index da7460c..ebddb37 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,27 +7,32 @@ Kalle Valo <kvalo@qca.qualcomm.com> writes: >>> On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote: >>> >>>> Bjorn Andersson <bjorn.andersson@linaro.org> wrote: ->>>> > The correct include file for getting errno constants and ERR_PTR() is +>>>> > The correct include file for getting errno constants and ERR_PTR() i= +s >>>> > linux/err.h, rather than linux/errno.h, so fix the include. ->>>> > ->>>> > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state") +>>>> >=20 +>>>> > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled = +smem_state") >>>> > Acked-by: Andy Gross <andy.gross@linaro.org> >>>> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> ->>>> ->>>> For some reason this fails to compile now. Can you take a look, please? ->>>> ->>>> ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined! +>>>>=20 +>>>> For some reason this fails to compile now. Can you take a look, please= +? +>>>>=20 +>>>> ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn= +36xx.ko] undefined! >>>> make[1]: *** [__modpost] Error 1 >>>> make: *** [modules] Error 2 ->>>> +>>>>=20 >>>> 5 patches set to Changes Requested. ->>>> +>>>>=20 >>>> 9429045 [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() >>>> 9429047 [v5,2/5] wcn36xx: Transition driver to SMD client >>> >>> This patch was updated with the necessary depends in Kconfig to catch ->>> this exact issue and when I pull in your .config (which has QCOM_SMD=n, ->>> QCOM_WCNSS_CTRL=n and WCN36XX=y) I can build this just fine. +>>> this exact issue and when I pull in your .config (which has QCOM_SMD=3D= +n, +>>> QCOM_WCNSS_CTRL=3Dn and WCN36XX=3Dy) I can build this just fine. >>> >>> I've tested the various combinations and it seems to work fine. Do you >>> have any other patches in your tree? @@ -51,19 +56,22 @@ Kalle Valo <kvalo@qca.qualcomm.com> writes: It found the same problem. Interestingly I'm also building x86 with 32 bit, maybe it's related? -tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending +tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pendi= +ng head: 1ea16a1c457939b4564643f7637d5cc639a8d3b7 -commit: 5eb09c672b01460804fd49b1c9cc7d1072a102f0 [96/99] wcn36xx: Transition driver to SMD client +commit: 5eb09c672b01460804fd49b1c9cc7d1072a102f0 [96/99] wcn36xx: Transitio= +n driver to SMD client config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout 5eb09c672b01460804fd49b1c9cc7d1072a102f0 # save the attached .config to linux build tree - make ARCH=i386 + make ARCH=3Di386=20 All errors (new ones prefixed by >>): ->> ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined! +>> ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36= +xx.ko] undefined! --- -Kalle Valo +--=20 +Kalle Valo= diff --git a/a/content_digest b/N1/content_digest index e165963..d934046 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -25,27 +25,32 @@ ">>> On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote:\n" ">>>\n" ">>>> Bjorn Andersson <bjorn.andersson@linaro.org> wrote:\n" - ">>>> > The correct include file for getting errno constants and ERR_PTR() is\n" + ">>>> > The correct include file for getting errno constants and ERR_PTR() i=\n" + "s\n" ">>>> > linux/err.h, rather than linux/errno.h, so fix the include.\n" - ">>>> > \n" - ">>>> > Fixes: e8b123e60084 (\"soc: qcom: smem_state: Add stubs for disabled smem_state\")\n" + ">>>> >=20\n" + ">>>> > Fixes: e8b123e60084 (\"soc: qcom: smem_state: Add stubs for disabled =\n" + "smem_state\")\n" ">>>> > Acked-by: Andy Gross <andy.gross@linaro.org>\n" ">>>> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>\n" - ">>>> \n" - ">>>> For some reason this fails to compile now. Can you take a look, please?\n" - ">>>> \n" - ">>>> ERROR: \"qcom_wcnss_open_channel\" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined!\n" + ">>>>=20\n" + ">>>> For some reason this fails to compile now. Can you take a look, please=\n" + "?\n" + ">>>>=20\n" + ">>>> ERROR: \"qcom_wcnss_open_channel\" [drivers/net/wireless/ath/wcn36xx/wcn=\n" + "36xx.ko] undefined!\n" ">>>> make[1]: *** [__modpost] Error 1\n" ">>>> make: *** [modules] Error 2\n" - ">>>> \n" + ">>>>=20\n" ">>>> 5 patches set to Changes Requested.\n" - ">>>> \n" + ">>>>=20\n" ">>>> 9429045 [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()\n" ">>>> 9429047 [v5,2/5] wcn36xx: Transition driver to SMD client\n" ">>>\n" ">>> This patch was updated with the necessary depends in Kconfig to catch\n" - ">>> this exact issue and when I pull in your .config (which has QCOM_SMD=n,\n" - ">>> QCOM_WCNSS_CTRL=n and WCN36XX=y) I can build this just fine.\n" + ">>> this exact issue and when I pull in your .config (which has QCOM_SMD=3D=\n" + "n,\n" + ">>> QCOM_WCNSS_CTRL=3Dn and WCN36XX=3Dy) I can build this just fine.\n" ">>>\n" ">>> I've tested the various combinations and it seems to work fine. Do you\n" ">>> have any other patches in your tree?\n" @@ -69,21 +74,24 @@ "It found the same problem. Interestingly I'm also building x86 with 32\n" "bit, maybe it's related?\n" "\n" - "tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending\n" + "tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pendi=\n" + "ng\n" "head: 1ea16a1c457939b4564643f7637d5cc639a8d3b7\n" - "commit: 5eb09c672b01460804fd49b1c9cc7d1072a102f0 [96/99] wcn36xx: Transition driver to SMD client\n" + "commit: 5eb09c672b01460804fd49b1c9cc7d1072a102f0 [96/99] wcn36xx: Transitio=\n" + "n driver to SMD client\n" "config: i386-allmodconfig (attached as .config)\n" "compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901\n" "reproduce:\n" " git checkout 5eb09c672b01460804fd49b1c9cc7d1072a102f0\n" " # save the attached .config to linux build tree\n" - " make ARCH=i386 \n" + " make ARCH=3Di386=20\n" "\n" "All errors (new ones prefixed by >>):\n" "\n" - ">> ERROR: \"qcom_wcnss_open_channel\" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined!\n" + ">> ERROR: \"qcom_wcnss_open_channel\" [drivers/net/wireless/ath/wcn36xx/wcn36=\n" + "xx.ko] undefined!\n" "\n" - "-- \n" - Kalle Valo + "--=20\n" + Kalle Valo= -e5b78b73fb7b9e4a3237a64d925616107b5bdf7d9f11bd0c2312d905dc2615a3 +9efb73d726940e6e65648c8a0e562add25212548d42ed6593457257a1b50ab49
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.