From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com ([192.55.52.43]:58078 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753820AbcKOJcm (ORCPT ); Tue, 15 Nov 2016 04:32:42 -0500 From: Felipe Balbi To: Peter Chen , Greg KH Cc: Peter Chen , linux-usb@vger.kernel.org, "#v4 . 1+" Subject: Re: [PATCH v2 1/1] usb: chipidea: move the lock initialization to core file In-Reply-To: <20161115071552.GB24385@b29397-desktop> References: <1479189767-8300-1-git-send-email-peter.chen@nxp.com> <20161115065816.GA25872@kroah.com> <20161115071552.GB24385@b29397-desktop> Date: Tue, 15 Nov 2016 11:32:02 +0200 Message-ID: <874m39w0kt.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Peter Chen writes: > On Tue, Nov 15, 2016 at 07:58:16AM +0100, Greg KH wrote: >> On Tue, Nov 15, 2016 at 02:02:47PM +0800, Peter Chen wrote: >> > This can fix below dump when the lock is accessed at host >> > mode due to it is not initialized. >> >=20 >> > [ 46.119638] INFO: trying to register non-static key. >> > [ 46.124643] the code is fine but needs lockdep annotation. >> > [ 46.130144] turning off the locking correctness validator. >> > [ 46.135659] CPU: 0 PID: 690 Comm: cat Not tainted 4.9.0-rc3-00079-g= 4b75f1d #1210 >> > [ 46.143075] Hardware name: Freescale i.MX6 SoloX (Device Tree) >> > [ 46.148923] Backtrace: >> > [ 46.151448] [] (dump_backtrace) from [] (show_s= tack+0x18/0x1c) >> > [ 46.159038] r7:edf52000 >> > [ 46.161412] r6:60000193 >> > [ 46.163967] r5:00000000 >> > [ 46.165035] r4:c0e25c2c >> >=20 >> > [ 46.169109] [] (show_stack) from [] (dump_stack= +0xb4/0xe8) >> > [ 46.176362] [] (dump_stack) from [] (register_l= ock_class+0x4fc/0x56c) >> > [ 46.184554] r10:c0e25d24 >> > [ 46.187014] r9:edf53e70 >> > [ 46.189569] r8:c1642444 >> > [ 46.190637] r7:ee9da024 >> > [ 46.193191] r6:00000000 >> > [ 46.194258] r5:00000000 >> > [ 46.196812] r4:00000000 >> > [ 46.199185] r3:00000001 >> >=20 >> > [ 46.203259] [] (register_lock_class) from [] (_= _lock_acquire+0x80/0x10f0) >> > [ 46.211797] r10:c0e25d24 >> > [ 46.214257] r9:edf53e70 >> > [ 46.216813] r8:ee9da024 >> > [ 46.217880] r7:c1642444 >> > [ 46.220435] r6:edcd1800 >> > [ 46.221502] r5:60000193 >> > [ 46.224057] r4:00000000 >> >=20 >> > [ 46.227953] [] (__lock_acquire) from [] (lock_a= cquire+0x74/0x94) >> > [ 46.235710] r10:00000001 >> > [ 46.238169] r9:edf53e70 >> > [ 46.240723] r8:edf53f80 >> > [ 46.241790] r7:00000001 >> > [ 46.244344] r6:00000001 >> > [ 46.245412] r5:60000193 >> > [ 46.247966] r4:00000000 >> >=20 >> > [ 46.251866] [] (lock_acquire) from [] (_raw_spi= n_lock_irqsave+0x40/0x54) >> > [ 46.260319] r7:ee1c6a00 >> > [ 46.262691] r6:c062a570 >> > [ 46.265247] r5:20000113 >> > [ 46.266314] r4:ee9da014 >> >=20 >> > [ 46.270393] [] (_raw_spin_lock_irqsave) from []= (ci_port_test_show+0x2c/0x70) >> > [ 46.279280] r6:eebd2000 >> > [ 46.281652] r5:ee9da010 >> > [ 46.284207] r4:ee9da014 >> >=20 >> > [ 46.286810] [] (ci_port_test_show) from [] (seq= _read+0x1ac/0x4f8) >> > [ 46.294655] r9:edf53e70 >> > [ 46.297028] r8:edf53f80 >> > [ 46.299583] r7:ee1c6a00 >> > [ 46.300650] r6:00000001 >> > [ 46.303205] r5:00000000 >> > [ 46.304273] r4:eebd2000 >> > [ 46.306850] [] (seq_read) from [] (full_proxy_r= ead+0x54/0x6c) >> > [ 46.314348] r10:00000000 >> > [ 46.316808] r9:c0a6ad30 >> > [ 46.319363] r8:edf53f80 >> > [ 46.320430] r7:00020000 >> > [ 46.322986] r6:b6de3000 >> > [ 46.324053] r5:ee1c6a00 >> > [ 46.326607] r4:c0248b58 >> >=20 >> > [ 46.330505] [] (full_proxy_read) from [] (__vfs= _read+0x34/0x118) >> > [ 46.338262] r9:edf52000 >> > [ 46.340635] r8:c0107fc4 >> > [ 46.343190] r7:00020000 >> > [ 46.344257] r6:edf53f80 >> > [ 46.346812] r5:c039e810 >> > [ 46.347879] r4:ee1c6a00 >> > [ 46.350447] [] (__vfs_read) from [] (vfs_read+0= x8c/0x11c) >> > [ 46.357597] r9:edf52000 >> > [ 46.359969] r8:c0107fc4 >> > [ 46.362524] r7:edf53f80 >> > [ 46.363592] r6:b6de3000 >> > [ 46.366147] r5:ee1c6a00 >> > [ 46.367214] r4:00020000 >> > [ 46.369782] [] (vfs_read) from [] (SyS_read+0x4= c/0xa8) >> > [ 46.376672] r8:c0107fc4 >> > [ 46.379045] r7:00020000 >> > [ 46.381600] r6:b6de3000 >> > [ 46.382667] r5:ee1c6a00 >> > [ 46.385222] r4:ee1c6a00 >> >=20 >> > [ 46.387817] [] (SyS_read) from [] (ret_fast_sys= call+0x0/0x1c) >> > [ 46.395314] r7:00000003 >> > [ 46.397687] r6:b6de3000 >> > [ 46.400243] r5:00020000 >> > [ 46.401310] r4:00020000 >> >=20 >> > Cc: #v4.1+ >>=20 >> Any idea what commit caused the problem? >>=20 > > This issue has been existed from this driver has written, and the > structure refined later, this patch can be applied after that > (4 years ago), I think v4.1 is the last stable tree it can be > applied. from a quick read, it looks to me like commit=20 e443b333629f82ca0da91a05ca638050943bbedd is the first one where this would be reproducible. That would be v3.5, IIRC. We still have a few longterm kernels before v4.1 which might wanna use this commit. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlgq1hIACgkQzL64meEa mQZb6xAAjiHozBp4RyMF3ZTxdGTLVnAmWc5ia8YoPmSc3c0F6Y+hebauF6E/PTVc 0y2K/5jWIYc2Q4VylxcW9tTbPccdHiBkZ23kQhmXaOahYRejUVxSR9VJC9SCvHok en+iF8ZXAjQqx3cYYRY10pEeATYC1mwb7vEj93rCAvllBpUCWmTZnxZR/aMN/Si1 KKdgP9IxCGGU0li9UOk3bwU84Qdua6qTPZFdldG90TmastiH6k6pjE4PO6Zm1WPm zEbrGSgsZSfdNbYnnpndFnGH8EAskraF4ieolFPmIQYHdxjOB5WyhLAspGq+VJlr sCeGBy/3kzFdTjnA3HfhRRvlDrfYe3xZiLq4VS2EAPGC/hgzsULmAIr4dkfnEWwe Db9GJ7qY377BKlLix8hZj7co+M7voI+z4xlLAupylTA7jBgy+w7MT1EWx5RpttwZ ZqHsgA5q62STnJv7LOCJbwpyBnCb9Mx83Wj91exINrjYBGiQHok3x8vq5X1i9hy2 mT23SnD0KIT4vebToMTjJ+KUoptUTTrcFr2TnMk/IfoovC1AdO0ZSMey9zRKA7AC zCOfsjIyAbRomTEd8ipvrIEZ8LWTXP0a8jFBQlh0xwXtCelnjbgwPbtvLvJB0THl klt+gt6/IrZtdwykWh4PYwxySNvBxMbMkxFc07xdO3onsHD0dDw= =suZf -----END PGP SIGNATURE----- --=-=-=--