All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: "Yang, Libin" <libin.yang@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "Zhang, Keqiao" <keqiao.zhang@intel.com>
Subject: Re: [i-g-t PATCH] tests: do snd_hda_intel unbind before unload in module reload test
Date: Mon, 31 Oct 2016 11:05:31 +0200	[thread overview]
Message-ID: <874m3snb1g.fsf@intel.com> (raw)
In-Reply-To: <96A12704CE18D347B625EE2D4A099D194FA4D3BA@SHSMSX103.ccr.corp.intel.com>

On Mon, 31 Oct 2016, "Yang, Libin" <libin.yang@intel.com> wrote:
>> -----Original Message-----
>> From: Nikula, Jani
>> Sent: Monday, October 31, 2016 4:40 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Nikula, Jani <jani.nikula@intel.com>; Zhang, Keqiao
>> <keqiao.zhang@intel.com>; Yang, Libin <libin.yang@intel.com>
>> Subject: [i-g-t PATCH] tests: do snd_hda_intel unbind before unload in
>> module reload test
>> 
>> Try to make sure the snd_hda_intel module is not in use, and can be
>> unloaded.
>> 
>> Cc: Keqiao Zhang <keqiao.zhang@intel.com>
>> Cc: Libin Yang <libin.yang@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> 
>> ---
>> 
>> Keqiao, Libin, here's the script this patch is against:
>> 
>> https://cgit.freedesktop.org/drm/igt-gpu-
>> tools/tree/tests/drv_module_reload_basic
>> ---
>>  tests/drv_module_reload_basic | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/tests/drv_module_reload_basic b/tests/drv_module_reload_basic
>> index b8cad88133e9..c0676fc65db0 100755
>> --- a/tests/drv_module_reload_basic
>> +++ b/tests/drv_module_reload_basic
>> @@ -33,6 +33,9 @@ function reload() {
>>  	pkill alsactl
>>  	snd_hda_intel_unloaded=0
>>  	if mod_loaded snd_hda_intel; then
>> +		if [ -e /sys/bus/pci/drivers/snd_hda_intel/unbind ]; then
>> +			echo "0000:00:03.0" >
>
> "0000:00:03.0" is platform related.
> We should check lspci -vvv |grep Audio to get the number.
> Or we can check /sys/bus/pci/drivers/snd_hda_intel/ folder to get the number.
> And sometimes there are 2 sound cards to unbind.

How about this?

for f in $(find /sys/bus/pci/drivers/snd_hda_intel -name "0000:*" -printf %f); do
	echo $f > /sys/bus/pci/drivers/snd_hda_intel/unbind
done

BR,
Jani.


>
> Regards,
> Libin
>
>> /sys/bus/pci/drivers/snd_hda_intel/unbind
>> +		fi
>>  		if rmmod snd_hda_intel; then
>>  			snd_hda_intel_unloaded=1
>>  		else
>> --
>> 2.1.4
>

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-10-31  9:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31  8:39 [i-g-t PATCH] tests: do snd_hda_intel unbind before unload in module reload test Jani Nikula
2016-10-31  8:43 ` [i-g-t PATCH] tests: add more debugs on failure to unload snd_hda_intel Jani Nikula
2016-10-31  8:51 ` [i-g-t PATCH] tests: do snd_hda_intel unbind before unload in module reload test Yang, Libin
2016-10-31  9:05   ` Jani Nikula [this message]
2016-10-31 11:00 ` [i-g-t PATCH v2] " Jani Nikula
2016-11-01  1:45   ` Yang, Libin
2016-11-01  6:15     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874m3snb1g.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=keqiao.zhang@intel.com \
    --cc=libin.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.