From: Holger Schurig <holgerschurig@gmail.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
netdev@vger.kernel.org
Cc: davem@davemloft.net, linux-can@vger.kernel.org,
kernel@pengutronix.de, stable@vger.kernel.org
Subject: Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage
Date: Tue, 28 Jun 2016 09:36:57 +0200 [thread overview]
Message-ID: <874m8d7oiu.fsf@gmail.com> (raw)
In-Reply-To: <a1bd95b5-ea93-0e99-7784-dad393240f06@hartkopp.net>
> static void can_dellink(struct net_device *dev, struct list_head *head);
>
> and
>
> static void can_dellink(struct net_device *dev, struct list_head *head)
> {
> return;
> }
Wouldn't the canonical form be this:
static void can_dellink(struct net_device *dev, struct list_head *head)
{
}
- the curly braces make sure this isn't a forward definition
- but no useless return either
But then again, this "return" is only cosmetical. No compiler will
generate any code from it.
next prev parent reply other threads:[~2016-06-28 7:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 9:22 pull-request: can 2016-06-23 Marc Kleine-Budde
2016-06-23 9:22 ` [PATCH 1/3] can: fix handling of unmodifiable configuration options fix Marc Kleine-Budde
2016-06-23 9:22 ` [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage Marc Kleine-Budde
2016-06-23 12:55 ` Sergei Shtylyov
2016-06-23 13:01 ` Oliver Hartkopp
2016-06-23 13:09 ` Sergei Shtylyov
2016-06-23 16:45 ` Oliver Hartkopp
2016-06-28 7:36 ` Holger Schurig [this message]
2016-06-28 15:55 ` Oliver Hartkopp
2016-06-23 9:22 ` [PATCH 3/3] can: kvaser_usb: Add support for more Kvaser Leaf v2 devices Marc Kleine-Budde
2016-06-27 14:08 ` pull-request: can 2016-06-23 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m8d7oiu.fsf@gmail.com \
--to=holgerschurig@gmail.com \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=socketcan@hartkopp.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.