From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/4] drm/edid: move displayid tiled block parsing into separate function. Date: Tue, 10 May 2016 12:01:36 +0300 Message-ID: <874ma6b827.fsf@intel.com> References: <1462843220-15092-1-git-send-email-airlied@gmail.com> <87d1ouba6t.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 086D16E5D5 for ; Tue, 10 May 2016 09:01:53 +0000 (UTC) In-Reply-To: <87d1ouba6t.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAxMCBNYXkgMjAxNiwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVs LmNvbT4gd3JvdGU6Cj4gT24gVHVlLCAxMCBNYXkgMjAxNiwgRGF2ZSBBaXJsaWUgPGFpcmxpZWRA Z21haWwuY29tPiB3cm90ZToKPj4gRnJvbTogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAcmVkaGF0LmNv bT4KPj4KPj4gVGhpcyBqdXN0IG1ha2VzIHRoZSBjb2RlIGVhc2llciB0byBmb2xsb3cuCj4+Cj4+ IFNpZ25lZC1vZmYtYnk6IERhdmUgQWlybGllIDxhaXJsaWVkQHJlZGhhdC5jb20+Cj4KPiBSZXZp ZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KCk9vb3BzLCBvbmUg dGhpbmcgbmVlZHMgZml4aW5nIGJlbG93LgoKPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9k cm1fZWRpZC5jIHwgMTExICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t LS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDU5IGluc2VydGlvbnMoKyksIDUyIGRlbGV0aW9ucygt KQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2VkaWQuYwo+PiBpbmRleCA5NmIxODFhLi45ZGJhYWY0IDEwMDY0NAo+PiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0v ZHJtX2VkaWQuYwo+PiBAQCAtNDE1Miw2ICs0MTUyLDYwIEBAIGRybV9oZG1pX3ZlbmRvcl9pbmZv ZnJhbWVfZnJvbV9kaXNwbGF5X21vZGUoc3RydWN0IGhkbWlfdmVuZG9yX2luZm9mcmFtZSAqZnJh bWUsCj4+ICB9Cj4+ICBFWFBPUlRfU1lNQk9MKGRybV9oZG1pX3ZlbmRvcl9pbmZvZnJhbWVfZnJv bV9kaXNwbGF5X21vZGUpOwo+PiAgCj4+ICtzdGF0aWMgaW50IGRybV9wYXJzZV90aWxlZF9ibG9j ayhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+PiArCQkJCSBzdHJ1Y3QgZGlzcGxh eWlkX2Jsb2NrICpibG9jaykKPj4gK3sKPj4gKwlzdHJ1Y3QgZGlzcGxheWlkX3RpbGVkX2Jsb2Nr ICp0aWxlID0gKHN0cnVjdCBkaXNwbGF5aWRfdGlsZWRfYmxvY2sgKilibG9jazsKPj4gKwl1MTYg dywgaDsKPj4gKwl1OCB0aWxlX3ZfbG9jLCB0aWxlX2hfbG9jOwo+PiArCXU4IG51bV92X3RpbGUs IG51bV9oX3RpbGU7Cj4+ICsJc3RydWN0IGRybV90aWxlX2dyb3VwICp0ZzsKPj4gKwo+PiArCXcg PSB0aWxlLT50aWxlX3NpemVbMF0gfCB0aWxlLT50aWxlX3NpemVbMV0gPDwgODsKPj4gKwloID0g dGlsZS0+dGlsZV9zaXplWzJdIHwgdGlsZS0+dGlsZV9zaXplWzNdIDw8IDg7Cj4+ICsKPj4gKwlu dW1fdl90aWxlID0gKHRpbGUtPnRvcG9bMF0gJiAweGYpIHwgKHRpbGUtPnRvcG9bMl0gJiAweDMw KTsKPj4gKwludW1faF90aWxlID0gKHRpbGUtPnRvcG9bMF0gPj4gNCkgfCAoKHRpbGUtPnRvcG9b Ml0gPj4gMikgJiAweDMwKTsKPj4gKwl0aWxlX3ZfbG9jID0gKHRpbGUtPnRvcG9bMV0gJiAweGYp IHwgKCh0aWxlLT50b3BvWzJdICYgMHgzKSA8PCA0KTsKPj4gKwl0aWxlX2hfbG9jID0gKHRpbGUt PnRvcG9bMV0gPj4gNCkgfCAoKCh0aWxlLT50b3BvWzJdID4+IDIpICYgMHgzKSA8PCA0KTsKPj4g Kwo+PiArCWNvbm5lY3Rvci0+aGFzX3RpbGUgPSB0cnVlOwo+PiArCWlmICh0aWxlLT50aWxlX2Nh cCAmIDB4ODApCj4+ICsJCWNvbm5lY3Rvci0+dGlsZV9pc19zaW5nbGVfbW9uaXRvciA9IHRydWU7 Cj4+ICsKPj4gKwljb25uZWN0b3ItPm51bV9oX3RpbGUgPSBudW1faF90aWxlICsgMTsKPj4gKwlj b25uZWN0b3ItPm51bV92X3RpbGUgPSBudW1fdl90aWxlICsgMTsKPj4gKwljb25uZWN0b3ItPnRp bGVfaF9sb2MgPSB0aWxlX2hfbG9jOwo+PiArCWNvbm5lY3Rvci0+dGlsZV92X2xvYyA9IHRpbGVf dl9sb2M7Cj4+ICsJY29ubmVjdG9yLT50aWxlX2hfc2l6ZSA9IHcgKyAxOwo+PiArCWNvbm5lY3Rv ci0+dGlsZV92X3NpemUgPSBoICsgMTsKPj4gKwo+PiArCURSTV9ERUJVR19LTVMoInRpbGUgY2Fw IDB4JXhcbiIsIHRpbGUtPnRpbGVfY2FwKTsKPj4gKwlEUk1fREVCVUdfS01TKCJ0aWxlX3NpemUg JWQgeCAlZFxuIiwgdyArIDEsIGggKyAxKTsKPj4gKwlEUk1fREVCVUdfS01TKCJ0b3BvIG51bSB0 aWxlcyAlZHglZCwgbG9jYXRpb24gJWR4JWRcbiIsCj4+ICsJCSAgICAgIG51bV9oX3RpbGUgKyAx LCBudW1fdl90aWxlICsgMSwgdGlsZV9oX2xvYywgdGlsZV92X2xvYyk7Cj4+ICsJRFJNX0RFQlVH X0tNUygidmVuZCAlYyVjJWNcbiIsIHRpbGUtPnRvcG9sb2d5X2lkWzBdLCB0aWxlLT50b3BvbG9n eV9pZFsxXSwgdGlsZS0+dG9wb2xvZ3lfaWRbMl0pOwo+PiArCj4+ICsJdGcgPSBkcm1fbW9kZV9n ZXRfdGlsZV9ncm91cChjb25uZWN0b3ItPmRldiwgdGlsZS0+dG9wb2xvZ3lfaWQpOwo+PiArCWlm ICghdGcpIHsKPj4gKwkJdGcgPSBkcm1fbW9kZV9jcmVhdGVfdGlsZV9ncm91cChjb25uZWN0b3It PmRldiwgdGlsZS0+dG9wb2xvZ3lfaWQpOwo+PiArCX0KPj4gKwlpZiAoIXRnKQo+PiArCQlyZXR1 cm4gLUVOT01FTTsKPj4gKwo+PiArCWlmIChjb25uZWN0b3ItPnRpbGVfZ3JvdXAgIT0gdGcpIHsK Pj4gKwkJLyogaWYgd2UgaGF2ZW4ndCBnb3QgYSBwb2ludGVyLAo+PiArCQkgICB0YWtlIHRoZSBy ZWZlcmVuY2UsIGRyb3AgcmVmIHRvIG9sZCB0aWxlIGdyb3VwICovCj4+ICsJCWlmIChjb25uZWN0 b3ItPnRpbGVfZ3JvdXApIHsKPj4gKwkJCWRybV9tb2RlX3B1dF90aWxlX2dyb3VwKGNvbm5lY3Rv ci0+ZGV2LCBjb25uZWN0b3ItPnRpbGVfZ3JvdXApOwo+PiArCQl9Cj4+ICsJCWNvbm5lY3Rvci0+ dGlsZV9ncm91cCA9IHRnOwo+PiArCX0gZWxzZQo+PiArCQkvKiBpZiBzYW1lIHRpbGUgZ3JvdXAs IHRoZW4gcmVsZWFzZSB0aGUgcmVmIHdlIGp1c3QgdG9vay4gKi8KPj4gKwkJZHJtX21vZGVfcHV0 X3RpbGVfZ3JvdXAoY29ubmVjdG9yLT5kZXYsIHRnKTsKPj4gKwlyZXR1cm4gMDsKPj4gK30KPj4g Kwo+PiAgc3RhdGljIGludCBkcm1fcGFyc2VfZGlzcGxheV9pZChzdHJ1Y3QgZHJtX2Nvbm5lY3Rv ciAqY29ubmVjdG9yLAo+PiAgCQkJCXU4ICpkaXNwbGF5aWQsIGludCBsZW5ndGgsCj4+ICAJCQkJ Ym9vbCBpc19lZGlkX2V4dGVuc2lvbikKPj4gQEAgLTQxNjIsNiArNDIxNiw3IEBAIHN0YXRpYyBp bnQgZHJtX3BhcnNlX2Rpc3BsYXlfaWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwK Pj4gIAlzdHJ1Y3QgZGlzcGxheWlkX2Jsb2NrICpibG9jazsKPj4gIAl1OCBjc3VtID0gMDsKPj4g IAlpbnQgaTsKPj4gKwlpbnQgcmV0Owo+PiAgCj4+ICAJaWYgKGlzX2VkaWRfZXh0ZW5zaW9uKQo+ PiAgCQlpZHggPSAxOwo+PiBAQCAtNDE4Nyw1OCArNDI0MiwxMCBAQCBzdGF0aWMgaW50IGRybV9w YXJzZV9kaXNwbGF5X2lkKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4+ICAJCSAg ICAgIGJsb2NrLT50YWcsIGJsb2NrLT5yZXYsIGJsb2NrLT5udW1fYnl0ZXMpOwo+PiAgCj4+ICAJ c3dpdGNoIChibG9jay0+dGFnKSB7Cj4+IC0JY2FzZSBEQVRBX0JMT0NLX1RJTEVEX0RJU1BMQVk6 IHsKPj4gLQkJc3RydWN0IGRpc3BsYXlpZF90aWxlZF9ibG9jayAqdGlsZSA9IChzdHJ1Y3QgZGlz cGxheWlkX3RpbGVkX2Jsb2NrICopYmxvY2s7Cj4+IC0KPj4gLQkJdTE2IHcsIGg7Cj4+IC0JCXU4 IHRpbGVfdl9sb2MsIHRpbGVfaF9sb2M7Cj4+IC0JCXU4IG51bV92X3RpbGUsIG51bV9oX3RpbGU7 Cj4+IC0JCXN0cnVjdCBkcm1fdGlsZV9ncm91cCAqdGc7Cj4+IC0KPj4gLQkJdyA9IHRpbGUtPnRp bGVfc2l6ZVswXSB8IHRpbGUtPnRpbGVfc2l6ZVsxXSA8PCA4Owo+PiAtCQloID0gdGlsZS0+dGls ZV9zaXplWzJdIHwgdGlsZS0+dGlsZV9zaXplWzNdIDw8IDg7Cj4+IC0KPj4gLQkJbnVtX3ZfdGls ZSA9ICh0aWxlLT50b3BvWzBdICYgMHhmKSB8ICh0aWxlLT50b3BvWzJdICYgMHgzMCk7Cj4+IC0J CW51bV9oX3RpbGUgPSAodGlsZS0+dG9wb1swXSA+PiA0KSB8ICgodGlsZS0+dG9wb1syXSA+PiAy KSAmIDB4MzApOwo+PiAtCQl0aWxlX3ZfbG9jID0gKHRpbGUtPnRvcG9bMV0gJiAweGYpIHwgKCh0 aWxlLT50b3BvWzJdICYgMHgzKSA8PCA0KTsKPj4gLQkJdGlsZV9oX2xvYyA9ICh0aWxlLT50b3Bv WzFdID4+IDQpIHwgKCgodGlsZS0+dG9wb1syXSA+PiAyKSAmIDB4MykgPDwgNCk7Cj4+IC0KPj4g LQkJY29ubmVjdG9yLT5oYXNfdGlsZSA9IHRydWU7Cj4+IC0JCWlmICh0aWxlLT50aWxlX2NhcCAm IDB4ODApCj4+IC0JCQljb25uZWN0b3ItPnRpbGVfaXNfc2luZ2xlX21vbml0b3IgPSB0cnVlOwo+ PiAtCj4+IC0JCWNvbm5lY3Rvci0+bnVtX2hfdGlsZSA9IG51bV9oX3RpbGUgKyAxOwo+PiAtCQlj b25uZWN0b3ItPm51bV92X3RpbGUgPSBudW1fdl90aWxlICsgMTsKPj4gLQkJY29ubmVjdG9yLT50 aWxlX2hfbG9jID0gdGlsZV9oX2xvYzsKPj4gLQkJY29ubmVjdG9yLT50aWxlX3ZfbG9jID0gdGls ZV92X2xvYzsKPj4gLQkJY29ubmVjdG9yLT50aWxlX2hfc2l6ZSA9IHcgKyAxOwo+PiAtCQljb25u ZWN0b3ItPnRpbGVfdl9zaXplID0gaCArIDE7Cj4+IC0KPj4gLQkJRFJNX0RFQlVHX0tNUygidGls ZSBjYXAgMHgleFxuIiwgdGlsZS0+dGlsZV9jYXApOwo+PiAtCQlEUk1fREVCVUdfS01TKCJ0aWxl X3NpemUgJWQgeCAlZFxuIiwgdyArIDEsIGggKyAxKTsKPj4gLQkJRFJNX0RFQlVHX0tNUygidG9w byBudW0gdGlsZXMgJWR4JWQsIGxvY2F0aW9uICVkeCVkXG4iLAo+PiAtCQkgICAgICAgbnVtX2hf dGlsZSArIDEsIG51bV92X3RpbGUgKyAxLCB0aWxlX2hfbG9jLCB0aWxlX3ZfbG9jKTsKPj4gLQkJ RFJNX0RFQlVHX0tNUygidmVuZCAlYyVjJWNcbiIsIHRpbGUtPnRvcG9sb2d5X2lkWzBdLCB0aWxl LT50b3BvbG9neV9pZFsxXSwgdGlsZS0+dG9wb2xvZ3lfaWRbMl0pOwo+PiAtCj4+IC0JCXRnID0g ZHJtX21vZGVfZ2V0X3RpbGVfZ3JvdXAoY29ubmVjdG9yLT5kZXYsIHRpbGUtPnRvcG9sb2d5X2lk KTsKPj4gLQkJaWYgKCF0Zykgewo+PiAtCQkJdGcgPSBkcm1fbW9kZV9jcmVhdGVfdGlsZV9ncm91 cChjb25uZWN0b3ItPmRldiwgdGlsZS0+dG9wb2xvZ3lfaWQpOwo+PiAtCQl9Cj4+IC0JCWlmICgh dGcpCj4+IC0JCQlyZXR1cm4gLUVOT01FTTsKPj4gLQo+PiAtCQlpZiAoY29ubmVjdG9yLT50aWxl X2dyb3VwICE9IHRnKSB7Cj4+IC0JCQkvKiBpZiB3ZSBoYXZlbid0IGdvdCBhIHBvaW50ZXIsCj4+ IC0JCQkgICB0YWtlIHRoZSByZWZlcmVuY2UsIGRyb3AgcmVmIHRvIG9sZCB0aWxlIGdyb3VwICov Cj4+IC0JCQlpZiAoY29ubmVjdG9yLT50aWxlX2dyb3VwKSB7Cj4+IC0JCQkJZHJtX21vZGVfcHV0 X3RpbGVfZ3JvdXAoY29ubmVjdG9yLT5kZXYsIGNvbm5lY3Rvci0+dGlsZV9ncm91cCk7Cj4+IC0J CQl9Cj4+IC0JCQljb25uZWN0b3ItPnRpbGVfZ3JvdXAgPSB0ZzsKPj4gLQkJfSBlbHNlCj4+IC0J CQkvKiBpZiBzYW1lIHRpbGUgZ3JvdXAsIHRoZW4gcmVsZWFzZSB0aGUgcmVmIHdlIGp1c3QgdG9v ay4gKi8KPj4gLQkJCWRybV9tb2RlX3B1dF90aWxlX2dyb3VwKGNvbm5lY3Rvci0+ZGV2LCB0Zyk7 Cj4+IC0JfQo+PiAtCQlicmVhazsKPj4gKwljYXNlIERBVEFfQkxPQ0tfVElMRURfRElTUExBWToK Pj4gKwkJcmV0ID0gZHJtX3BhcnNlX3RpbGVkX2Jsb2NrKGNvbm5lY3RvciwgYmxvY2spOwo+PiAr CQlpZiAocmV0KQo+PiArCQkJcmV0dXJuIHJldDsKCmJyZWFrOyBoZXJlLgoKPj4gIAlkZWZhdWx0 Ogo+PiAgCQlwcmludGsoInVua25vd24gZGlzcGxheWlkIHRhZyAlZFxuIiwgYmxvY2stPnRhZyk7 Cj4+ICAJCWJyZWFrOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9s b2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK